Rev 161 | Blame | Compare with Previous | Last modification | View Log | RSS feed
<%@LANGUAGE="VBSCRIPT"%><%Option explicitResponse.Expires = 0 ' always load the page, dont store%><%'=====================================================' Update Code Review'=====================================================%><!--#include file="common/conf.asp"--><!--#include file="common/globals.asp"--><!--#include file="common/formating.asp"--><!--#include file="common/qstr.asp"--><!--#include file="common/common_subs.asp"--><!--#include file="common/common_dbedit.asp"--><!--#include file="common/_popup_window_common.asp"--><%' Set rfile parameter. This is a return page after LoginCall objPMod.StoreParameter ( "rfile", "fixed_issues.asp" )'------------ ACCESS CONTROL ------------------%><!--#include file="_access_control_login.asp"--><!--#include file="_access_control_general.asp"--><!--#include file="_access_control_project.asp"--><%'------------ Variable Definition -------------Dim parPv_idDim rsQryDim arrItemResultsDim arrOverallResultsDim pkgNameDim pkgVersion'------------ Constants Declaration -----------'------------ Variable Init -------------------parPv_id = Request("pv_id")parRtag_id = Request("rtag_id")arrItemResults = Array ( "","","", _"Pass",enumCODE_REVIEW_PASS,"class='pass_alert'", _"Fail",enumCODE_REVIEW_FAIL,"class='err_alert'" )arrOverallResults = Array ( "","", _"Accepted",enumCODE_REVIEW_ACCEPTED, _"Minor updates required",enumCODE_REVIEW_MINOR_UPDATES, _"Major rework required",enumCODE_REVIEW_MAJOR_REWORK )'----------------------------------------------%><%'-----------------------------------------------------------------------------------------------------------------------------------Sub GetCodeReview ( nPv_id, oRS )Dim Query_StringQuery_String = _" SELECT * FROM CODE_REVIEWS WHERE pv_id = :PV_ID"Query_String = Replace( Query_String, ":PV_ID", nPv_id )Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))' Make sure therer is always a record to read fromIf oRS.RecordCount < 1 ThenoRS.CloseCall InserDefaultRow ( parPv_id )Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))End IfEnd Sub'-----------------------------------------------------------------------------------------------------------------------------------Function DrawItemResult ( cCheck )Dim item, val, maxOptions, selected, tempSTRmaxOptions = UBound( arrItemResults )tempSTR = ""For val = 0 to maxOptions Step 3selected = ""If CStr( arrItemResults(val + 1) ) = cCheck Then selected = "selected"tempSTR = tempSTR & "<option value='"& arrItemResults( val + 1 ) &"' "& selected &" "& arrItemResults(val + 2) &">"& arrItemResults( val ) &"</option>"& VBNewLineNextDrawItemResult = tempSTREnd Function'-----------------------------------------------------------------------------------------------------------------------------------Function DrawOverallResult ( ByVal nResult )Dim val, maxOptions, tempSTR, selectedmaxOptions = Ubound( arrOverallResults )If nResult = "" OR IsNull(nResult) Then nResult = 0tempSTR = ""For val = 0 To maxOptions Step 2selected = ""If arrOverallResults(val + 1) = CInt( nResult ) Then selected = "selected"tempSTR = tempSTR & "<option value='"& arrOverallResults( val + 1 ) &"' "& selected &">"& arrOverallResults( val ) &"</option>"& VBNewLineNextDrawOverallResult = tempSTREnd Function'-----------------------------------------------------------------------------------------------------------------------------------Sub InserDefaultRow ( nPv_id )objEH.TryORA ( OraSession )On Error Resume NextOraDatabase.ExecuteSQL _" INSERT INTO CODE_REVIEWS (pv_id) VALUES("& nPv_id &")"objEH.CatchORA ( OraSession )End Sub'-----------------------------------------------------------------------------------------------------------------------------------%><%'------------ Action Requirements -------------------'Process submitionIf CBool(Request("action")) AND objAccessControl.UserLogedIn ThenCall UpdateCodeReview ( parPv_id )Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )'Response.Redirect ( "_wform_code_review.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )'Call CloseWindowEnd IfCall Get_Pkg_Short_Info( parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, NULL )Call GetCodeReview ( parPv_id, rsQry )%><html><head><title>Release Manager</title><meta HTTP-EQUIV="Pragma" CONTENT="no-cache"><meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"><link rel="stylesheet" href="images/release_manager_style.css" type="text/css"><link rel="stylesheet" href="images/navigation.css" type="text/css"><script language="JavaScript" src="images/common.js"></script><!-- TIPS --><script language="JavaScript" src="images/tipster.js"></script><script language="JavaScript" src="images/_help_tips.js"></script></head><body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();"><!-- TIPS LAYERS --------------------------------------><div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10"> </div><!-----------------------------------------------------><form action="_wform_code_review.asp" method="post" name="codereview"onSubmit=" MM_validateForm('date_of_review','Date of Review','RisDate','time_spent','Time Spent','RisNumber','review_reason','Reason for Review','RmaxLength:4000','files_reviewed','Files Reviewed','RmaxLength:4000','review_results','Review Results','R','issues_raised','Issues Raised','RmaxLength:4000');if (review_comments.value!='') {MM_validateForm('review_comments','Comments','RmaxLength:4000');};if (rteam_domain_expert.value!='') {MM_validateForm('rteam_domain_expert','Domain Expert','RmaxLength:4000');};if (rteam_language_expert.value!='') {MM_validateForm('rteam_language_expert','Language Expert','RmaxLength:4000');};if (rteam_peer_developer.value!='') {MM_validateForm('rteam_peer_developer','Peer Expert','RmaxLength:4000');};if (rteam_author.value!='') {MM_validateForm('rteam_author','Author','RmaxLength:4000');};if (fnc_c_meets_functionality.value!='') {MM_validateForm('fnc_c_meets_functionality','FUNCTIONALITY: Meets required functionality','RmaxLength:4000');};if (rbs_c_bound_cond_handled.value!='') {MM_validateForm('rbs_c_bound_cond_handled','ROBUSTNESS: Boundary conditions handled','RmaxLength:4000');};if (rbs_c_class_interf_precond.value!='') {MM_validateForm('rbs_c_class_interf_precond','ROBUSTNESS: Class interface preconditions tested','RmaxLength:4000');};if (rbs_c_no_unitialised_date.value!='') {MM_validateForm('rbs_c_no_unitialised_date','ROBUSTNESS: No unititalised data','RmaxLength:4000');};if (rbs_c_excep_handing.value!='') {MM_validateForm('rbs_c_excep_handing','ROBUSTNESS: Exception handling','RmaxLength:4000');};if (rbs_c_resource_mng.value!='') {MM_validateForm('rbs_c_resource_mng','ROBUSTNESS: Resource mgt (db cxn, memory)','RmaxLength:4000');};if (rbs_c_trans_complet.value!='') {MM_validateForm('rbs_c_trans_complet','ROBUSTNESS: Transaction completeness','RmaxLength:4000');};if (rbs_c_threadsafety.value!='') {MM_validateForm('rbs_c_threadsafety','ROBUSTNESS: Threadsafety','RmaxLength:4000');};if (rbs_c_ret_vals.value!='') {MM_validateForm('rbs_c_ret_vals','ROBUSTNESS: Return values (where appropriate)','RmaxLength:4000');};if (rbs_c_corr_err_handling.value!='') {MM_validateForm('rbs_c_corr_err_handling','ROBUSTNESS: Correct err handling at Subsys bdys','RmaxLength:4000');};if (rbs_c_sql_std.value!='') {MM_validateForm('rbs_c_sql_std','ROBUSTNESS: SQL correct and conforming to standards','RmaxLength:4000');};if (mnt_c_ext_ref.value!='') {MM_validateForm('mnt_c_ext_ref','MAINTAINABILITY: External references explicit (eg: pkg imports)','RmaxLength:4000');};if (mnt_c_class_size.value!='') {MM_validateForm('mnt_c_class_size','MAINTAINABILITY: Class size ok','RmaxLength:4000');};if (mnt_c_method_size.value!='') {MM_validateForm('mnt_c_method_size','MAINTAINABILITY: Method size ok','RmaxLength:4000');};if (mnt_c_approp_comm.value!='') {MM_validateForm('mnt_c_approp_comm','MAINTAINABILITY: Appropriate commenting','RmaxLength:4000');};if (mnt_c_ident_name_std.value!='') {MM_validateForm('mnt_c_ident_name_std','MAINTAINABILITY: Indentifiers conform to naming standards','RmaxLength:4000');};if (mnt_c_switch_have_defaults.value!='') {MM_validateForm('mnt_c_switch_have_defaults','MAINTAINABILITY: Switch statements have defaults','RmaxLength:4000');};if (mnt_c_no_lit_num.value!='') {MM_validateForm('mnt_c_no_lit_num','MAINTAINABILITY: No literal numeric constants except 1, 0, 1','RmaxLength:4000');};if (mnt_c_no_dead_code.value!='') {MM_validateForm('mnt_c_no_dead_code','MAINTAINABILITY: No dead or unused code','RmaxLength:4000');};if (dei_c_std_des_patt.value!='') {MM_validateForm('dei_c_std_des_patt','DESIGN ISSUES: Use of standard design patterns','RmaxLength:4000');};if (dei_c_approp_algor.value!='') {MM_validateForm('dei_c_approp_algor','DESIGN ISSUES: Use of appropriate algorithms (consider performance)','RmaxLength:4000');};if (dei_c_approp_obj.value!='') {MM_validateForm('dei_c_approp_obj','DESIGN ISSUES: Use of appropriate objects (consider bloat, object focus, encapsulation)','RmaxLength:4000');};if (dei_c_approp_err_msg.value!='') {MM_validateForm('dei_c_approp_err_msg','DESIGN ISSUES: Appropriate user error messages','RmaxLength:4000');};if (dei_c_std_framew_comp.value!='') {MM_validateForm('dei_c_std_framew_comp','DESIGN ISSUES: Use of standard framework components','RmaxLength:4000');};if (dei_c_approp_logging.value!='') {MM_validateForm('dei_c_approp_logging','DESIGN ISSUES: Appropriate logging','RmaxLength:4000');};return document.MM_returnValue;"><table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%"><tr><td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td><td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl"> Code Review for <%=pkgName%> <%=pkgVersion%> </td><td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl"><input type="submit" name="btn" value="Save" class="form_btn"><input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()"></td><td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td></tr><tr><td height="100%" width="1%"> </td><td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif"><br><br><table width="100%" border="0" cellspacing="0" cellpadding="0"><tr><td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td><td width="100%"><table width="100%" border="0" cellspacing="1" cellpadding="4"><tr align="center"><td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td><td nowrap bgcolor="#FFFFFF" class="form_item"><input name="date_of_review" type="text" size="20" maxlength="20" class="form_item" value='<%If IsNull(rsQry("date_of_review")) Then%><%=EuroDate ( Date )%><%Else%><%=EuroDate ( rsQry("date_of_review") )%><%End If%>'> </td><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field"> Time Spent (hrs)</td><td bgcolor="#FFFFFF" class="form_item"><input name="time_spent" type="text" size="20" maxlength="20" class="form_item" value="<%=rsQry("time_spent")%>"></td></tr><tr><td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td><td colspan="3" bgcolor="#FFFFFF" class="form_item"><textarea name="review_reason" cols="80" rows="5" class="form_item"><%=rsQry("review_reason")%></textarea></td></tr><tr><td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td><td colspan="2" bgcolor="#FFFFFF" class="form_item"><textarea name="rteam_domain_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_domain_expert")%></textarea></td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td><td colspan="2" bgcolor="#FFFFFF" class="form_item"><textarea name="rteam_language_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_language_expert")%></textarea></td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td><td colspan="2" bgcolor="#FFFFFF" class="form_item"><textarea name="rteam_peer_developer" cols="60" rows="2" class="form_item"><%=rsQry("rteam_peer_developer")%></textarea></td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td><td colspan="2" bgcolor="#FFFFFF" class="form_item"><textarea name="rteam_author" cols="60" rows="2" class="form_item"><%=rsQry("rteam_author")%></textarea></td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td><td colspan="3" bgcolor="#FFFFFF" class="form_item"><textarea name="files_reviewed" cols="80" rows="5" class="form_item"><%=rsQry("files_reviewed")%></textarea></td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td><td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" class="form_item" id="review_results"><%=DrawOverallResult ( rsQry("review_results") )%></select></td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td><td colspan="3" bgcolor="#FFFFFF" class="form_item"><textarea name="issues_raised" cols="80" rows="5" class="form_item"><%=rsQry("issues_raised")%></textarea></td></tr><tr><td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td><td colspan="3" bgcolor="#FFFFFF" class="form_item"><textarea name="review_comments" cols="80" rows="5" class="form_item"><%=rsQry("review_comments")%></textarea></td></tr></table><br><br><table width="100%" border="0" cellspacing="1" cellpadding="4"><tr align="center"><td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td></tr><tr><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td><td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td><td valign="top" bgcolor="#FFFFFF"><select name="fnc_s_meets_functionality" class="form_item" id="fnc_s_meets_functionality"><%=DrawItemResult( rsQry("fnc_s_meets_functionality") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="fnc_c_meets_functionality" cols="60" rows="3" class="form_item"><%=rsQry("fnc_c_meets_functionality")%></textarea></td></tr></table><br><br><table width="100%" border="0" cellspacing="1" cellpadding="4"><tr align="center"><td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td></tr><tr><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td><td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_bound_cond_handled" class="form_item" id="rbs_s_bound_cond_handled"><%=DrawItemResult( rsQry("rbs_s_bound_cond_handled") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_bound_cond_handled" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_bound_cond_handled")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" class="form_item" id="rbs_s_class_interf_precond"><%=DrawItemResult( rsQry("rbs_s_class_interf_precond") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_class_interf_precond" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_class_interf_precond")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" class="form_item" id="rbs_s_no_unitialised_date"><%=DrawItemResult( rsQry("rbs_s_no_unitialised_date") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_no_unitialised_date" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_no_unitialised_date")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" class="form_item" id="rbs_s_excep_handing"><%=DrawItemResult( rsQry("rbs_s_excep_handing") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_excep_handing" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_excep_handing")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" class="form_item" id="rbs_s_resource_mng"><%=DrawItemResult( rsQry("rbs_s_resource_mng") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_resource_mng" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_resource_mng")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" class="form_item" id="rbs_s_trans_complet"><%=DrawItemResult( rsQry("rbs_s_trans_complet") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_trans_complet" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_trans_complet")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" class="form_item" id="rbs_s_threadsafety"><%=DrawItemResult( rsQry("rbs_s_threadsafety") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_threadsafety" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_threadsafety")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" class="form_item" id="rbs_s_ret_vals"><%=DrawItemResult( rsQry("rbs_s_ret_vals") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_ret_vals" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_ret_vals")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" class="form_item" id="rbs_s_corr_err_handling"><%=DrawItemResult( rsQry("rbs_s_corr_err_handling") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_corr_err_handling" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_corr_err_handling")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td><td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" class="form_item" id="rbs_s_sql_std"><%=DrawItemResult( rsQry("rbs_s_sql_std") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="rbs_c_sql_std" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_sql_std")%></textarea></td></tr></table><br><br><table width="100%" border="0" cellspacing="1" cellpadding="4"><tr align="center"><td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td></tr><tr><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td><td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ext_ref" class="form_item" id="mnt_s_ext_ref"><%=DrawItemResult( rsQry("mnt_s_ext_ref") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_ext_ref" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ext_ref")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_class_size" class="form_item" id="mnt_s_class_size"><%=DrawItemResult( rsQry("mnt_s_class_size") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_class_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_class_size")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_method_size" class="form_item" id="mnt_s_method_size"><%=DrawItemResult( rsQry("mnt_s_method_size") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_method_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_method_size")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_approp_comm" class="form_item" id="mnt_s_approp_comm"><%=DrawItemResult( rsQry("mnt_s_approp_comm") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_approp_comm" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_approp_comm")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ident_name_std" class="form_item" id="mnt_s_ident_name_std"><%=DrawItemResult( rsQry("mnt_s_ident_name_std") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_ident_name_std" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ident_name_std")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_switch_have_defaults" class="form_item" id="mnt_s_switch_have_defaults"><%=DrawItemResult( rsQry("mnt_s_switch_have_defaults") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_switch_have_defaults" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_switch_have_defaults")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except 1, 0, 1</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_lit_num" class="form_item" id="mnt_s_no_lit_num"><%=DrawItemResult( rsQry("mnt_s_no_lit_num") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_no_lit_num" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_lit_num")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td><td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_dead_code" class="form_item" id="mnt_s_no_dead_code"><%=DrawItemResult( rsQry("mnt_s_no_dead_code") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="mnt_c_no_dead_code" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_dead_code")%></textarea></td></tr></table><br><br><table width="100%" border="0" cellspacing="1" cellpadding="4"><tr align="center"><td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td></tr><tr><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td><td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td><td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td><td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_des_patt" class="form_item" id="dei_s_std_des_patt"><%=DrawItemResult( rsQry("dei_s_std_des_patt") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="dei_c_std_des_patt" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_des_patt")%></textarea></td></tr><tr><td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td><td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_algor" class="form_item" id="dei_s_approp_algor"><%=DrawItemResult( rsQry("dei_s_approp_algor") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="dei_c_approp_algor" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_algor")%></textarea></td></tr><tr><td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td><td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_obj" class="form_item" id="dei_s_approp_obj"><%=DrawItemResult( rsQry("dei_s_approp_obj") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="dei_c_approp_obj" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_obj")%></textarea></td></tr><tr><td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td><td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_err_msg" class="form_item" id="dei_s_approp_err_msg"><%=DrawItemResult( rsQry("dei_s_approp_err_msg") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="dei_c_approp_err_msg" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_err_msg")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td><td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_framew_comp" class="form_item" id="dei_s_std_framew_comp"><%=DrawItemResult( rsQry("dei_s_std_framew_comp") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="dei_c_std_framew_comp" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_framew_comp")%></textarea></td></tr><tr><td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td><td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_logging" class="form_item" id="dei_s_approp_logging"><%=DrawItemResult( rsQry("dei_s_approp_logging") )%></select></td><td bgcolor="#FFFFFF" class="form_item"><textarea name="dei_c_approp_logging" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_logging")%></textarea></td></tr></table><br><br></td></tr></table></td></tr><tr><td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td><td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right"><input type="submit" name="btn" value="Save" class="form_btn"><input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()"></td></tr></table><input type="hidden" name="action" value="true"><input type="hidden" name="pv_id" value="<%=parPv_id%>"><input type="hidden" name="rtag_id" value="<%=parRtag_id%>"></form></body></html><%rsQry.CloseSet rsQry = Nothing%><!-- DESTRUCTOR -------><!--#include file="common/destructor.asp"-->