Subversion Repositories DevTools

Rev

Rev 161 | Blame | Compare with Previous | Last modification | View Log | RSS feed 

<%@LANGUAGE="VBSCRIPT"%>
<%
Option explicit
Response.Expires = 0   ' always load the page, dont store
%>
<%
'=====================================================
'               Code Review
'=====================================================
%>
<!--#include file="common/conf.asp"-->
<!--#include file="common/globals.asp"-->
<!--#include file="common/formating.asp"-->
<!--#include file="common/qstr.asp"-->
<!--#include file="common/common_subs.asp"-->
<!--#include file="common/common_dbedit.asp"-->
<!--#include file="common/_popup_window_common.asp"-->
<%
' Set rfile parameter. This is a return page after Login
Call objPMod.StoreParameter ( "rfile", "fixed_issues.asp" )
'------------ ACCESS CONTROL ------------------
%>
<!--#include file="_access_control_login.asp"-->
<!--#include file="_access_control_general.asp"-->
<!--#include file="_access_control_project.asp"-->
<%
'------------ Variable Definition -------------
Dim parPv_id
Dim rsQry
Dim pkgName
Dim pkgVersion
Dim isDLocked
Dim pageIsEditable
'------------ Constants Declaration -----------
'------------ Variable Init -------------------
parPv_id = Request("pv_id")
parRtag_id = Request("rtag_id")
'----------------------------------------------
%>
<%
'-----------------------------------------------------------------------------------------------------------------------------------
Sub GetCodeReview ( nPv_id, oRS )
   Dim Query_String
   Query_String = _
   " SELECT *  FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
   Query_String = Replace( Query_String, ":PV_ID", nPv_id )

   Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
End Sub
'-----------------------------------------------------------------------------------------------------------------------------------
Function DecodeItemResult ( cCheck )

   Select Case cCheck
      Case enumCODE_REVIEW_PASS
         DecodeItemResult = "<option>Pass</option>"
      Case enumCODE_REVIEW_FAIL
         DecodeItemResult = "<option>Fail</option>"
      Case Else
         DecodeItemResult = "<option></option>"
   End Select

End Function
'-----------------------------------------------------------------------------------------------------------------------------------
Function DecodeOverallResult ( ByVal cCheck )
   If cCheck = "" OR IsNull(cCheck) Then cCheck = 0

   Select Case CInt( cCheck )
      Case enumCODE_REVIEW_ACCEPTED
         DecodeOverallResult = "<option>Accepted</option>"
      Case enumCODE_REVIEW_MINOR_UPDATES
         DecodeOverallResult = "<option>Minor updates required</option>"
      Case enumCODE_REVIEW_MAJOR_REWORK
         DecodeOverallResult = "<option>Major rework required</option>"
      Case Else
         DecodeOverallResult = "<option></option>"
   End Select

End Function
'-----------------------------------------------------------------------------------------------------------------------------------
Function ConstructSQL ( nPv_id, sQuery )
   Dim SQLqry, arrLineSplit, arrParamSplit, line
   Const localPARAM_SPLIT = ":"

   SQLqry = ReadFile( sQuery )

   arrLineSplit = Split ( SQLqry, VBNewLine )

   For Each line in arrLineSplit
      arrParamSplit = Split ( line, localPARAM_SPLIT )      ' Split the line with ":" e.g. some_column = ':param_name:',
      If Ubound( arrParamSplit ) > 0 Then
         SQLqry = Replace( SQLqry, localPARAM_SPLIT  & arrParamSplit( 1 ) & localPARAM_SPLIT, Replace( Request( arrParamSplit( 1 ) ), "'", "''") )
      End If
   Next

   ConstructSQL = SQLqry

End Function
'-----------------------------------------------------------------------------------------------------------------------------------
Sub UpdateCodeReview ( nPv_id )
   Dim SQLstr
   SQLstr  = ConstructSQL ( nPv_id, rootPath & "queries\update_code_review.sql" )

   objEH.TryORA ( OraSession )
   On Error Resume Next

   OraDatabase.ExecuteSQL  SQLstr

   objEH.CatchORA ( OraSession )
End Sub
'-----------------------------------------------------------------------------------------------------------------------------------
%>
<%
'------------ Action Requirements -------------------
'Process submition
If CBool(Request("action")) AND  objAccessControl.UserLogedIn  Then

   Call UpdateCodeReview ( parPv_id )
   Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
   'Call CloseWindow

End If

Call Get_Pkg_Short_Info( parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, isDLocked )
Call GetCodeReview ( parPv_id, rsQry )
pageIsEditable = Is_Page_Editable ( isDLocked )
%>
<html>
<head>
<title>Release Manager</title>
<meta HTTP-EQUIV="Pragma" CONTENT="no-cache">
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="stylesheet" href="images/release_manager_style.css" type="text/css">
<link rel="stylesheet" href="images/navigation.css" type="text/css">
<script language="JavaScript" src="images/common.js"></script>
<!-- TIPS -->
<script language="JavaScript" src="images/tipster.js"></script>
<script language="JavaScript" src="images/_help_tips.js"></script>
</head>
<body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
<!-- TIPS LAYERS -------------------------------------->
<div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10">&nbsp;</div>
<!----------------------------------------------------->
<form action="_wform_update_code_review.asp" method="post" name="codereview">
  <table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
    <tr>
      <td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
      <td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl">&nbsp;Code Review for <%=pkgName%>&nbsp;<%=pkgVersion%> </td>
     <td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
      <input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
      <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
      </td>
      <td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td>
    </tr>
    <tr>
      <td height="100%" width="1%">&nbsp;</td>
      <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
        <br>
        <br>
        <table width="100%"  border="0" cellspacing="0" cellpadding="0">
          <tr>
            <td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
            <td width="100%">
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
           <tr align="center">
                <td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td>
                </tr>
           <tr>
            <td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
            <td width="1%" nowrap bgcolor="#FFFFFF" class="form_item"><%=EuroDate ( rsQry("date_of_review") )%>&nbsp;&nbsp;&nbsp;</td>
            <td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">&nbsp;&nbsp;&nbsp;Time Spent</td>
            <td width="100%" bgcolor="#FFFFFF" class="form_item"><%=rsQry("time_spent")%> hrs </td>
           </tr>
           <tr>
            <td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_reason") )))%></td>
           </tr>
           <tr>
            <td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_domain_expert") )))%></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_language_expert") )))%></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_peer_developer") )))%></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_author") )))%></td>
           </tr>
           <tr>
                <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
                <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("files_reviewed") )))%></td>
             </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" disabled class="form_item" id="review_results">
                  <%=DecodeOverallResult( rsQry("review_results") )%>
                </select></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("issues_raised") )))%></td>
           </tr>
           <tr>
             <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
             <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_comments") )))%></td>
             </tr>
         </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
              <tr align="center">
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td>
                </tr>
              <tr>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>
                <td valign="top" bgcolor="#FFFFFF"><select name="fnc_s_meets_functionality" disabled class="form_item" id="fnc_s_meets_functionality">
                  <%=DecodeItemResult( rsQry("fnc_s_meets_functionality") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("fnc_c_meets_functionality") )))%></td>
              </tr>
            </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
              <tr align="center">
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td>
              </tr>
              <tr>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_bound_cond_handled" disabled class="form_item" id="rbs_s_bound_cond_handled">
                    <%=DecodeItemResult( rsQry("rbs_s_bound_cond_handled") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_bound_cond_handled") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" disabled class="form_item" id="rbs_s_class_interf_precond">
                  <%=DecodeItemResult( rsQry("rbs_s_class_interf_precond") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_class_interf_precond") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" disabled class="form_item" id="rbs_s_no_unitialised_date">
                  <%=DecodeItemResult( rsQry("rbs_s_no_unitialised_date") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_no_unitialised_date") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" disabled class="form_item" id="rbs_s_excep_handing">
                  <%=DecodeItemResult( rsQry("rbs_s_excep_handing") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_excep_handing") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" disabled class="form_item" id="rbs_s_resource_mng">
                  <%=DecodeItemResult( rsQry("rbs_s_resource_mng") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_resource_mng") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" disabled class="form_item" id="rbs_s_trans_complet">
                  <%=DecodeItemResult( rsQry("rbs_s_trans_complet") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_trans_complet") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" disabled class="form_item" id="rbs_s_threadsafety">
                  <%=DecodeItemResult( rsQry("rbs_s_threadsafety") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_threadsafety") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" disabled class="form_item" id="rbs_s_ret_vals">
                  <%=DecodeItemResult( rsQry("rbs_s_ret_vals") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_ret_vals") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" disabled class="form_item" id="rbs_s_corr_err_handling">
                  <%=DecodeItemResult( rsQry("rbs_s_corr_err_handling") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_corr_err_handling") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" disabled class="form_item" id="rbs_s_sql_std">
                  <%=DecodeItemResult( rsQry("rbs_s_sql_std") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_sql_std") )))%></td>
              </tr>
            </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
              <tr align="center">
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td>
              </tr>
              <tr>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ext_ref" disabled class="form_item" id="mnt_s_ext_ref">
                    <%=DecodeItemResult( rsQry("mnt_s_ext_ref") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ext_ref") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_class_size" disabled class="form_item" id="mnt_s_class_size">
                    <%=DecodeItemResult( rsQry("mnt_s_class_size") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_class_size") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_method_size" disabled class="form_item" id="mnt_s_method_size">
                    <%=DecodeItemResult( rsQry("mnt_s_method_size") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_method_size") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_approp_comm" disabled class="form_item" id="mnt_s_approp_comm">
                    <%=DecodeItemResult( rsQry("mnt_s_approp_comm") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_approp_comm") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ident_name_std" disabled class="form_item" id="mnt_s_ident_name_std">
                    <%=DecodeItemResult( rsQry("mnt_s_ident_name_std") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ident_name_std") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_switch_have_defaults" disabled class="form_item" id="mnt_s_switch_have_defaults">
                    <%=DecodeItemResult( rsQry("mnt_s_switch_have_defaults") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_switch_have_defaults") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except –1, 0, 1</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_lit_num" disabled class="form_item" id="mnt_s_no_lit_num">
                    <%=DecodeItemResult( rsQry("mnt_s_no_lit_num") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_lit_num") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_dead_code" disabled class="form_item" id="mnt_s_no_dead_code">
                    <%=DecodeItemResult( rsQry("mnt_s_no_dead_code") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_dead_code") )))%></td>
              </tr>
            </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
              <tr align="center">
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td>
              </tr>
              <tr>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_des_patt" disabled class="form_item" id="dei_s_std_des_patt">
                    <%=DecodeItemResult( rsQry("dei_s_std_des_patt") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_des_patt") )))%></td>
              </tr>
              <tr>
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_algor" disabled class="form_item" id="dei_s_approp_algor">
                    <%=DecodeItemResult( rsQry("dei_s_approp_algor") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_algor") )))%></td>
              </tr>
              <tr>
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_obj" disabled class="form_item" id="dei_s_approp_obj">
                    <%=DecodeItemResult( rsQry("dei_s_approp_obj") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_obj") )))%></td>
              </tr>
              <tr>
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_err_msg" disabled class="form_item" id="dei_s_approp_err_msg">
                    <%=DecodeItemResult( rsQry("dei_s_approp_err_msg") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_err_msg") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_framew_comp" disabled class="form_item" id="dei_s_std_framew_comp">
                    <%=DecodeItemResult( rsQry("dei_s_std_framew_comp") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_framew_comp") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_logging" disabled class="form_item" id="dei_s_approp_logging">
                    <%=DecodeItemResult( rsQry("dei_s_approp_logging") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_logging") )))%></td>
              </tr>
            </table>
         <br>
         <br></td>
          </tr>
        </table></td>
    </tr>
    <tr>
      <td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
      <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right">
     <input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
     <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
     </td>
    </tr>
  </table>
  <input type="hidden" name="pv_id" value="<%=parPv_id%>">
  <input type="hidden" name="rtag_id" value="<%=parRtag_id%>">
</form>
</body>
</html>


<!-- DESTRUCTOR ------->
<!--#include file="common/destructor.asp"-->