Rev 1304 | Blame | Compare with Previous | Last modification | View Log | RSS feed
*** When upgrading, don't forget to: "cd bin ; ./install.pl" ****** Also, it is _highly_ advisable to backup your data before upgrading ***David Purdie: 19-Jul-12* Vix Subversion SupportAdded Subverion hintsAdded Subversion ConfigImproved error reportingModified base codestriker.pl to simplify the use of multiple configurationfiles without the need for duplicated copies of the code. Simplify codechanges.Each IIS webserver instance will address a different subdir withinthe one installation. Each subdir will have same codestriker.pl file anda different codestriker.conf file.Version 1.9.4* Emit a javascript warning if the external javascript files couldnot be loaded. This usually occurs due to apache misconfiguration.* Allow subversion repositories that communicate using the Subversionprotocol to be specified in @valid_repositories as'svn://my.subversion.server/repos/product/trunk' rather than'svn:svn://my.subversion.server/repos/product/trunk'.* Support subversion diff files which contain "Copied:" entries.* Improved patch file parsing for handling binary file changes.* Ensure emails sent contain the header "MIME-Version: 1.0" forRFC2045 conformance. Submitted by Vadim Zeitlin<vadz@users.sourceforge.net>.* CSS cleanups from Kannan Goundan <cakoose@users.sourceforge.net>.* Bottom coloured row on topic list screen didn't extend across fullwidth of browser window if bug-tracking or custom comment metricswere defined. This has now been fixed.* Place a clear divider between comment blocks on the view topiccomments screen, as suggested by Nikita V. Borodikhin<eliterr@users.sourceforge.net> to minimise confusion.* The topic comments tab count would incorrectly display the numberof comment threads rather than the number of comments, when viewingthe topic text. This has now been fixed.* Handle Subversion files which contain @ in the filename.* Codestriker now behaves correctly under mod_perl when retrievingdata externally from an SCM system, such as when the Parallel linkis clicked, or when a topic is created directly from the SCM.* Creating Subversion topics directly from the SCM now works correctlyin non-English locales.* When calculating metrics, make sure email addresses are handled ina case-insensitive manner. Also remove trailing/leading whitespacefrom the addresses.* Handle topic text that starts with the UTF-8 BOM.* Workaround for invalid diff files generated by Subversion in a Chineselocale. See http://marc.info/?l=subversion-users&m=118725115412403&w=3for more information.* Handle the different text types that may be present in a Perforce diff.Submitted by Russell Cattelan <cattelan@thebarn.com>.* Defined the "noconnection" option for $bug_db in codestriker.confso that it is possible to define what bug IDs are associated witha topic, without updating an actual bug database when the topicis created/closed. If $bugtracker is defined in codestriker.conf,then links will be created on the topic properties screen to theassociated bug records. Submitted by Russell Cattelan<cattelan@thebarn.com>.* Handle ClearCase diffs which contain "Directories are identical"lines in them. Submitted by Steve Kinsman<skinsman@users.sourceforge.net>.* Support for using the ClearCase dynamic view under Windows.Submitted by Steve Kinsman <skinsman@users.sourceforge.net>.Version 1.9.3* The project list screen now displays for each project, the totalnumber of open topics, and the total number of topics. Clicking onthe count will go to the topic list screen with the relevant topicsdisplayed.* Modified the VSS repository handler so that topics can be createdby either entering in labels or version numbers in the start andend tag fields when creating a topic. Previously, only labelswere supported.* The uri filter in the Template Toolkit changed its behaviour in 2.16,which was responsible for generating invalid links. This has nowbeen fixed.* Better handling of Subversion diffs which were generated onnon-English systems.Version 1.9.2* Codestriker now works with UTF-8 text, to support unicode characterinput for topic titles, descriptions, comment text, and projectnames and descriptions. This required making Perl 5.8 as apre-requisite, as Perl 5.6 doesn't cut the mustard for unicodeprocessing.* Created a new optional configuration parameter $repository_name_mapin codestriker.conf. This allows for a user-defined repository nameto be displayed in the codestriker UI, rather than the fullrepository URL. This can be useful for hiding potentially sensitiveusername/password information that might be a part of the repositoryURL. See the codestriker.conf file for more information.Submitted by Edwin Fine <edwin.m.fine@verizon.com>.* New repository module for linking to ClearCase dynamic views. Seethe configuration file and/or manual for example configurations.Submitted by Avinandan Sengupta <avinandan.sengupta@gmail.com>.* Modified the way Perforce retrieves files from the depot, as serversset with a security level of 2 or above were not receiving passwordinformation. This has been addressed by modifying the command lineto explictly pass in the password rather than the client workspacename, which is ignored for these security levels. The repositoryconfiguration for Perforce has also been changed to use the passwordin place of the client workspace name. Perforce users should updatetheir configuration files appropriately. Submitted byJ Dickon Glanville <jdglanville@users.sourceforge.net>.* Update CVS diff parser to handle rdiffs which have new/removed filesin them.* Creating a topic with an invalid bug ID is now shown as an error tothe user on the create topic screen.* If there was an error creating a topic, the selected project namewas not retained when the create topic screen was redisplayed. Thishas now been fixed.Submitted by Edwin Fine <edwin.m.fine@verizon.com>.* If there is a problem when a comment is created, the error messagewill correctly display in the AJAX'ed window. An example here is if$mailhost is incorrectly configured.* If there is an email problem while creating a topic, the errormessage is now correctly displayed to the end-user.* Fixed problem with Subversion repositories on Win32, whereCodestriker was unable to launch the svn program.* Comments containing '+' characters were changed into ' ' characterswhen posted via AJAX. Other potentially damaging characters are nowescaped.* Comments with '\' characters are now displayed correctly in allcases within the tooltip window.* Temporary files were not being deleted within theCodestrikerClient.pm module (used for auto-creation of topics on CVScommits). Reported by Martin Apel <Martin.Apel@softlab.de>.* Added support for parsing diffs generated using Subversion's svnlookprogram.* Matching of CVS repository paths when parsing topic text is nowcase insensitive to account for the different casing returned by theWindow clients: Cygwin and CvsNT.* Defining new entries in $comment_state_metrics in codestriker.confcould not be used for existing topics. This has now been fixed.* Support for sending email via SMTP authentication, via the optional$mailuser and $mailpasswd configuration parameters incodestriker.conf. Contributed by "Hertz Wang" <wanghz@neusoft.com>.* The ClearCase Snapshot repository was not using the $tmpdir settingin codestriker.conf if it was set when creating temporary files.This has now been fixed.Contributed by "John Farrelly (AT/LMI)" <john.farrelly@ericsson.com>.* Make sure the diffs in the topic are presented in a sorted order byfilename. Some SCMs create topic texts in a "semi-sorted" order,such as Subversion.Contributed by "Vladimir Vysotsky" <vvysotsky@avistar.com>.* Closed topics could still have comments added to them, by hoveringover an existing comment in the topic text view, and then clickingthe "Add Comment" link in the tooltip window. This link has nowbeen removed if the topic is closed.Contributed by ed.torbett@simulation-systems.co.uk.* Improved memory usage when integrated with very large LXR databases.Contributed by Patrick Diamond <patrick_diamond@mailc.net>.* Newer versions of the Subversion client (1.3.2) were returningwarning text that was not parsed correctly. This has now beenfixed. Contributed by Vladimir Sizikov <vsizikov@gmail.com>.* Make sure the generated Template Toolkit files are stored inthe web server's temporary directory, or $Codestriker::tmpdir ifthat is defined. Previously, the temporary files were being storedin sub-directories of cgi-bin.Version 1.9.1* Correct problem introduced in 1.9.0 release where the email addressfield in the add comment tooltip was not being stored correctly inthe Codestriker cookie. For reviewers who have never created aCodestriker topic, the email field not remember the previous value.This has now been corrected.* When adding a comment via a link from an email, the confirmationscreen now contains links to the topic text and topic comments, forconvenience.Version 1.9.0* Now using overlib javascript library(http://www.bosrup.com/web/overlib) for formatted "tooltips". Whenthe mouse hovers over a line where a comment has been made, aformatted "tooltip" window appears, which contains the comment textformatted appropriately, with author and date header informationbolded. The tooltip is not removed until the mouse is moved off theline. Help text on the create topic and search screens have beenmodified to use this tooltip library as well as opposed tojavascript alert windows.* Comments are now added view an overlib tooltip window, rather thanusing a separate browser window. This speeds up the reviewingprocess and keeps the reviewer focussed on a single browser window.* It is now possible to create a comment associated with a specificfile, or the topic itself, rather than being associated with aspecific line. This allows reviewers to create file-level ortopic-level comments.* There are patches available for Bugzilla 2.16 and Bugzilla 2.18 inthe bin subdirectory, where the view bug screen is modified toinclude the "Create a New Codestriker Topic" and "View All" linksdirectly under the "Create a New Attachment" and "View All" links.When a new topic is created via this link, the topic title will beset initially to the bug title, and the bug id field will be set tothe id of the bug record. Before applying the patch, thecodestriker_url variable must be set to the URL of your Codestrikerdeployment.* Extra options are now available in the codestriker.conf file inregards to when emails are sent out. It is now possible to controlwhether emails are sent to the topic author and/or the commentauthor when new comments are created. Also, there is an optionwhich determines if all reviewers are notified if the topic's stateis changed. This is all controlled by the $email_send_optionsconfiguration item. From Jason Remillard.* Added RSS support, so that the topic list screen now has anequivalent RSS view. From Jason Remillard.* Optimised database connection code, from Jason Remillard.* Added a "add other reviewers" link next to the Cc: field in the "addcomment" screen. This allows the comment author to easily Cc allthe other reviewers of the topic, for important comments that needsto be sent to all reviewers.* When creating new topics linked to Bugzilla, also include the topicdescription field in the Bugzilla comment.* Searching on the bugid and cc fields was not working correctly.This has now been fixed.* On UNIX platforms, missing modules can be fetched and installedautomatically using the CPAN module, if required.* Subversion 1.1 has changed it diff format slightly. Parser as beenupdated, as reported by Martin Apel <Martin.Apel@softlab.de>.* Added integration support for Flyspray bug-tracking system. FromMartin Apel.* Fixed text message written to bug-tracking system where the topicauthor was used instead of the actual user, when the topic state waschanged. Found by Jason Remilliard.* Make sure for Win32 deployments, that the PATH environmentvariable is not zapped. This created issues when launching externalprograms, such as an SCM program. Since taint-mode is broken underWin32, this isn't an issue. Found by Michael R. Brumm<michaelbrumm@users.sourceforge.net>.* Fixed message "Character in 'c' format wrapped in pack at... Response.pm", as reported by an anonymous user.* 'Readonly' topic states are now specified in codestriker.conf. Forinstallations that add their own topic states, this allows them tohave more than one state in which topics can be edited.From Dan Prince <dan.prince@alumni.carleton.edu>.* Subversion topic creation fixes from Michael R. Brumm<michaelbrumm@users.sourceforge.net>. If module refers to file,path workaround duplicates the file's name at the end of the filepath in the filename field. Starting and ending slash not removedfrom module name during getDiff.* Modified the Perforce parser to handle file-types that return"xbinary". Also handled Perforce diffs which contain unidiff style'---' and '+++' header lines. From Hope Duryea <hope_duryea@yahoo.com>.* Filenames ending in ++, for example, filename.c++ could not beloaded into the system, due to a bug introduced in 1.8.5.* Added $svn configuration variable to codestriker.conf, so that thepath to the subversion executable can be specified, which is often arequirement for Win32 systems.Version 1.8.5* Complete support for VSS repositories. Topics linked to a VSSrepository can now be created by either specifying labels with theVSS directory of interest for code already committed in therepository, or pre-commit reviews can be done by generating difftext with the ssdiff.pl script in the Codestriker bin directory.* Modified log_accum.pl so that deleted files are also included in thetopic.* On the topic list screen, there is a new button "Obsolete Topics",which allows you to create a new topic which superseeds the selectedtopics. The obsoleted topics will be changed to state "Obsoleted"and will become read-only. Note the @topic_states configurationvariable in codestriker.conf needs to be modified to include the new'Obsoleted' state to enable this. The view topic screens have beenmodified to include links if the topic being viewed has beenobsoleted or superseeds other topics. A single topic can beobsoleted from the view topic properties page, by selecting the'Obsoleted' state.* The $allow_delete config variable has been removed. If topicdeletion is to be enabled, the 'Deleted' state needs to be added tothe @topic_states configuration variable in codestriker.conf.* Added new configuration variable @Codestriker::exclude_file_typeswhich contains a list of filename extensions which Codestriker willignore when creating topics. These generally include thoseextensions which are binary, or of not any interest. Contributed byDave Clendenan <dave.clendenan@polycom.com>.* Added a checkbox "Default to HEAD" on the create topic screen whichis used for topics based off tags. If this checkbox is enabled, the'-f' flag is passed to CVS repositories when executing the 'cvsrdiff' command. This has the effect of retrieving a file's contentsfrom revision HEAD if it is not present for the specified tag value.This option currently has no effect for other repository types atthis stage. Contributed by Dave Clendenan.* Minor fix for handing CVS rdiff text which end in a binary entry.Problem found by Dave Clendenan.* Shorten the URLs sent in the email messages.* Minor fix where " characters would not render correctly in thestatus bar or in a tool-tip when hovering over a commented line inthe view topic window.The following changes are from Jason Remillard:* Fixed a security problem with the repository not being checkedagainst the actual configured list. A user could send in any wellformed repository string and Codestriker would just take it, even ifit was not configured.* Fixed a bug preventing create topic from working when the user hadjust one repository working. The cookie was overriding it because itwas missing from the html code.* Subversion repositories can now be configured with a username andpassword in the configuration file if authentication is required.Any errors from accessing subversion are written to STDERR.Version 1.8.4* The topic properties page now displays the start tag, end tag andmodule parameters if they were used when the topic was created.Contribution by Robert Hudson <codestriker@go2town.co.uk>.* The repository property has been changed to be a read-only propertyin the topic properties page, from Robert Hudson.* The repository selection drop-down is only selected if there is morethan one repository configured in the system, from Robert Hudson.* If a topic is not in open state, then the "topic information" and"topic comments" pages are modified to readonly, and adding newcomments is disabled. From Robert Hudson.* In the table of contents, display the total number of lines addedand removed for each file. This gives the reviewer a quick ideawhere the major changes in the review are. From Robert Hudson.* There is a new configuration option @project_states which controlswhether a project can have its state changed to 'Closed',which prevents new topics being created within it, and the state'Deleted', which will delete the project and all its member topics.Both of these new states are optional, and are not available bydefault. From Robert Hudson.* When sending emails involving more than one CC recipient, the emailsending may fail because a space wasn't put after each comma.* Created the CodestrikerClient module in bin which can create anew topic non-interactively. The intention is for this module to beused from scripts that need to create new topics, for example, froma CVS post-commit script.* Modified custom CVS post-commit scripts so that a Codestriker topicis created for each CVS commit, along with a sent email. Thecommit_prep.pl and log_accum.pl are located in the bin directory,and need to be copied into your CVSROOT area, with a line like thefollowing in your commitinfo file:DEFAULT $CVSROOT/CVSROOT/commit_prep.pl -rand a line like the following in your loginfo file:DEFAULT $CVSROOT/CVSROOT/log_accum.pl %sThe log_accum.pl file needs to have some configuration variables setat the start of the script to reflect your site.Note the first line of the log message will be used as the topictitle. The entire log message is used as the topic description.Any strings of the form "Bug nnn" in the log message will be takenas a reference to a bug id, and will be used in the topic's bugidfield.* Added an optional show_on_mainpage attribute to the comment metricsconfiguration, which specifies which comment metric counts willappear on the topic list page. From Jason Remillard.* Reviewers who haven't viewed a topic will have their namessurrounded by parenthesis in the topic list page. From JasonRemillard.* Fixed a number of taint-mode problems when using Perl 5.8.* Fixed the "Attempt to bless into a reference" error when usingBugzilla integration and Perl 5.8.* Migrated the MySQL datetime type from TIMESTAMP to DATETIME, as itshould have always been. From Jason Remillard.Version 1.8.3* It is now possible to specify multiple metrics associated with acomment "thread". In previous versions of Codestriker, there was aconfiguration variable called @comment_states which had the defaultvalues of "Submitted", "Invalid", or "Completed". These statesstill exist, but under the metric name "Status" by default.Some other example configurations are illustrated in the configfile. For example "Level", "Mode" and "Type" metrics. These valuesare then accumulated in the "Topic Information" tab, along with allthe other topic metrics.Apart from the add/edit comment screen, the topic comments screenallows you to modify any metric associated with any comment thread,via a series of dropdown form elements.* It is now possible in the create topic screen to only specify asingle tag and a module name in order to create a new topic, ratherthan both the start and end tags, with the module name. The effectof a single tag is to create a topic with the full contents of alltagged files in the specified module.* In the "Topic Properties" screen, if the Bug IDs field is beingdisplayed, and $Codestriker::bugtracker is defined, then after thisfield will be a number of hyperlinks to the associated bug trackingrecords.* Added the link "List open topics in project" to all the view topicscreens for user convenience on large multi-project deployments.* Refactored CvsPserver and CvsLocal into a single object, Cvs.* It is now possible to specify CVS repositories using the :ext accessmethod with ssh, providing that the user running the Codestriker webapplication can ssh into the specified host without requiring apassword (ie setting up an authorized_keys file on the destinationhost). The Codestriker configuration file has an example :extrepository, and requires the path to ssh to be specified in the $sshsetting.* Fixed bug where a comment with a " character in it would causeJavascript errors with IE on the view topic page.* In the add comment window, clicking on the "increase context" or"decrease context" would erase any text which had been written.This has now been fixed by Kannan Goundan.* Increasing/decreasing the context from the add comment window wouldnot focus the main browser window to the exact line the comment wasmade from, after the comment has been submitted. This has now beenfixed.* Committed in a whole heap of test scripts from Jason Remillardwhich are located in the test/ subdirectory.* The clearcase diff parser can now handle diffs which describe chunkmovements such as:-----[deleted/moved 40 after 44 (now at 152)]----------[deleted/moved 42-43 after 44 (now at 154-155)]----------[after 135 inserted/moved 152 (was at 40)]----------[after 135 inserted/moved 154-155 (was at 42-43)]-----* Perforce integration has been improved to work with older versionsof p4.* The subversion diff parser can now handle diffs which containproperty set changes.* Make sure topics are linked to the default hidden project when$allow_projects is set to 0. This allows the "topic properties"screen to work correctly.Version 1.8.2* Codestriker now has the ability to view a specific file at a time inthe view topic screen, with previous/next file links. The oldbehaviour of viewing the entire topic text in one page is still thedefault behaviour. The default behaviour can be changed by settingthe $default_file_to_view variable in the configuration file. Notethere are now links on the view topic screen so the user can choosedynamically which viewing mode they would prefer to use.Contribution by Oliver Lohmann <oliver_lohmann@gmx.de>.* Codestriker can now sort by the column headers in the topic listview, from Jason Remillard.* It is now possible to create Subversion topics by entering valuesin the START_TAG, END_TAG and MODULE fields on the create topicpage, from Jason Remillard. See the manual for more details.* In addition to the existing Subversion HTTP server support, it isnow possible to integrate with a native Subversion server as well,from Jason Remillard.* Codestriker can now parse basic diff files (non unidiff and contextdiff), and also ClearCase serial diffs.* A ClearCase repository object has been written by Kannan Goundanwhich works off a snapshot view. With the ClearCase serial diffparser mentioned in the previous item, this provides afully-functional ClearCase code-reviewing solution.* Topic property change emails didn't have the "References" and"In-Reply-To" mail headers set correctly, so that those emailsweren't grouped into the same "topic" email thread.* The view topic display has been improved for diffs which contain newfiles. Now the entire width of the screen is used when displayingnew files. Fix from Jason Remillard and Kannan Goundan.* The email taint/input checking code has been tightened, from JasonRemillard.* Improved the input checking code on the topic properties page.* The CVS pserver repository specification has been expanded so thatit can accept extra optional arguments, such as::pserver;proxy=abc.com;proxyport=8080:user:pwd@cvs.dev.net* Modified Codestriker CSS so that monospace fonts use "monospace"rather than Courier so the user's settings in the browser arehonoured, from Kannan Goundan <kannan@letterboxes.org>.* Standardised all inline help links to (?) rather than(What's this?).* Make sure filenames are properly quoted in the CVS repositorymethods, so that filenames with spaces are handled correctly.Version 1.8.1* Modified the filename field in the topicfile table back to 255characters instead of 1024 so that MySQL doesn't complain.* Added some missing imports which caused compilation errors forPerl 5.8.3 on Solaris when checksetup.pl was run.* Made checksetup.pl more graceful when DBI.pm is not installed, andit is checking what other database modules are required.* Fixed bug found by Philipp Frauenfelder where LXR integration wasnot working when the LXR database was password protected.The following changes were from Jason Remillard:* Fixed bug in the metric support has been fixed, which prevented themetric data from being usable if more than one reviewer was present.* Fixed bug where the wrong Codestriker time number was reported inthe metric summary page.* Emails sent from topic property changes now include more informationsuch as what specific properties were changes. Topic creationemails also include the list of files which have been changed.Version 1.8.0* Initial support for Perforce integration. Can handle topic textfrom a Perforce describe command, such as:"p4 describe -du <changenumber>" or "p4 diff -du".* Codestriker now works under IIS as well as Apache. Use IPC::Open3rather than IPC::Run (which doesn't work under IIS) within theCvsLocal and CvsPserver modules when fetching remote diff data fromCVS. IPC::Run is no longer used.* A new configuration variable $tmpdir is in codestriker.conf forunusual setups which can't use the system default temporarydirectory for the creation of temporary files. Win32 systems arethe usual culprit.* The CVS rdiff parser didn't correctly handle new files within thediff on Win32 platforms.* Add more win32 example configuration to codestriker.conf.* Include the relevant DBD modules in the checksetup.pl dependencylist, depending on what database system has been configured.* Some minor fixes to fully support Win32-based CVS repositories,including use of the older-style :local:c:\\cvsrep syntax. Also bemore robust in handling directory separators as either forward orbackward slashes, since different versions of CVSNT support this.Make sure the CVS executable path is quoted, since it will oftencontain spaces for Win32 environments.* Improved useability of messages (when Perl modules are missing) forWin32 users.* Now support ODBC and Oracle databases. The Databasecreation/upgrade code has been modified so that it is properlymodularised, and so checksetup.pl is far more maintainable. Addingsupport for new Databases will now be a snap. The file table had tobe renamed to topicfile, and comment to commentdata to avoidreserved word clashes in ODBC and Oracle.* Added in a new topic listener which records all changes to acomment's state, property changes to a topic and when a topic hasbeen viewed. Three new database tables have been added to store thisinformation, which can be accessed from the metrics tab of a topic.* Added in the ability for the topic's properties to be changed,including the title, author, bug ids, reviewers, cc, repository,project, description and state. Updated the topic listeners to nowtake the old and new topic objects as arguments.* Introduction of per-user and per-topic metrics functionality fromJason Remillard. In the process, the UI has been changed, plussome general refactoring. It is possible to generate reportsbased on these metrics over a collection of topics and time,to give some indications on the effectiveness of code reviewing.* The $Codestriker::allow_repository configuration variable is removedsince this boolean value can be derived from the length of the@valid_repositories list. From Jason Remillard.* Use tempfile() in Parser.pm to close a potential security hole, fromJason Remillard.* The topic search screen has been reworked to contain "What's this?"links to make the individual search fields clearer. Also, allowedthe use of wildcards with the Author, Reviewer and Cc search fields.Version 1.7.8* If a badly-formatted repository value from codestriker.conf is usedwhen creating a topic, report this in a user-friendly manner.* Report an error if a new topic to be created specifies both theuploaded file and topic tag fields.* Fixed bug where selecting multiple states in the search screenreported an input error.* HTML escaping for the topic title on the topic confirmation screen,project information on the projects screens were not workingcorrectly. Most HTML escaping are now performed within thetemplates directly using the html_entity filter.* In some cases when displaying comment or topic description text,hyperlinks were not automagically being created. If the textcontains a URL such as http://zot.com, it needs to be rendered forconvenience as <A HREF="http://zot.com">http://zot.com</A>. Inaddition, if the text contains a pattern like [Bb]ug \d+ (ie Bug122), this will be hyperlinked to the appropriate URL of thebugtracking system, if one has been specified in the Codestrikerconfiguration.* In the view comments screen with context displayed, very long topiclines would push the "filename:linenumber", "Parallel" and "AddComment" links way off to the far right of the page, requiringhorizontal scrolling to see them. Rework the display so that theyare always pushed to the left, regardless of the length of the topiclines.* Added "Check All"/"Clear All" links in the view comments page forconvenience.* If there is an error in sending an email, make sure a descriptiveerror message is displayed. Thanks to Jason Remillard<jremillardshop@yahoo.com> for spotting this.Version 1.7.7* The table of contents links on the view topic page didn't includethe brmode parameter, so clicking on a filename link reloaded thewhole topic page, which is inconvenient. This reloading behaviourhas also been fixed when coming from the topic list or create topicpage.Version 1.7.6* Fixed bug where created topics for deployments which had projectsdisabled were not handled correctly.* Fixed bug found by Jason Remillard <jremillardshop@yahoo.com> whereemails were being sent for those lines which already had a comment,but $allow_comment_email was false.Version 1.7.5* Added in support for parsing VSS diffs, and retrieving file datafrom a VSS repository. VSS support is not complete yet, as thescript for generated the diff text has not been submitted yet.The following changes below were from Aaron Kardell<akardell@altonaed.com>:* Modified unidiff parser so that diffs created with--show-function-line and --show-c-function can be parsed anddisplayed in the view topic screen.* Incorporated SubmitCodeReview.pl script, which can be used forautomating the submission of a code review topic from the commandline. It also has support for incremental code reviews. See thescript and its help text for more details.* Added an option to the view topic screen which controls how text iswrapped. This can be useful for reviews with long source code lines.The following changes below were from Jason Remillard<jremillardshop@yahoo.com>:* The topic view page has been modified so that a non-diff topic makesbetter use of screen real-estate.* Non-diff topic text uploads now include the filename, rather thanjust "unknown".* Turned off more project-specific display that should be hidden whenprojects are not enabled.* Delete topic button moved to topic state option on view topicscreen.* List comments page modified so that it is now possible to filter byuser and/or comment state. It is also possible to show the contexttext associated with each comment. This page can now be used as aform of a printable report, suitable for code inspection meetings.* Configuration option $allow_comment_email (default true) whichindicates if an email is sent for each comment made. If the Ccfield in the add comment page is filled, an email will be sent tothat address regardless.* The default page shown by Codestriker is the list of open topics,rather than all topics in the system.* Introduced the notion of soft and hard topic text length limits,specified in the configuration file. By default, the limits are notset, and therefore not enforced. The rationale is code inspectionsbecome less effective as the size of the review increases. If areview is longer than the hard limit, the topic will not be created.If the topic text length is greater than the soft limit, a warningmessage is displayed in the view topic page.Version 1.7.4* Major documentation rewrite. All documentation (installation/userguide/hacking) is now present in doc/codestriker.sgml, in DocBookformat.* Now have simple "Help" links on all screens, which link to theappropriate HTML segment of the Codestriker User's guide.* The Bugzilla database name can be explicitly specified in theCodestriker configuration, to cater for non-standard Bugzilladeployments.* Modified handling of Subversion diffs so it can handle diffs of theform cvs diff -r2:3 filename.The following changes below were from Jason Remillard<jremillardshop@yahoo.com>:* The Codestriker title is now a link to the list topic page.* If Bugzilla integration is not enabled (empty $bug_db), hide all ofthe references to the topic bug id (topic list, new topic, viewtopic and search).* Added some additional help in the create topic page to clarify withusage of the start tag, end tag and module fields.* Hide the project combo box if the user does not have projectsenabled.* Fixed some spelling mistakes in the create topic pop-up help.* The rows in the delta table that are associated with a topic werenot deleted when a topic is deleted.Version 1.7.3* Make sure comments are properly HTML-escaped in the list commentsscreen, to avoid display problems when comments contain HTML tags.* Tooltip comments should not be HTML-escaped, for correct rendering.* Make sure after conducting a search, that pressing the "back" buttonwill go back to the form with the search parameters still present.* Modified checksetup.pl so that the module dependencies are checkedbefore compiling Codestriker, so that meaningful error messagesabout missing modules are reported.* Added a filename checkbox to the search form, so reviews can beretrieved which contain a certain filename.* The "Contains text" search field can now handle wildcards, to enablemore sophisticated topic searches.* Addressed some LXR highlighting issues when the identifier namesclash with HTML entity names.Version 1.7.2* Modified so that Codestriker can run on a Windows box with a localCVS repository. See the README file for installation details.The LXR::Run module is now used for increased portability andreliability under mod_perl.* Codestriker has been modified slightly to support mod_perl underApache 2.X. See the README file for more information. To supportApache 2.X, cgi-bin/codestriker.pl is now auto-generated by thechecksetup.pl script and is no longer included in the distribution.* Accepted patch from Wesley Smith <wesleysmith@users.sourceforge.net>which replaces CGI::escapeHTML with HTML::Entities::encode. Someversions of CGI::escapeHTML seem to misbehave.* Accepted patch from Wesley Smith <wesleysmith@users.sourceforge.net>to indicate that the topic filename needs to be re-entered if thereis an input-field validation problem in the create topic screen anda topic text file was specified.* Fixed out-of-date help message for the "Topic text upload" fieldreported by Darryl Okahata <darrylo@soco.agilent.com>.* Implemented suggestion by Darryl Okahata <darrylo@soco.agilent.com>,where repositories can be optionally mapped to different LXRdatabases, rather than just specifying a single LXR database (as wasthe case with previous versions).This is a minor codestriker.conf syntax change that needs to beaddressed for all upgrades. The old $lxr_db, $lxr_user,$lxr_password and $lxr_idlookup_base_url variables have now beenreplaced by a single $lxr_map variable. See the codestriker.conffile for more details.* Fixed minor bug where the filename wasn't being properly retrievedfrom a CVS diff when a binary file was being removed.Version 1.7.1.2* Compressed output (see $use_compression in codestriker.conf) is nowworking correctly.* Set the project id in the cookie for the ListTopics screen, if thesearch is only being conducted over a single project.Version 1.7.1.1* Problem for creating new projects for MySQL fixed.* Minor fix to the untaint code for start tag, end tag and modulename, to make it accept filename characters. That way, the moduleargument can be a filename in a CVS repository, rather than amodule.Version 1.7.1* The notion of "projects" has been integrated. Now every topic inthe system is associated with a single project. There are nowscreens for creating new projects, and modifying theirnames/descriptions. It is now possible to perform topic searchesand to limit it within specific projects. This has been added in tosupport deployments where there is a large number of users workingon different projects. The create topic and view topic screens havebeen modified accordingly.Note there is a new configuration option in codestriker.conf called$allow_projects. If this is set to non-zero, then the projectmanagement screens will be accessible, otherwise they can't beaccessed. This can be convenient for those deployments which haveset their project data, and don't want it modified.* Pserver repository type has been added, so that code reviews againstremote CVS repositories can be linked using :pserver. See thecodestriker.conf file for more information.* When creating a review, instead of uploading a diff file, a starttag, end tag and module name can be given as input. Codestrikerwill fetch the review text and initialise the topic appropriately.This better suited some development processes out there, whereseparate branches were used for development, which needed to bereviewed before collapsing to a trunk. These options are onlydisplayed if repositories are enabled ($allow_repositories == 1) incodestriker.conf.* Support for parsing output from "cvs rdiff -uN -r TAG1 -r TAG2module". This was required to support the "TAG input" method above.* Make sure that topic text that has DOS line endings \r\n arecorrectly parsed.* Fixed a bug where searches over comment data wasn't returningcorrect results.* Minor changes to checksetup - make sure the template directory iscleaned out to ensure the templates are regenerated when performingan upgrade.* Changed codestriker.conf to use single quotes rather than double, sothat there are no Perl escaping issues.Version 1.7.0.2* Remove the topic textarea in the create topic screen. Now the onlyway to generated reviews is to upload a file. The main motiviationis in practice, the textarea was no longer used, and to get somemore real-estate for some newer features on this page in futureversions.Version 1.7.0.1* Fixed silly bug which prevented repository-linked reviews fromworking correctly.Version 1.7.0* Massive refactor so that the diff parsing and rendering code isbroken up into a number of clearly defined modules, which willallow for the easier adoption of different SCM systems in the future.* In addition to CVS and PATCH modules, which existed in previousversion of codestriker but have now been ported into the newmodule structure, Subversion (http://subversion.tigris.org) suppporthas been included.* Modified HTML generation so topic view output is smaller, by usingjavascript functions to reduce the HREF size for each filenumber.Version 1.6.5* Modified diff reader to handle diffs of the form:cvs diff -uN -r TAG1 -r TAG2This allows code reviews to occur for different developmentpractices, for example, if separate branches are used fordevelopment, which are then reviewed, before collapsing intothe mainline branch.* Also modified the pre-requisite Perl module version numbers.Version 1.6.4* Comments associated with a specific line in a review now have thenotion of state, which includes "Submitted" (the initial state),"Invalid" (indicating an invalid comment) and "Completed" (indicatedthat the comments have been addressed). The new screen "listcomments" allows an author of the review to see all the commentsappropriately listed (order by line, then date), and allows for themass changing of states.This is likely to be easier to handle than wading through a mass ofemails. The screen also allows for replies to comments to be easilymade against existing comments.Version 1.6.3* In the topic list screen, it is now possible to selected multipletopics and mass update their state, or delete them.* Improved error message reporting when topics have been deleted andthey are trying to be viewed, or the state of a topic is attemptedto be updated when it has already been changed by another user (iethe topic is "stale").* The repository field in the create topic screen is replaced with adrop-down list of valid repositories. The repositories are set incodestriker.conf for the configuration variable @valid_repositories.Version 1.6.2* Fixed warnings in checksetup.pl for MySQL databases, where "commits"are ignored.* If there are form elements not properly filled in the "create topic"screen, redirect to that page with the error messages displayed,with the previous form elements remembered. The only exception isthe filename in the file upload input box, since browsers usuallydon't accept pre-defined for security reasons.* Fixed minor warnings for topic list screen when the cc field is empty.Version 1.6.1* Modified to use Net::SMTP to allow Codestriker to run under Windows,and to not hardwire the mail sending program to "sendmail".* Allow for the list/search topics and topic deletion to possibly bedisabled. This is required for a codestriker server which ishandling "anonymous" reviews on a public site. This option is setfrom the codestriker.conf file.* Added a "repository" attribute associated with a topic. This is thesource code repository associated with the review, and by default isset to the value of $default_repository in codestriker.conf. Thiscan be an absolute path, which indicates the CVSROOT of a local cvsrepository, or a cvsweb or viewcvs URL, followed by a space,followed by the CVSROOT. Other repository types, such as pserverCVS, BitKeeper, or Subzero can be added in the future.For example, when reviewing a codestriker change, the repositorywould be set as:http://cvs.sourceforge.net/cgi-bin/viewcvs.cgi /cvsrootFor a local repository, it could be just:/usr/local/cvsroot* Allow for the view file screen to be disabled (allows viewing of anentire file before and/or after a proposed change). On somedeployments (eg, the sourceforge servers), the firewall has beensetup so that CGI scripts can't perform any remote HTTP connections.This option is set from the codestriker.conf file.* Added a configuration flag to indicate that email addresses shouldbe displayed in an "anti spam" form. Eg:sits@users.sf.net -> sits@use...This is required for a public deployment of Codestriker.* Created header and trailer templates which appear on every screen,to assist in customising a site's look.* The submit comment and submit topic screens where changed to usetemplates.* Added a lot of on-line help for the create topic screen, to explainwhat all the input form elements mean. Also added help for theupdate topic status button in the view topic screen.* Changed the look-n-feel slightly for the view topic and edit topicscreens.Version 1.6.0* Modified to use the "Template Toolkit" so that the HTML pages can beeasily customised without modifying any perl code. The templateslive in template/en/default, where they can be modified in-place.* Modified the Apache configuration instructions to use <Directory>instead of <Location>. Also modified so that the copying of the CSSfile into the site's main HTML area is no longer necessary, by usingan additional <Directory> directive.Version 1.5.7* Set the attachment field in the HTTP header when downloading thetopic text, to make IE happier, as the filename topicXXXX.txt.* Handle CVS diffs which have whitespace at the start of the review.Version 1.5.6* Codestriker has been integrated with LXR, so that when viewing acode review, those identifiers known to LXR will be automaticallyhyperlinked. This is an enormous aid to the code reviewing process,as you can quickly determine where a variable/function/method/classis defined and where it is used quickly, while studying the proposedchanges.See the README file for setting up LXR integration.The LXR home page is located at http://lxr.sourceforge.net. Theintegration has been tested with version 0.9.2.Note the codestriker.css file has been modified slightly to supportLXR. Make sure you update this file if using LXR.Version 1.5.5 (if upgrading, make sure you run checksetup.pl, see below):* Modified database schema for MySQL so that review text is notlimited to 64KB, but up to 24MB, by changing certain fields fromtype "text" to "mediumtext". PostgreSQL and other databases are notaffected. Simply running checksetup.pl in bin will automatically do themigration for you. I highly recommend backing up your database withthe following command, in case there are problems, which should besomething like:mysqldump -u codestriker -p --opt codestrikerdb > /tmp/cs.backup.sql* Don't let IE cache the topic list and edit topic screens.* Implemented a "delete topic" action.* Put a "List open topics" link at the top of the view topic screen toeasily go to the current list of open topics.* Don't set the Cc and Reviewer field from the cookie if it hasn'tbeen set in the create topic form.* Handle patch files where the time stamps are in a different formatto the typical CVS diff format.* After a comment is added, make sure the focus goes back to thewindow that initiated the add comment action. This wasn't aproblenm for Mozilla, but for other browsers.Version 1.5.4:* When the topic state is updated, add a confirmation message to thetop of the view topic screen.* If the uploaded file doesn't exist, output an appropriate errormessage.* Fixed the table of contents display if a binary file is present.Text files after a binary file weren't hyperlinked. This was adatabase load problem, not a rendering problem.Version 1.5.3:* Further integration with Bugzilla. When a topic is created, or thestate is changed, a suitable comment is added to all bugs associatedwith the topic. This allows important information to be availablewithin the context of displaying a bug. Support for otherbug-tracking systems should be easy to implement.* Make sure topic titles are HTML escaped in the topic list view.Version 1.5.2:* Fixed minor rendering bug in view single file mode.* Added Message-Id, In-Reply-To and References headers, so Codestrikeremails relating to the same topic will be displayed in the samethread, for those email clients which supported threaded views.Version 1.5.1:* Fixed bug where viewing a file in a popup didn't work for those diffswhich contained empty lines.Version 1.5.0:* Just some documentation changes. No code changes from 1.5.0b3.Version 1.5.0b3:* Comments are now entered via a popup window. This means therelatively heavy operation of loading the view topic screen can bedone just once initially, and many comments can be submitted, ratherthan reloading the view screen after each comment submission.Version 1.5.0b2:* Fixed minor rendering bug in the coloured view mode.Version 1.5.0b1:* Broke up the system into a number of Perl modules to make futurework far easier to accomplish.* Now uses a database for storing Codestriker's data. This simplifiesserching and updating of the data, compared to the previousfilesystem persistance.* There is now a topic search screen, which displays its results in asimple topic list screen. From here, individual topics can beselected for display.* Topic now has a simple notion of state. When a topic is created, itis in state "Open". When a review has been done and the code hasbeen committed, the author changes the state to "Committed". If thereview is not to be committed, but needs to be resubmitted, theauthor moves the topic to state "Closed". These states are usefulwhen displaying lists of topics in the system, to see what iscurrently pending.* A migration tool is available to automatically transfer <= 1.4.Xcodestriker data into the database.Version 1.4.5:* Fixed minor rendering bug with line numbers.* Fixed minor bug where adding a CC to a comment with more than oneperson on that line failed.* Support for the handling of binary files in diffs.* Fix bug in popup parallel coloured-diff mode where the anchor namesweren't being generated properly, resulting in some browsers notcentering their view in the correct place.* Fixed bug in pop parallel coloured-diff mode where changes right atthe end of the file weren't rendered.* Support for parsing files generated with cvs diff -b.Version 1.4.4:* Made the CVS file data retrieve command expanded within an eval forflexibility. Included example using the curl command incodestriker.conf.* Can now view coloured diff mode either in monospace font (requiresmore real-estate) or in variable-width font (harder to read code).The choice can be made dynamically. [Note the monospaced diff modecan be set for $default_topic_create_mode in codestriker.conf]* Added a <BASE> tag which reduces the HTML size. Also used cookiesmore intelligently so that the dreaded edit topic and other URLswere cut down to size, which also helped reducing the output.* Took the gzip compression code from CVSweb and plonked it in. Worksnicely with Mozilla/Netscape/Konqueror. If the Compress::Zliblibrary is installed, that is used for compression, otherwise the"gzip" executable is used (although this isn't an option if you arerunning this script within mod_perl). [Note there are two newoptions in codestriker.conf - $use_compression and $gzip]* Codestriker now works under mod_perl successfully. Updatedinstallation instructions for use under mod_perl.Version 1.4.3:* New popup viewing mode "parallel". In addition to being able tobring up a new window containing the contents of a file in itsoriginal or new form, you can also set the popup display to be acoloured diff, containing the contents of the original and the newfile side by side (similar to the main screen in coloured diffmode). While this mode is more bandwidth intensive, this can alsoaid considerably in the reviewing process.* Tab width can now be changed dynamically between 4 and 8 to handlevarying review inputs. Tab expanision is also handled moreconsistently.* Support for "diff -uNp", "diff -uN --show-function-line=regexp","cvs diff -uNp" and "cvs diff -uN --show-function-line=regexp".* URLs entered in the description or in a comment will be rendered asa link to that URL.* Allow the bug field to accept multiple bug IDs.* Introduced codestriker.conf, which isolates a site's configurationinto a single file. This simplifies upgrading.Version 1.4.2:* Can now handle diffs which end in: "\ No newline at end of file".* Changed the HTML generation for popup windows displaying old/newversions of a file to use <PRE> rather than a table, which cuts downthe loading time considerably. Note, the codestriker.css file hadto be changed.Version 1.4.1:* Popup windows were not resizable in IE due to a bug in thejavascript code. Has now been fixed.Version 1.4:* Clicking on an original diff block line heading will open a popupwindow displaying colour-coded contents of the original file.Clicking on a new diff block line heading will open a popup windowdisplaying colour-coded contents of the new file. In each case, itis possible to click on topic lines to enter comments, which aredone in the main browser window.* The file names for each file block is now optionally hyperlinked toa CVS viewing system, such as cvs web.* An optional bug number field is now a part of the topic creationform. This is displayed in the view topic screen, with a link tothe appropriate bug tracking (eg bugzilla) page. Text within thedescription of the form "[Bb][Uu][Gg]\s*\d+" is also rendered to theappropriate bug tracking page.* Comment emails sent now include the filename and line number(where possible) that the comment was made against.* Creation date for a topic is shown in the view topic screen.* Can download topic text as "text/plain" from view topic screen.Version 1.3:* Included table of contents for coloured diff mode, which allows forfast nagivation, and indicates what files are present in the review.* Added better handling of patch files.Version 1.2:* Converted to use CSS to reduce the resulting HTML size and to enableeasier customisation.* Coloured diff mode handles ordinary patches, CVS diffs, and ordinarytext.* Put in more newlines to make the resulting HTML more readable.* Removed a stray <PRE> tag in coloured diff mode.