WebSVN – DevTools – Diff – /buildtool/trunk/src/main/java/com/erggroup/buildtool/ripple/RippleEngine.java

         for (Iterator<BuildExclusion> it = mBuildExclusionCollection.iterator(); it.hasNext(); )
+        {
             BuildExclusion buildExclusion = it.next();
             //  Skip 'Processed' entries
-            //  These will be the result of a PlanError that we have seen again
+            //      These will be the result of a PlanError that we have seen again
             //
-            //  PlanErrors - Add/Remove as detected
+            if ( buildExclusion.isProcessed() ) {
-            //  BuildErrors - Persist.
+                continue;
+            }
+            //  BuildErrors     - Persist ( do nothing) These are handled elsewhere
+            //  PackageErrors   - Add new (ie: was not imported)
-            //  IndirectErrors - Add/Remove as detected
+            //  IndirectErrors  - Add/Remove as detected
             //
-            if ( !buildExclusion.isABuildError() )
+            if (buildExclusion.isABuildError()) {
-            {
+                continue;
-                if ( !buildExclusion.isProcessed() )
-                {
-                    if (buildExclusion.isImported() && !buildExclusion.isARootCause() ) {
+            } else if (buildExclusion.isAPackageError()) {
-                        // Remove from the exclusion list
-                        buildExclusion.includeToBuild(mReleaseManager, mBaseline);
-                        mLogger.error("reportChange remove unused exclusion: {}", buildExclusion );
-                    } else {
-                        // Exclude and notify
+                if (buildExclusion.isImported()) {
-                        buildExclusion.excludeFromBuild(mReleaseManager, mBaseline);
-                        buildExclusion.email(this, mPackageCollectionAll);
-                        counter++;
+                    continue;
-                    }
+                }
+            }
+            if (buildExclusion.isImported()) {
+                // Remove from the exclusion list
+                mLogger.error("reportChange remove unused exclusion: {}", buildExclusion );
+                buildExclusion.includeToBuild(mReleaseManager, mBaseline);
+            } else {
+                // Exclude and notify
+                mLogger.error("reportChange add new exclusion: {}", buildExclusion );
+                buildExclusion.excludeFromBuild(mReleaseManager, mBaseline);
+                buildExclusion.email(this, mPackageCollectionAll);
+                counter++;
+            }
+        }
         mLogger.error("reportChange exclusion count: {}", counter);
+    }
     /**reports the build plan

Subversion Repositories DevTools

(root)/buildtool/trunk/src/main/java/com/erggroup/buildtool/ripple/RippleEngine.java – Rev 7137 → 7141