WebSVN – DevTools – Diff – /buildtool/trunk/src/generated/com/erggroup/buildtool/ripple/ReleaseManager.java

 import java.util.Iterator;
 import java.util.ListIterator;
 import java.util.Vector;
 import java.util.concurrent.locks.ReentrantLock;
-import oracle.jdbc.OracleDriver;
 import org.apache.log4j.Logger;
 /**Release Manager schema abstraction
  */
 public class ReleaseManager
         disconnect();
+      }
+    }
+  }
+  /**attempts to execute the Exclude_Indirect_From_Build stored procedure
+   * NB Execute_Indirect_From_Build will delete matching do_not_ripple rows prior to an insertion
+   * this is crucial!!
+   *
+   * parameters:
+   * packageVersionId IN passed to Exclude_Indirect_From_Build
+   * packageVersion   IN passed to Exclude_Indirect_From_Build
+   * rtagId           IN passed to Exclude_Indirect_From_Build
+   * rootPvId         IN passed to Exclude_Indirect_From_Build
+   * rootCause        IN passed to Exclude_Indirect_From_Build
+   * rootFile         IN passed to Exclude_Indirect_From_Build
-  /**handles database connection/commit/disconnection when newSession is true
+   * newSession       IN handles database connection/commit/disconnection when true
-   * executes the Exclude_Indirect_From_Build stored procedure with the passed parameters
+   * supercede        IN checks for a row with a matching packageVersionId and rtagId when false
+   *                     such a row will prevent the execution of Exclude_Indirect_From_Build
+   *
+   * returns:
+   * none
    */
   public void excludeFromBuild(String packageVersionId,
                                String packageVersion, String rtagId, String rootPvId,
-                               String rootCause, String rootFile, boolean newSession) throws SQLException, Exception
+                               String rootCause, String rootFile, boolean newSession, boolean supercede) throws SQLException, Exception
+  {
     mLogger.debug("excludeFromBuild " + packageVersionId);
     if ( mUseDatabase )
+    {
       try
           connect();
+        }
         boolean exist = false;
-        // do not exclude a package already excluded ie let the first build failure count
-        // there is a window of opportunity here, but it is worth doing
-        // scenario 1
-        // 1 this query indicates no build failure exists on this version
-        // 2 another build machine reports a build failure on this version
-        // 3 this is then overridden by this thread
-        // does not matter
-        // doing this works well for the following
-        // scenario 2
-        // 1 this query (run by a slave) indicates no build failure exists on this version
-        // 2 build failure is reported
-        // 3 master build machine detects slave in state waiting
-        // 4 master daemon discovers slave did not deliver artifacts
-        // 5 master daemon is prevented from overriding the build failure
-        CallableStatement stmt = mConnection.prepareCall("select pv_id from release_manager.do_not_ripple where pv_id=" + packageVersionId + "and rtag_id=" + rtagId);
-        ResultSet rset = stmt.executeQuery();
-        while( rset.next() )
+        if ( !supercede )
+        {
+          // do not exclude a package already excluded ie let the first build failure count
+          // there is a window of opportunity here, but it is worth doing
+          // scenario 1
+          // 1 this query indicates no build failure exists on this version
+          // 2 another build machine reports a build failure on this version
+          // 3 this is then overridden by this thread
+          // does not matter
+          // doing this works well for the following
+          // scenario 2
+          // 1 this query (run by a slave) indicates no build failure exists on this version
+          // 2 build failure is reported
+          // 3 master build machine detects slave in state waiting
+          // 4 master daemon discovers slave did not deliver artifacts
+          // 5 master daemon is prevented from overriding the build failure
+          CallableStatement stmt = mConnection.prepareCall("select pv_id from release_manager.do_not_ripple where pv_id=" + packageVersionId + "and rtag_id=" + rtagId);
+          ResultSet rset = stmt.executeQuery();
+          while( rset.next() )
+          {
-          exist = true;
+            exist = true;
-          break;
+            break;
+          }
+          rset.close();
+          stmt.close();
+        }
-        rset.close();
-        stmt.close();
         if ( !exist )
+        {
-          stmt = mConnection.prepareCall( "begin ? := PK_RMAPI.EXCLUDE_INDIRECT_FROM_BUILD(?,?,?,?,?,?,?); end;" );
+          CallableStatement stmt = mConnection.prepareCall( "begin ? := PK_RMAPI.EXCLUDE_INDIRECT_FROM_BUILD(?,?,?,?,?,?,?); end;" );
           stmt.registerOutParameter( 1, Types.INTEGER);
           stmt.setString( 2, packageVersionId );
           stmt.setString( 3, packageVersion );
           stmt.setString( 4, rtagId );
           stmt.setString( 5, "buildadm" );
+    {
       mLogger.info("connect !mUseDatabase");
+    }
     else
+    {
-      if ( !mRegistered )
-      {
-        try
-        {
-          // the JDBC driver is registered only once per database that needs to be accessed
-          mLogger.debug("connect registering driver");
-          DriverManager.registerDriver( new OracleDriver() );
-          mRegistered = true;
-        }
-        catch(SQLException e)
-        {
-          mLogger.fatal("connect failed to register the oracle jdbc driver with the driver manager");
-          throw new Exception("connect failed to register the oracle jdbc driver with the driver manager");
-        }
-      }
       // DEVI 46868
       // loop indefinitely until a connection attempt succeeds
       // unless the failure is on the first attempt
       boolean problemConnecting;
+        {
           if ( mConnection == null || ( mConnection != null && !mConnection.isValid(10) ) )
+          {
             mLogger.warn("connect calling getConnection");
             mConnection = DriverManager.getConnection(mConnectionString, mUsername, mPassword);
+            // when connection to the database is established, the connection, by default, is in auto-commit mode
+            // to adhere to the design in the use of select for update, it is crucial to turn auto-commit off
+            // this also improves performance
+            mConnection.setAutoCommit(false);
+          }
+        }
         catch(SQLException e)
+        {
           mLogger.warn("connect determined problem connecting");

Subversion Repositories DevTools

(root)/buildtool/trunk/src/generated/com/erggroup/buildtool/ripple/ReleaseManager.java @ 900 – Rev 898 → 900