WebSVN – DevTools – Diff – /ManagerSuite/Release_Manager/trunk/web/_wform_move_wip.asp

 <!--#include file="common/_popup_window_common.asp"-->
 <!--#include file="common/daemon_instructions.asp"-->
 <%
 '------------ ACCESS CONTROL ------------------
 %>
-<!--#include file="_access_control_login.asp"-->
 <!--#include file="_access_control_general.asp"-->
 <!--#include file="_access_control_project.asp"-->
 <%
 '------------ Variable Definition -------------
+Dim sMessage, sMessageType
 Dim parPv_id
 Dim parProj_id
 Dim parNewRtag_id
 Dim parRfile
 Dim bPreventSubmit
 '------------ Constants Declaration -----------
 '------------ Variable Init -------------------
+sMessage = NULL
+sMessageType = 3
 Set pkgInfoHash = CreateObject("Scripting.Dictionary")
 parPv_id = QStrPar("pv_id")
-parProj_id= QStrPar("proj_id")
+parProj_id= QStrParDefault("proj_id",DB_PROJ_ID)
-parNewRtag_id = QStrPar("new_rtag_id")
+parNewRtag_id = QStrParDefault("new_rtag_id", parRtag_id)
 parRfile = Request("rfile")
 If IsNull(parProj_id) Then parProj_id = "0"
 If IsNull(parNewRtag_id) Then parNewRtag_id = "0"
 If IsNull(parRfile) Then parRfile = "dependencies.asp"
 bPreventSubmit = false
 '----------------------------------------------
 %>
 <%
+'------------------------------------------------------------------------------------------------------------------------------------------
+' Add a line of text to the System Message
+'
+Sub sMessageAdd(eLevel, text)
+    If NOT isNull(sMessage) Then
+        sMessage = sMessage & "<br>"
+    End If
+    sMessage = sMessage & text
+    If eLevel < sMessageType  Then
+        sMessageType = eLevel
+    End If
+End Sub
+'------------------------------------------------------------------------------------------------------------------------------------------
 Sub Get_Pkg_Info_From_Rel ( SSrtag_id, SSpv_id )
    Dim rsTemp, Query_String
    Query_String = _
    " SELECT pkg.pkg_name, pv.pkg_version, wip.view_id, vi.view_name"&_
    Query_String = "SELECT * FROM projects ORDER BY  UPPER( proj_name )"
    Set rsTemp = OraDatabase.DbCreateDynaset( Query_String, cint(0))
    s = "<td class='form_field' background='images/bg_form_lightbluedark.gif' >Project</td>"
-   s = s + "<td background='images/bg_form_lightbluedark.gif'><select id='proj_id_list' name='proj_id_list' class='form_item' onChange=""MM_jumpMenu('parent',this,0)"">"
+   s = s + "<td background='images/bg_form_lightbluedark.gif'><select id='proj_id_list' name='proj_id_list' class='form_item' onChange=""MM_jumpMenu('window',this,0)"">"
    While ((NOT rsTemp.BOF) AND (NOT rsTemp.EOF))
       projName = UCase(rsTemp.Fields("proj_name"))
       tempLINK = scriptName & "?proj_id=" & rsTemp.Fields("proj_id") &_
                               "&rtag_id="& parRtag_id &_
                               "&new_rtag_id="& parNewRtag_id &_
                               "&pv_id="& parPv_id &_
                               "&rfile="& parRfile
-      If ((NNproj_id = Cstr(rsTemp.Fields("proj_id"))) OR (NNproj_id = "0")) AND (selectedFound = False) Then
+      If ((CStr(NNproj_id) = Cstr(rsTemp.Fields("proj_id"))) OR (NNproj_id = "0")) AND (selectedFound = False) Then
          s = s + "<option value='"& tempLINK &"' selected>"& projName &"</option>"
          selectedFound = True
          NNproj_id = CStr(rsTemp.Fields("proj_id"))
       Else
          s = s + "<option value='"& tempLINK &"'>"& projName &"</option>"
                   " WHERE rt.proj_id = "& NNproj_id &_
                   "   AND ((rt.official = 'N') OR (rt.official = 'C') OR (rt.official = 'R'))"&_
                   " ORDER BY UPPER(rtag_name)"
    Set rsTemp = OraDatabase.DbCreateDynaset( Query_String, cint(0))
-   s = "<td class='form_field'  background='images/bg_form_lightbluedark.gif' >Release</td>"
-   s = s + "<td background='images/bg_form_lightbluedark.gif' ><select id='rtag_id_list' name='rtag_id_list' class='form_item' onChange=""MM_jumpMenu('parent',this,0)"">"
+   s = "<select id='rtag_id_list' name='rtag_id_list' class='form_item' onChange=""MM_jumpMenu('window',this,0)"">"
    While ((NOT rsTemp.BOF) AND (NOT rsTemp.EOF))
       releaseName = rsTemp.Fields("rtag_name")
       tempLINK = scriptName & "?proj_id="& NNproj_id &_
                               "&rtag_id="& parRtag_id &_
                               "&new_rtag_id="& rsTemp.Fields("rtag_id") &_
                               "&pv_id="& parPv_id &_
                               "&rfile="& parRfile
-      If ((NNrtag_id = CStr(rsTemp.Fields("rtag_id"))) OR (NNrtag_id = "0")) AND (selectedFound = False) Then
+      If ((CStr(NNrtag_id) = CStr(rsTemp.Fields("rtag_id"))) OR (NNrtag_id = "0")) AND (selectedFound = False) Then
             s = s + "<option value='"& tempLINK &"' selected>"& releaseName &"</option>"
          selectedFound = True
          NNrtag_id = Cstr(rsTemp.Fields("rtag_id"))
       Else
          s = s + "<option value='"& tempLINK &"'>"& releaseName &"</option>"
    End If
    ' If no releases were found then replace drop down list with some warning text and disable form submission
    If numReleases = 0 Then
       bPreventSubmit = True
+      s = "<a class=err_alert>No active releases</a>"
-      s = "<td>Release</td><td><a style=color:Red>WARNING: No active releases found. The operation cannot be performed.</a></td>"
+      Call sMessageAdd( 1,  "No active releases found. The operation cannot be performed")
    End If
    rsTemp.Close
    Set rsTemp = nothing
-   s = s + "</td>"
+   s = "<td class='form_field'  background='images/bg_form_lightbluedark.gif' >Release</td>" + "<td background='images/bg_form_lightbluedark.gif' >" + s + "<td>"
    Get_Releases = s
 End Function
 '-------------------------------------------------------------------------------------------------------
 ' Call stored procedures to move the WIP from the source release to the destination release
+' Return false on failure
 '-------------------------------------------------------------------------------------------------------
-Sub MoveWip(source_RtagId, destination_RtagId, pvId, viewId)
+Function MoveWip(source_RtagId, destination_RtagId, pvId, viewId)
-   OraDatabase.Parameters.Add "RTAG_ID", source_RtagId,           ORAPARM_INPUT, ORATYPE_NUMBER
-   OraDatabase.Parameters.Add "PV_ID",   pvId,                    ORAPARM_INPUT, ORATYPE_VARCHAR2
-   OraDatabase.Parameters.Add "USER_ID", objAccessControl.UserId, ORAPARM_INPUT, ORATYPE_NUMBER
-   OraDatabase.Parameters.Add "VIEW_ID", viewId,                  ORAPARM_INPUT, ORATYPE_NUMBER
-   objEH.TryORA ( OraSession )
+    MoveWip = False
+    OraDatabase.Parameters.Add "RTAG_ID", source_RtagId,           ORAPARM_INPUT, ORATYPE_NUMBER
+    OraDatabase.Parameters.Add "PV_ID",   pvId,                    ORAPARM_INPUT, ORATYPE_VARCHAR2
+    OraDatabase.Parameters.Add "USER_ID", objAccessControl.UserId, ORAPARM_INPUT, ORATYPE_NUMBER
+    OraDatabase.Parameters.Add "VIEW_ID", viewId,                  ORAPARM_INPUT, ORATYPE_NUMBER
+    objEH.ErrorRedirect = FALSE
+    objEH.TryORA ( OraSession )
+    On Error Resume Next
-   OraDatabase.ExecuteSQL _
+    OraDatabase.ExecuteSQL _
-   "BEGIN   PK_WORK_IN_PROGRESS.REMOVE_PACKAGE ( :PV_ID, :RTAG_ID, :USER_ID );   END;"
+        "BEGIN   PK_WORK_IN_PROGRESS.REMOVE_PACKAGE ( :PV_ID, :RTAG_ID, :USER_ID );   END;"
+    If Err.Number = 0 Then
+        ' First step is OK
+        OraDatabase.Parameters.Remove "RTAG_ID"
+        OraDatabase.Parameters.Add "RTAG_ID", destination_RtagId, ORAPARM_INPUT, ORATYPE_NUMBER
+        objEH.ErrorRedirect = FALSE
+        objEH.TryORA ( OraSession )
+        On Error Resume Next
+        OraDatabase.ExecuteSQL _
+            "BEGIN   PK_WORK_IN_PROGRESS.ADD_PACKAGE ( :PV_ID, :VIEW_ID, :RTAG_ID, :USER_ID );   END;"
+    End If
+    objEH.CatchORA ( OraSession )
+    If objEH.Finally Then
+        MoveWip = True
+    End IF
+    OraDatabase.Parameters.Remove "RTAG_ID"
+    OraDatabase.Parameters.Remove "PV_ID"
+    OraDatabase.Parameters.Remove "USER_ID"
+    OraDatabase.Parameters.Remove "VIEW_ID"
-   If Err.Number = 0 Then
-      OraDatabase.Parameters.Remove "RTAG_ID"
-      OraDatabase.Parameters.Add "RTAG_ID", destination_RtagId, ORAPARM_INPUT, ORATYPE_NUMBER
-      OraDatabase.ExecuteSQL _
-      "BEGIN   PK_WORK_IN_PROGRESS.ADD_PACKAGE ( :PV_ID, :VIEW_ID, :RTAG_ID, :USER_ID );   END;"
-   End If
-   objEH.CatchORA ( OraSession )
-   OraDatabase.Parameters.Remove "RTAG_ID"
-   OraDatabase.Parameters.Remove "PV_ID"
-   OraDatabase.Parameters.Remove "USER_ID"
-   OraDatabase.Parameters.Remove "VIEW_ID"
-End Sub
+End Function
 %>
 <%
 ' get pkgInfoHash items for the source WIP
 Call Get_Pkg_Info_From_Rel ( parRtag_id, parPv_id )
+' Access control
+If NOT objAccessControl.UserLogedIn Then
+    Call sMessageAdd (1,"User is no longer logged in")
+    bPreventSubmit = True
+ElseIf NOT canActionInProject() Then
+    Call sMessageAdd (1, "You have been denied permission to modify the source release")
+    bPreventSubmit = True
 ' Make sure this WIP can be moved - prevent if it has a pending test build instruction, etc
-If (DaemonInstructionPreventsEditing(Request("rtag_id"), Request("pv_id"))) Then
+ElseIf (DaemonInstructionPreventsEditing(Request("rtag_id"), Request("pv_id"))) Then
+    bPreventSubmit = True
-   Call RaiseMsgInParent(enum_MSG_ERROR, "This WIP has one or more daemon instructions present.<br><br>"&_
+   Call sMessageAdd (1, "This WIP has one or more daemon instructions present.<br>"&_
-                                         "Please delete them or allow them to be consumed before attempting to move the WIP.")
+                        "Please delete them or allow them to complete before moving WIPs.")
-   Call CloseWindow
 Else
    ' check for form submission
    If CBool(QStrPar("action")) AND (QStrPar("btn") = "Move") AND objAccessControl.UserLogedIn Then
       'Process submition
-      Call MoveWip(parRtag_id, parNewRtag_id, parPv_id, pkgInfoHash.Item("view_id"))
+      If MoveWip(parRtag_id, parNewRtag_id, parPv_id, pkgInfoHash.Item("view_id")) Then
-      Call OpenInParentWindow (parRfile &"?pv_id="& parPv_id &"&rtag_id="& parNewRtag_id )
+        Call OpenInParentWindow (parRfile &"?pv_id="& parPv_id &"&rtag_id="& parNewRtag_id )
-      Call CloseWindow
+        Call CloseWindow
+      End If
    Else
       ' Call HTML rendering functions, but throw away the strings returned since we only want to ensure that
       ' the current state of the bPreventSubmit flag has been acquired in order to show/hide the submit button
       Call Get_Projects(parProj_id)
       Call Get_Releases(parProj_id, parNewRtag_id)
    End If
 End If
+' Prevent moving to myself
+If (parNewRtag_id = parRtag_id) Then
+    Call sMessageAdd (3,"Select a release")
+    bPreventSubmit = True
+End If
 %>
 <html>
 <head>
 <title>Release Manager</title>
 <link rel="stylesheet" href="images/navigation.css" type="text/css">
 <script language="JavaScript" src="images/tipster.js"></script>
 <script language="JavaScript" src="images/_help_tips.js"></script>
 <script language="JavaScript" src="images/common.js"></script>
 </head>
 <body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
-<form name="chgroup" method="post" action="<%=scriptName%>">
+<form name="chgroup" method="post" action="<%=scriptName%>" class="form_tight">
-   <table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
+   <table border="0" cellspacing="0" cellpadding="2">
       <tr>
-         <td background="images/lbox_bg_orange.gif" width="1%" height="1%"><img src="images/i_change_group_off.gif" width="22" height="25" hspace="5"></td>
-         <td background="images/lbox_bg_blue.gif" nowrap width="50%" class="wform_ttl">&nbsp;Move WIP To Another Release</td>
-         <td background="images/lbox_bg_blue.gif" align="right" width="50%">
+         <td background="images/lbox_bg_blue.gif" align="right">
-            <%If NOT bPreventSubmit Then%>
-               <input type="submit" name="btn" value="Move" class="form_btn_comp">
+            <input type="submit" name="btn" value="Move" <%=Iif(bPreventSubmit, "disabled", "")%> class="form_btn_comp form_btn">
-            <%End If%>
-            <input type="reset" name="btn" value="Cancel" class="form_btn_comp" onclick="self.close()">
+            <input type="reset" name="btn" value="Cancel" class="form_btn_comp" onclick="parent.closeIFrame();">
-         </td>
-         <td background="images/lbox_bg_blue.gif" align="right" width="1%%" nowrap>
-            <img src="images/h_trsp_dot.gif" width="5" height="22">
          </td>
       </tr>
       <tr>
+        <td>
+       <!-- MESSAGE ++++++++++++++++++++++++++++++++++++++++++++++ -->
+       <%Call Messenger ( sMessage , sMessageType, "100%" )%>
+       <!-- MESSAGE +++++++++++++++++++++++++++++++++++++++++++++++++++ -->
-         <td height="100%" width="1%">&nbsp;</td>
+       <!--#include file="messages/_msg_inline.asp"-->
+       </td>
+      </td>
+      <tr>
-         <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
+         <td valign="top" nowrap class="wform_ttl" background="images/bg_form_lightgray.gif">
             <table width="100%" border="0" cellspacing="1" cellpadding="2">
                <tr>
                   <td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
-                  <td width="1%" nowrap class="form_group" valign="bottom">WIP Details</td>
+                  <td width="1%" nowrap class="form_group" valign="bottom" colspan="2">WIP Details</td>
-                  <td nowrap width="100%">&nbsp; </td>
                </tr>
                <tr>
                   <td width="1%">&nbsp;</td>
-                  <td width="1%" nowrap class="form_field" background="images/bg_form_lightbluedark.gif">Package<a href="#" onMouseOver="formTips.show('group')" onMouseOut="formTips.hide()"></a></td>
+                  <td width="1%" nowrap class="form_field" background="images/bg_form_lightbluedark.gif">Package</td>
                   <td nowrap width="100%" background="images/bg_form_lightbluedark.gif" class="form_txt">
                      <%=pkgInfoHash.Item("pkg_name")%>
                   </td>
                </tr>
                <tr>
                   <td width="1%">&nbsp;</td>
-                  <td width="1%" nowrap class="form_field" background="images/bg_form_lightbluedark.gif">Version<a href="#" onMouseOver="formTips.show('group')" onMouseOut="formTips.hide()"></a></td>
+                  <td width="1%" nowrap class="form_field" background="images/bg_form_lightbluedark.gif">Version</td>
                   <td nowrap width="100%" background="images/bg_form_lightbluedark.gif" class="form_txt">
                      <%=pkgInfoHash.Item("pkg_version")%>
                   </td>
                </tr>
                <tr>
                   </td>
                </tr>
                <tr>
                   <td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
-                  <td width="1%" nowrap class="form_group" valign="bottom">Select Destination Release</td>
+                  <td width="1%" nowrap class="form_group" valign="bottom" colspan="2">Select Destination Release</td>
-                  <td nowrap width="100%">&nbsp; </td>
                </tr>
                <tr>
                   <td width="1%">&nbsp;</td>
                   <%=Get_Projects(parProj_id)%>
                   <td nowrap width="100%">&nbsp; </td>
                </tr>
             </table>
          </td>
       </tr>
       <tr>
-         <td height="100%" width="1%">&nbsp;</td>
-         <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
+         <td valign="top" nowrap class="wform_ttl" background="images/bg_form_lightgray.gif">
             <table width="100%" border="0" cellspacing="1" cellpadding="2">
                <tr>
                   <td width="1%" wrap class="form_group" valign="bottom">
                      WARNING:<br>
                      The destination release may not satisfy any or all the dependencies that come with
                   </td>
                </tr>
             </table>
          </td>
       </tr>
-      <tr>
-         <td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
-         <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif"></td>
-      </tr>
    </table>
 </form>
 <!-- TIPS LAYERS -------------------------------------->
 <div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10">&nbsp;</div>
 <!----------------------------------------------------->

Subversion Repositories DevTools

(root)/ManagerSuite/Release_Manager/trunk/web/_wform_move_wip.asp – Rev 5506 → 5590