| Line 1... |
Line 1... |
| 1 |
<%@LANGUAGE="VBSCRIPT"%>
|
1 |
<%@LANGUAGE="VBSCRIPT"%>
|
| 2 |
<%
|
2 |
<%
|
| 3 |
Option explicit
|
3 |
Option explicit
|
| 4 |
Response.Expires = 0 ' always load the page, dont store
|
4 |
Response.Expires = 0 ' always load the page, dont store
|
| 5 |
%>
|
5 |
%>
|
| 6 |
<%
|
6 |
<%
|
| 7 |
'=====================================================
|
7 |
'=====================================================
|
| 8 |
' Update Code Review
|
8 |
' Update Code Review
|
| 9 |
'=====================================================
|
9 |
'=====================================================
|
| 10 |
%>
|
10 |
%>
|
| 11 |
<!--#include file="common/conf.asp"-->
|
11 |
<!--#include file="common/conf.asp"-->
|
| 12 |
<!--#include file="common/globals.asp"-->
|
12 |
<!--#include file="common/globals.asp"-->
|
| 13 |
<!--#include file="common/formating.asp"-->
|
13 |
<!--#include file="common/formating.asp"-->
|
| 14 |
<!--#include file="common/qstr.asp"-->
|
14 |
<!--#include file="common/qstr.asp"-->
|
| 15 |
<!--#include file="common/common_subs.asp"-->
|
15 |
<!--#include file="common/common_subs.asp"-->
|
| 16 |
<!--#include file="common/common_dbedit.asp"-->
|
16 |
<!--#include file="common/common_dbedit.asp"-->
|
| 17 |
<!--#include file="common/_popup_window_common.asp"-->
|
17 |
<!--#include file="common/_popup_window_common.asp"-->
|
| 18 |
<%
|
18 |
<%
|
| 19 |
' Set rfile parameter. This is a return page after Login
|
19 |
' Set rfile parameter. This is a return page after Login
|
| 20 |
Call objPMod.StoreParameter ( "rfile", "fixed_issues.asp" )
|
20 |
Call objPMod.StoreParameter ( "rfile", "fixed_issues.asp" )
|
| 21 |
'------------ ACCESS CONTROL ------------------
|
21 |
'------------ ACCESS CONTROL ------------------
|
| 22 |
%>
|
22 |
%>
|
| 23 |
<!--#include file="_access_control_login.asp"-->
|
23 |
<!--#include file="_access_control_login.asp"-->
|
| 24 |
<!--#include file="_access_control_general.asp"-->
|
24 |
<!--#include file="_access_control_general.asp"-->
|
| 25 |
<!--#include file="_access_control_project.asp"-->
|
25 |
<!--#include file="_access_control_project.asp"-->
|
| 26 |
<%
|
26 |
<%
|
| 27 |
'------------ Variable Definition -------------
|
27 |
'------------ Variable Definition -------------
|
| 28 |
Dim parPv_id
|
28 |
Dim parPv_id
|
| 29 |
Dim rsQry
|
29 |
Dim rsQry
|
| 30 |
Dim arrItemResults
|
30 |
Dim arrItemResults
|
| 31 |
Dim arrOverallResults
|
31 |
Dim arrOverallResults
|
| 32 |
Dim pkgName
|
32 |
Dim pkgName
|
| 33 |
Dim pkgVersion
|
33 |
Dim pkgVersion
|
| 34 |
'------------ Constants Declaration -----------
|
34 |
'------------ Constants Declaration -----------
|
| 35 |
'------------ Variable Init -------------------
|
35 |
'------------ Variable Init -------------------
|
| 36 |
parPv_id = Request("pv_id")
|
36 |
parPv_id = Request("pv_id")
|
| 37 |
parRtag_id = Request("rtag_id")
|
37 |
parRtag_id = Request("rtag_id")
|
| 38 |
arrItemResults = Array ( "","","", _
|
38 |
arrItemResults = Array ( "","","", _
|
| 39 |
"Pass",enumCODE_REVIEW_PASS,"class='pass_alert'", _
|
39 |
"Pass",enumCODE_REVIEW_PASS,"class='pass_alert'", _
|
| 40 |
"Fail",enumCODE_REVIEW_FAIL,"class='err_alert'" )
|
40 |
"Fail",enumCODE_REVIEW_FAIL,"class='err_alert'" )
|
| 41 |
arrOverallResults = Array ( "","", _
|
41 |
arrOverallResults = Array ( "","", _
|
| 42 |
"Accepted",enumCODE_REVIEW_ACCEPTED, _
|
42 |
"Accepted",enumCODE_REVIEW_ACCEPTED, _
|
| 43 |
"Minor updates required",enumCODE_REVIEW_MINOR_UPDATES, _
|
43 |
"Minor updates required",enumCODE_REVIEW_MINOR_UPDATES, _
|
| 44 |
"Major rework required",enumCODE_REVIEW_MAJOR_REWORK )
|
44 |
"Major rework required",enumCODE_REVIEW_MAJOR_REWORK )
|
| 45 |
'----------------------------------------------
|
45 |
'----------------------------------------------
|
| 46 |
%>
|
46 |
%>
|
| 47 |
<%
|
47 |
<%
|
| 48 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
48 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
| 49 |
Sub GetCodeReview ( nPv_id, oRS )
|
49 |
Sub GetCodeReview ( nPv_id, oRS )
|
| 50 |
Dim Query_String
|
50 |
Dim Query_String
|
| 51 |
Query_String = _
|
51 |
Query_String = _
|
| 52 |
" SELECT * FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
|
52 |
" SELECT * FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
|
| 53 |
Query_String = Replace( Query_String, ":PV_ID", nPv_id )
|
53 |
Query_String = Replace( Query_String, ":PV_ID", nPv_id )
|
| 54 |
|
54 |
|
| 55 |
Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
|
55 |
Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
|
| 56 |
|
56 |
|
| 57 |
' Make sure therer is always a record to read from
|
57 |
' Make sure therer is always a record to read from
|
| 58 |
If oRS.RecordCount < 1 Then
|
58 |
If oRS.RecordCount < 1 Then
|
| 59 |
oRS.Close
|
59 |
oRS.Close
|
| 60 |
Call InserDefaultRow ( parPv_id )
|
60 |
Call InserDefaultRow ( parPv_id )
|
| 61 |
Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
|
61 |
Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
|
| 62 |
End If
|
62 |
End If
|
| 63 |
|
63 |
|
| 64 |
End Sub
|
64 |
End Sub
|
| 65 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
65 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
| 66 |
Function DrawItemResult ( cCheck )
|
66 |
Function DrawItemResult ( cCheck )
|
| 67 |
Dim item, val, maxOptions, selected, tempSTR
|
67 |
Dim item, val, maxOptions, selected, tempSTR
|
| 68 |
maxOptions = UBound( arrItemResults )
|
68 |
maxOptions = UBound( arrItemResults )
|
| 69 |
|
69 |
|
| 70 |
tempSTR = ""
|
70 |
tempSTR = ""
|
| 71 |
For val = 0 to maxOptions Step 3
|
71 |
For val = 0 to maxOptions Step 3
|
| 72 |
selected = ""
|
72 |
selected = ""
|
| 73 |
If CStr( arrItemResults(val + 1) ) = cCheck Then selected = "selected"
|
73 |
If CStr( arrItemResults(val + 1) ) = cCheck Then selected = "selected"
|
| 74 |
tempSTR = tempSTR & "<option value='"& arrItemResults( val + 1 ) &"' "& selected &" "& arrItemResults(val + 2) &">"& arrItemResults( val ) &"</option>"& VBNewLine
|
74 |
tempSTR = tempSTR & "<option value='"& arrItemResults( val + 1 ) &"' "& selected &" "& arrItemResults(val + 2) &">"& arrItemResults( val ) &"</option>"& VBNewLine
|
| 75 |
Next
|
75 |
Next
|
| 76 |
|
76 |
|
| 77 |
DrawItemResult = tempSTR
|
77 |
DrawItemResult = tempSTR
|
| 78 |
End Function
|
78 |
End Function
|
| 79 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
79 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
| 80 |
Function DrawOverallResult ( ByVal nResult )
|
80 |
Function DrawOverallResult ( ByVal nResult )
|
| 81 |
Dim val, maxOptions, tempSTR, selected
|
81 |
Dim val, maxOptions, tempSTR, selected
|
| 82 |
maxOptions = Ubound( arrOverallResults )
|
82 |
maxOptions = Ubound( arrOverallResults )
|
| 83 |
If nResult = "" OR IsNull(nResult) Then nResult = 0
|
83 |
If nResult = "" OR IsNull(nResult) Then nResult = 0
|
| 84 |
|
84 |
|
| 85 |
tempSTR = ""
|
85 |
tempSTR = ""
|
| 86 |
For val = 0 To maxOptions Step 2
|
86 |
For val = 0 To maxOptions Step 2
|
| 87 |
selected = ""
|
87 |
selected = ""
|
| 88 |
If arrOverallResults(val + 1) = CInt( nResult ) Then selected = "selected"
|
88 |
If arrOverallResults(val + 1) = CInt( nResult ) Then selected = "selected"
|
| 89 |
tempSTR = tempSTR & "<option value='"& arrOverallResults( val + 1 ) &"' "& selected &">"& arrOverallResults( val ) &"</option>"& VBNewLine
|
89 |
tempSTR = tempSTR & "<option value='"& arrOverallResults( val + 1 ) &"' "& selected &">"& arrOverallResults( val ) &"</option>"& VBNewLine
|
| 90 |
Next
|
90 |
Next
|
| 91 |
|
91 |
|
| 92 |
DrawOverallResult = tempSTR
|
92 |
DrawOverallResult = tempSTR
|
| 93 |
End Function
|
93 |
End Function
|
| 94 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
94 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
| 95 |
Sub InserDefaultRow ( nPv_id )
|
95 |
Sub InserDefaultRow ( nPv_id )
|
| 96 |
objEH.TryORA ( OraSession )
|
96 |
objEH.TryORA ( OraSession )
|
| 97 |
On Error Resume Next
|
97 |
On Error Resume Next
|
| 98 |
OraDatabase.ExecuteSQL _
|
98 |
OraDatabase.ExecuteSQL _
|
| 99 |
" INSERT INTO CODE_REVIEWS (pv_id) VALUES("& nPv_id &")"
|
99 |
" INSERT INTO CODE_REVIEWS (pv_id) VALUES("& nPv_id &")"
|
| 100 |
objEH.CatchORA ( OraSession )
|
100 |
objEH.CatchORA ( OraSession )
|
| 101 |
End Sub
|
101 |
End Sub
|
| 102 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
102 |
'-----------------------------------------------------------------------------------------------------------------------------------
|
| 103 |
%>
|
103 |
%>
|
| 104 |
<%
|
104 |
<%
|
| 105 |
'------------ Action Requirements -------------------
|
105 |
'------------ Action Requirements -------------------
|
| 106 |
'Process submition
|
106 |
'Process submition
|
| 107 |
If CBool(Request("action")) AND objAccessControl.UserLogedIn Then
|
107 |
If CBool(Request("action")) AND objAccessControl.UserLogedIn Then
|
| 108 |
|
108 |
|
| 109 |
Call UpdateCodeReview ( parPv_id )
|
109 |
Call UpdateCodeReview ( parPv_id )
|
| 110 |
Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
|
110 |
Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
|
| 111 |
'Response.Redirect ( "_wform_code_review.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
|
111 |
'Response.Redirect ( "_wform_code_review.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
|
| 112 |
'Call CloseWindow
|
112 |
'Call CloseWindow
|
| 113 |
|
113 |
|
| 114 |
End If
|
114 |
End If
|
| 115 |
Call Get_Pkg_Short_Info( parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, NULL )
|
115 |
Call Get_Pkg_Short_Info( parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, NULL )
|
| 116 |
Call GetCodeReview ( parPv_id, rsQry )
|
116 |
Call GetCodeReview ( parPv_id, rsQry )
|
| 117 |
%>
|
117 |
%>
|
| 118 |
<html>
|
118 |
<html>
|
| 119 |
<head>
|
119 |
<head>
|
| 120 |
<title>Release Manager</title>
|
120 |
<title>Release Manager</title>
|
| 121 |
<meta HTTP-EQUIV="Pragma" CONTENT="no-cache">
|
121 |
<link rel="shortcut icon" href="<%=FavIcon%>"/>
|
| 122 |
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
|
122 |
<meta HTTP-EQUIV="Pragma" CONTENT="no-cache">
|
| 123 |
<link rel="stylesheet" href="images/release_manager_style.css" type="text/css">
|
123 |
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
|
| 124 |
<link rel="stylesheet" href="images/navigation.css" type="text/css">
|
124 |
<link rel="stylesheet" href="images/release_manager_style.css" type="text/css">
|
| 125 |
<script language="JavaScript" src="images/common.js"></script>
|
125 |
<link rel="stylesheet" href="images/navigation.css" type="text/css">
|
| 126 |
<!-- TIPS -->
|
126 |
<script language="JavaScript" src="images/common.js"></script>
|
| 127 |
<script language="JavaScript" src="images/tipster.js"></script>
|
127 |
<!-- TIPS -->
|
| 128 |
<script language="JavaScript" src="images/_help_tips.js"></script>
|
128 |
<script language="JavaScript" src="images/tipster.js"></script>
|
| 129 |
</head>
|
129 |
<script language="JavaScript" src="images/_help_tips.js"></script>
|
| 130 |
<body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
|
130 |
</head>
|
| 131 |
<!-- TIPS LAYERS -------------------------------------->
|
131 |
<body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
|
| 132 |
<div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10"> </div>
|
132 |
<!-- TIPS LAYERS -------------------------------------->
|
| 133 |
<!----------------------------------------------------->
|
133 |
<div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10"> </div>
|
| 134 |
<form action="_wform_code_review.asp" method="post" name="codereview"
|
134 |
<!----------------------------------------------------->
|
| 135 |
onSubmit=" MM_validateForm(
|
135 |
<form action="_wform_code_review.asp" method="post" name="codereview"
|
| 136 |
'date_of_review','Date of Review','RisDate',
|
136 |
onSubmit=" MM_validateForm(
|
| 137 |
'time_spent','Time Spent','RisNumber',
|
137 |
'date_of_review','Date of Review','RisDate',
|
| 138 |
'review_reason','Reason for Review','RmaxLength:4000',
|
138 |
'time_spent','Time Spent','RisNumber',
|
| 139 |
'files_reviewed','Files Reviewed','RmaxLength:4000',
|
139 |
'review_reason','Reason for Review','RmaxLength:4000',
|
| 140 |
'review_results','Review Results','R',
|
140 |
'files_reviewed','Files Reviewed','RmaxLength:4000',
|
| 141 |
'issues_raised','Issues Raised','RmaxLength:4000'
|
141 |
'review_results','Review Results','R',
|
| 142 |
);
|
142 |
'issues_raised','Issues Raised','RmaxLength:4000'
|
| 143 |
if (review_comments.value!='') {MM_validateForm('review_comments','Comments','RmaxLength:4000');};
|
143 |
);
|
| 144 |
if (rteam_domain_expert.value!='') {MM_validateForm('rteam_domain_expert','Domain Expert','RmaxLength:4000');};
|
144 |
if (review_comments.value!='') {MM_validateForm('review_comments','Comments','RmaxLength:4000');};
|
| 145 |
if (rteam_language_expert.value!='') {MM_validateForm('rteam_language_expert','Language Expert','RmaxLength:4000');};
|
145 |
if (rteam_domain_expert.value!='') {MM_validateForm('rteam_domain_expert','Domain Expert','RmaxLength:4000');};
|
| 146 |
if (rteam_peer_developer.value!='') {MM_validateForm('rteam_peer_developer','Peer Expert','RmaxLength:4000');};
|
146 |
if (rteam_language_expert.value!='') {MM_validateForm('rteam_language_expert','Language Expert','RmaxLength:4000');};
|
| 147 |
if (rteam_author.value!='') {MM_validateForm('rteam_author','Author','RmaxLength:4000');};
|
147 |
if (rteam_peer_developer.value!='') {MM_validateForm('rteam_peer_developer','Peer Expert','RmaxLength:4000');};
|
| 148 |
if (fnc_c_meets_functionality.value!='') {MM_validateForm('fnc_c_meets_functionality','FUNCTIONALITY: Meets required functionality','RmaxLength:4000');};
|
148 |
if (rteam_author.value!='') {MM_validateForm('rteam_author','Author','RmaxLength:4000');};
|
| 149 |
if (rbs_c_bound_cond_handled.value!='') {MM_validateForm('rbs_c_bound_cond_handled','ROBUSTNESS: Boundary conditions handled','RmaxLength:4000');};
|
149 |
if (fnc_c_meets_functionality.value!='') {MM_validateForm('fnc_c_meets_functionality','FUNCTIONALITY: Meets required functionality','RmaxLength:4000');};
|
| 150 |
if (rbs_c_class_interf_precond.value!='') {MM_validateForm('rbs_c_class_interf_precond','ROBUSTNESS: Class interface preconditions tested','RmaxLength:4000');};
|
150 |
if (rbs_c_bound_cond_handled.value!='') {MM_validateForm('rbs_c_bound_cond_handled','ROBUSTNESS: Boundary conditions handled','RmaxLength:4000');};
|
| 151 |
if (rbs_c_no_unitialised_date.value!='') {MM_validateForm('rbs_c_no_unitialised_date','ROBUSTNESS: No unititalised data','RmaxLength:4000');};
|
151 |
if (rbs_c_class_interf_precond.value!='') {MM_validateForm('rbs_c_class_interf_precond','ROBUSTNESS: Class interface preconditions tested','RmaxLength:4000');};
|
| 152 |
if (rbs_c_excep_handing.value!='') {MM_validateForm('rbs_c_excep_handing','ROBUSTNESS: Exception handling','RmaxLength:4000');};
|
152 |
if (rbs_c_no_unitialised_date.value!='') {MM_validateForm('rbs_c_no_unitialised_date','ROBUSTNESS: No unititalised data','RmaxLength:4000');};
|
| 153 |
if (rbs_c_resource_mng.value!='') {MM_validateForm('rbs_c_resource_mng','ROBUSTNESS: Resource mgt (db cxn, memory)','RmaxLength:4000');};
|
153 |
if (rbs_c_excep_handing.value!='') {MM_validateForm('rbs_c_excep_handing','ROBUSTNESS: Exception handling','RmaxLength:4000');};
|
| 154 |
if (rbs_c_trans_complet.value!='') {MM_validateForm('rbs_c_trans_complet','ROBUSTNESS: Transaction completeness','RmaxLength:4000');};
|
154 |
if (rbs_c_resource_mng.value!='') {MM_validateForm('rbs_c_resource_mng','ROBUSTNESS: Resource mgt (db cxn, memory)','RmaxLength:4000');};
|
| 155 |
if (rbs_c_threadsafety.value!='') {MM_validateForm('rbs_c_threadsafety','ROBUSTNESS: Threadsafety','RmaxLength:4000');};
|
155 |
if (rbs_c_trans_complet.value!='') {MM_validateForm('rbs_c_trans_complet','ROBUSTNESS: Transaction completeness','RmaxLength:4000');};
|
| 156 |
if (rbs_c_ret_vals.value!='') {MM_validateForm('rbs_c_ret_vals','ROBUSTNESS: Return values (where appropriate)','RmaxLength:4000');};
|
156 |
if (rbs_c_threadsafety.value!='') {MM_validateForm('rbs_c_threadsafety','ROBUSTNESS: Threadsafety','RmaxLength:4000');};
|
| 157 |
if (rbs_c_corr_err_handling.value!='') {MM_validateForm('rbs_c_corr_err_handling','ROBUSTNESS: Correct err handling at Subsys bdys','RmaxLength:4000');};
|
157 |
if (rbs_c_ret_vals.value!='') {MM_validateForm('rbs_c_ret_vals','ROBUSTNESS: Return values (where appropriate)','RmaxLength:4000');};
|
| 158 |
if (rbs_c_sql_std.value!='') {MM_validateForm('rbs_c_sql_std','ROBUSTNESS: SQL correct and conforming to standards','RmaxLength:4000');};
|
158 |
if (rbs_c_corr_err_handling.value!='') {MM_validateForm('rbs_c_corr_err_handling','ROBUSTNESS: Correct err handling at Subsys bdys','RmaxLength:4000');};
|
| 159 |
if (mnt_c_ext_ref.value!='') {MM_validateForm('mnt_c_ext_ref','MAINTAINABILITY: External references explicit (eg: pkg imports)','RmaxLength:4000');};
|
159 |
if (rbs_c_sql_std.value!='') {MM_validateForm('rbs_c_sql_std','ROBUSTNESS: SQL correct and conforming to standards','RmaxLength:4000');};
|
| 160 |
if (mnt_c_class_size.value!='') {MM_validateForm('mnt_c_class_size','MAINTAINABILITY: Class size ok','RmaxLength:4000');};
|
160 |
if (mnt_c_ext_ref.value!='') {MM_validateForm('mnt_c_ext_ref','MAINTAINABILITY: External references explicit (eg: pkg imports)','RmaxLength:4000');};
|
| 161 |
if (mnt_c_method_size.value!='') {MM_validateForm('mnt_c_method_size','MAINTAINABILITY: Method size ok','RmaxLength:4000');};
|
161 |
if (mnt_c_class_size.value!='') {MM_validateForm('mnt_c_class_size','MAINTAINABILITY: Class size ok','RmaxLength:4000');};
|
| 162 |
if (mnt_c_approp_comm.value!='') {MM_validateForm('mnt_c_approp_comm','MAINTAINABILITY: Appropriate commenting','RmaxLength:4000');};
|
162 |
if (mnt_c_method_size.value!='') {MM_validateForm('mnt_c_method_size','MAINTAINABILITY: Method size ok','RmaxLength:4000');};
|
| 163 |
if (mnt_c_ident_name_std.value!='') {MM_validateForm('mnt_c_ident_name_std','MAINTAINABILITY: Indentifiers conform to naming standards','RmaxLength:4000');};
|
163 |
if (mnt_c_approp_comm.value!='') {MM_validateForm('mnt_c_approp_comm','MAINTAINABILITY: Appropriate commenting','RmaxLength:4000');};
|
| 164 |
if (mnt_c_switch_have_defaults.value!='') {MM_validateForm('mnt_c_switch_have_defaults','MAINTAINABILITY: Switch statements have defaults','RmaxLength:4000');};
|
164 |
if (mnt_c_ident_name_std.value!='') {MM_validateForm('mnt_c_ident_name_std','MAINTAINABILITY: Indentifiers conform to naming standards','RmaxLength:4000');};
|
| 165 |
if (mnt_c_no_lit_num.value!='') {MM_validateForm('mnt_c_no_lit_num','MAINTAINABILITY: No literal numeric constants except 1, 0, 1','RmaxLength:4000');};
|
165 |
if (mnt_c_switch_have_defaults.value!='') {MM_validateForm('mnt_c_switch_have_defaults','MAINTAINABILITY: Switch statements have defaults','RmaxLength:4000');};
|
| 166 |
if (mnt_c_no_dead_code.value!='') {MM_validateForm('mnt_c_no_dead_code','MAINTAINABILITY: No dead or unused code','RmaxLength:4000');};
|
166 |
if (mnt_c_no_lit_num.value!='') {MM_validateForm('mnt_c_no_lit_num','MAINTAINABILITY: No literal numeric constants except 1, 0, 1','RmaxLength:4000');};
|
| 167 |
if (dei_c_std_des_patt.value!='') {MM_validateForm('dei_c_std_des_patt','DESIGN ISSUES: Use of standard design patterns','RmaxLength:4000');};
|
167 |
if (mnt_c_no_dead_code.value!='') {MM_validateForm('mnt_c_no_dead_code','MAINTAINABILITY: No dead or unused code','RmaxLength:4000');};
|
| 168 |
if (dei_c_approp_algor.value!='') {MM_validateForm('dei_c_approp_algor','DESIGN ISSUES: Use of appropriate algorithms (consider performance)','RmaxLength:4000');};
|
168 |
if (dei_c_std_des_patt.value!='') {MM_validateForm('dei_c_std_des_patt','DESIGN ISSUES: Use of standard design patterns','RmaxLength:4000');};
|
| 169 |
if (dei_c_approp_obj.value!='') {MM_validateForm('dei_c_approp_obj','DESIGN ISSUES: Use of appropriate objects (consider bloat, object focus, encapsulation)','RmaxLength:4000');};
|
169 |
if (dei_c_approp_algor.value!='') {MM_validateForm('dei_c_approp_algor','DESIGN ISSUES: Use of appropriate algorithms (consider performance)','RmaxLength:4000');};
|
| 170 |
if (dei_c_approp_err_msg.value!='') {MM_validateForm('dei_c_approp_err_msg','DESIGN ISSUES: Appropriate user error messages','RmaxLength:4000');};
|
170 |
if (dei_c_approp_obj.value!='') {MM_validateForm('dei_c_approp_obj','DESIGN ISSUES: Use of appropriate objects (consider bloat, object focus, encapsulation)','RmaxLength:4000');};
|
| 171 |
if (dei_c_std_framew_comp.value!='') {MM_validateForm('dei_c_std_framew_comp','DESIGN ISSUES: Use of standard framework components','RmaxLength:4000');};
|
171 |
if (dei_c_approp_err_msg.value!='') {MM_validateForm('dei_c_approp_err_msg','DESIGN ISSUES: Appropriate user error messages','RmaxLength:4000');};
|
| 172 |
if (dei_c_approp_logging.value!='') {MM_validateForm('dei_c_approp_logging','DESIGN ISSUES: Appropriate logging','RmaxLength:4000');};
|
172 |
if (dei_c_std_framew_comp.value!='') {MM_validateForm('dei_c_std_framew_comp','DESIGN ISSUES: Use of standard framework components','RmaxLength:4000');};
|
| 173 |
return document.MM_returnValue;">
|
173 |
if (dei_c_approp_logging.value!='') {MM_validateForm('dei_c_approp_logging','DESIGN ISSUES: Appropriate logging','RmaxLength:4000');};
|
| 174 |
<table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
|
174 |
return document.MM_returnValue;">
|
| 175 |
<tr>
|
175 |
<table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
|
| 176 |
<td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
|
176 |
<tr>
|
| 177 |
<td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl"> Code Review for <%=pkgName%> <%=pkgVersion%> </td>
|
177 |
<td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
|
| 178 |
<td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
|
178 |
<td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl"> Code Review for <%=pkgName%> <%=pkgVersion%> </td>
|
| 179 |
<input type="submit" name="btn" value="Save" class="form_btn">
|
179 |
<td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
|
| 180 |
<input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
|
180 |
<input type="submit" name="btn" value="Save" class="form_btn">
|
| 181 |
</td>
|
181 |
<input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
|
| 182 |
<td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td>
|
182 |
</td>
|
| 183 |
</tr>
|
183 |
<td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td>
|
| 184 |
<tr>
|
184 |
</tr>
|
| 185 |
<td height="100%" width="1%"> </td>
|
185 |
<tr>
|
| 186 |
<td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
|
186 |
<td height="100%" width="1%"> </td>
|
| 187 |
<br>
|
187 |
<td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
|
| 188 |
<br>
|
188 |
<br>
|
| 189 |
<table width="100%" border="0" cellspacing="0" cellpadding="0">
|
189 |
<br>
|
| 190 |
<tr>
|
190 |
<table width="100%" border="0" cellspacing="0" cellpadding="0">
|
| 191 |
<td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
|
191 |
<tr>
|
| 192 |
<td width="100%">
|
192 |
<td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
|
| 193 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
193 |
<td width="100%">
|
| 194 |
<tr align="center">
|
194 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
| 195 |
<td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td>
|
195 |
<tr align="center">
|
| 196 |
</tr>
|
196 |
<td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td>
|
| 197 |
<tr>
|
197 |
</tr>
|
| 198 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
|
198 |
<tr>
|
| 199 |
<td nowrap bgcolor="#FFFFFF" class="form_item">
|
199 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
|
| 200 |
<input name="date_of_review" type="text" size="20" maxlength="20" class="form_item" value='<%If IsNull(rsQry("date_of_review")) Then%><%=EuroDate ( Date )%><%Else%><%=EuroDate ( rsQry("date_of_review") )%><%End If%>'> </td>
|
200 |
<td nowrap bgcolor="#FFFFFF" class="form_item">
|
| 201 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field"> Time Spent (hrs)</td>
|
201 |
<input name="date_of_review" type="text" size="20" maxlength="20" class="form_item" value='<%If IsNull(rsQry("date_of_review")) Then%><%=EuroDate ( Date )%><%Else%><%=EuroDate ( rsQry("date_of_review") )%><%End If%>'> </td>
|
| 202 |
<td bgcolor="#FFFFFF" class="form_item">
|
202 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field"> Time Spent (hrs)</td>
|
| 203 |
<input name="time_spent" type="text" size="20" maxlength="20" class="form_item" value="<%=rsQry("time_spent")%>"></td>
|
203 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 204 |
</tr>
|
204 |
<input name="time_spent" type="text" size="20" maxlength="20" class="form_item" value="<%=rsQry("time_spent")%>"></td>
|
| 205 |
<tr>
|
205 |
</tr>
|
| 206 |
<td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
|
206 |
<tr>
|
| 207 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
207 |
<td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
|
| 208 |
<textarea name="review_reason" cols="80" rows="5" class="form_item"><%=rsQry("review_reason")%></textarea></td>
|
208 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
| 209 |
</tr>
|
209 |
<textarea name="review_reason" cols="80" rows="5" class="form_item"><%=rsQry("review_reason")%></textarea></td>
|
| 210 |
<tr>
|
210 |
</tr>
|
| 211 |
<td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
|
211 |
<tr>
|
| 212 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
|
212 |
<td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
|
| 213 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
213 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
|
| 214 |
<textarea name="rteam_domain_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_domain_expert")%></textarea></td>
|
214 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
| 215 |
</tr>
|
215 |
<textarea name="rteam_domain_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_domain_expert")%></textarea></td>
|
| 216 |
<tr>
|
216 |
</tr>
|
| 217 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
|
217 |
<tr>
|
| 218 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
218 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
|
| 219 |
<textarea name="rteam_language_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_language_expert")%></textarea></td>
|
219 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
| 220 |
</tr>
|
220 |
<textarea name="rteam_language_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_language_expert")%></textarea></td>
|
| 221 |
<tr>
|
221 |
</tr>
|
| 222 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
|
222 |
<tr>
|
| 223 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
223 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
|
| 224 |
<textarea name="rteam_peer_developer" cols="60" rows="2" class="form_item"><%=rsQry("rteam_peer_developer")%></textarea></td>
|
224 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
| 225 |
</tr>
|
225 |
<textarea name="rteam_peer_developer" cols="60" rows="2" class="form_item"><%=rsQry("rteam_peer_developer")%></textarea></td>
|
| 226 |
<tr>
|
226 |
</tr>
|
| 227 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
|
227 |
<tr>
|
| 228 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
228 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
|
| 229 |
<textarea name="rteam_author" cols="60" rows="2" class="form_item"><%=rsQry("rteam_author")%></textarea></td>
|
229 |
<td colspan="2" bgcolor="#FFFFFF" class="form_item">
|
| 230 |
</tr>
|
230 |
<textarea name="rteam_author" cols="60" rows="2" class="form_item"><%=rsQry("rteam_author")%></textarea></td>
|
| 231 |
<tr>
|
231 |
</tr>
|
| 232 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
|
232 |
<tr>
|
| 233 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
233 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
|
| 234 |
<textarea name="files_reviewed" cols="80" rows="5" class="form_item"><%=rsQry("files_reviewed")%></textarea></td>
|
234 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
| 235 |
</tr>
|
235 |
<textarea name="files_reviewed" cols="80" rows="5" class="form_item"><%=rsQry("files_reviewed")%></textarea></td>
|
| 236 |
<tr>
|
236 |
</tr>
|
| 237 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
|
237 |
<tr>
|
| 238 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
238 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
|
| 239 |
<select name="review_results" class="form_item" id="review_results">
|
239 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
| 240 |
<%=DrawOverallResult ( rsQry("review_results") )%>
|
240 |
<select name="review_results" class="form_item" id="review_results">
|
| 241 |
</select>
|
241 |
<%=DrawOverallResult ( rsQry("review_results") )%>
|
| 242 |
</td>
|
242 |
</select>
|
| 243 |
</tr>
|
243 |
</td>
|
| 244 |
<tr>
|
244 |
</tr>
|
| 245 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
|
245 |
<tr>
|
| 246 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
246 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
|
| 247 |
<textarea name="issues_raised" cols="80" rows="5" class="form_item"><%=rsQry("issues_raised")%></textarea></td>
|
247 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
| 248 |
</tr>
|
248 |
<textarea name="issues_raised" cols="80" rows="5" class="form_item"><%=rsQry("issues_raised")%></textarea></td>
|
| 249 |
<tr>
|
249 |
</tr>
|
| 250 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
|
250 |
<tr>
|
| 251 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
251 |
<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
|
| 252 |
<textarea name="review_comments" cols="80" rows="5" class="form_item"><%=rsQry("review_comments")%></textarea></td>
|
252 |
<td colspan="3" bgcolor="#FFFFFF" class="form_item">
|
| 253 |
</tr>
|
253 |
<textarea name="review_comments" cols="80" rows="5" class="form_item"><%=rsQry("review_comments")%></textarea></td>
|
| 254 |
</table>
|
254 |
</tr>
|
| 255 |
<br>
|
255 |
</table>
|
| 256 |
<br>
|
256 |
<br>
|
| 257 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
257 |
<br>
|
| 258 |
<tr align="center">
|
258 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
| 259 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td>
|
259 |
<tr align="center">
|
| 260 |
</tr>
|
260 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td>
|
| 261 |
<tr>
|
261 |
</tr>
|
| 262 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
262 |
<tr>
|
| 263 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
263 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
| 264 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
264 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
| 265 |
</tr>
|
265 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
| 266 |
<tr>
|
266 |
</tr>
|
| 267 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>
|
267 |
<tr>
|
| 268 |
<td valign="top" bgcolor="#FFFFFF">
|
268 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>
|
| 269 |
<select name="fnc_s_meets_functionality" class="form_item" id="fnc_s_meets_functionality">
|
269 |
<td valign="top" bgcolor="#FFFFFF">
|
| 270 |
<%=DrawItemResult( rsQry("fnc_s_meets_functionality") )%>
|
270 |
<select name="fnc_s_meets_functionality" class="form_item" id="fnc_s_meets_functionality">
|
| 271 |
</select>
|
271 |
<%=DrawItemResult( rsQry("fnc_s_meets_functionality") )%>
|
| 272 |
</td>
|
272 |
</select>
|
| 273 |
<td bgcolor="#FFFFFF" class="form_item">
|
273 |
</td>
|
| 274 |
<textarea name="fnc_c_meets_functionality" cols="60" rows="3" class="form_item"><%=rsQry("fnc_c_meets_functionality")%></textarea></td>
|
274 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 275 |
</tr>
|
275 |
<textarea name="fnc_c_meets_functionality" cols="60" rows="3" class="form_item"><%=rsQry("fnc_c_meets_functionality")%></textarea></td>
|
| 276 |
</table>
|
276 |
</tr>
|
| 277 |
<br>
|
277 |
</table>
|
| 278 |
<br>
|
278 |
<br>
|
| 279 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
279 |
<br>
|
| 280 |
<tr align="center">
|
280 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
| 281 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td>
|
281 |
<tr align="center">
|
| 282 |
</tr>
|
282 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td>
|
| 283 |
<tr>
|
283 |
</tr>
|
| 284 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
284 |
<tr>
|
| 285 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
285 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
| 286 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
286 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
| 287 |
</tr>
|
287 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
| 288 |
<tr>
|
288 |
</tr>
|
| 289 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>
|
289 |
<tr>
|
| 290 |
<td valign="top" bgcolor="#FFFFFF">
|
290 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>
|
| 291 |
<select name="rbs_s_bound_cond_handled" class="form_item" id="rbs_s_bound_cond_handled">
|
291 |
<td valign="top" bgcolor="#FFFFFF">
|
| 292 |
<%=DrawItemResult( rsQry("rbs_s_bound_cond_handled") )%>
|
292 |
<select name="rbs_s_bound_cond_handled" class="form_item" id="rbs_s_bound_cond_handled">
|
| 293 |
</select>
|
293 |
<%=DrawItemResult( rsQry("rbs_s_bound_cond_handled") )%>
|
| 294 |
</td>
|
294 |
</select>
|
| 295 |
<td bgcolor="#FFFFFF" class="form_item">
|
295 |
</td>
|
| 296 |
<textarea name="rbs_c_bound_cond_handled" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_bound_cond_handled")%></textarea></td>
|
296 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 297 |
</tr>
|
297 |
<textarea name="rbs_c_bound_cond_handled" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_bound_cond_handled")%></textarea></td>
|
| 298 |
<tr>
|
298 |
</tr>
|
| 299 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>
|
299 |
<tr>
|
| 300 |
<td valign="top" bgcolor="#FFFFFF">
|
300 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>
|
| 301 |
<select name="rbs_s_class_interf_precond" class="form_item" id="rbs_s_class_interf_precond">
|
301 |
<td valign="top" bgcolor="#FFFFFF">
|
| 302 |
<%=DrawItemResult( rsQry("rbs_s_class_interf_precond") )%>
|
302 |
<select name="rbs_s_class_interf_precond" class="form_item" id="rbs_s_class_interf_precond">
|
| 303 |
</select>
|
303 |
<%=DrawItemResult( rsQry("rbs_s_class_interf_precond") )%>
|
| 304 |
</td>
|
304 |
</select>
|
| 305 |
<td bgcolor="#FFFFFF" class="form_item">
|
305 |
</td>
|
| 306 |
<textarea name="rbs_c_class_interf_precond" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_class_interf_precond")%></textarea></td>
|
306 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 307 |
</tr>
|
307 |
<textarea name="rbs_c_class_interf_precond" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_class_interf_precond")%></textarea></td>
|
| 308 |
<tr>
|
308 |
</tr>
|
| 309 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
|
309 |
<tr>
|
| 310 |
<td valign="top" bgcolor="#FFFFFF">
|
310 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
|
| 311 |
<select name="rbs_s_no_unitialised_date" class="form_item" id="rbs_s_no_unitialised_date">
|
311 |
<td valign="top" bgcolor="#FFFFFF">
|
| 312 |
<%=DrawItemResult( rsQry("rbs_s_no_unitialised_date") )%>
|
312 |
<select name="rbs_s_no_unitialised_date" class="form_item" id="rbs_s_no_unitialised_date">
|
| 313 |
</select>
|
313 |
<%=DrawItemResult( rsQry("rbs_s_no_unitialised_date") )%>
|
| 314 |
</td>
|
314 |
</select>
|
| 315 |
<td bgcolor="#FFFFFF" class="form_item">
|
315 |
</td>
|
| 316 |
<textarea name="rbs_c_no_unitialised_date" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_no_unitialised_date")%></textarea></td>
|
316 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 317 |
</tr>
|
317 |
<textarea name="rbs_c_no_unitialised_date" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_no_unitialised_date")%></textarea></td>
|
| 318 |
<tr>
|
318 |
</tr>
|
| 319 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
|
319 |
<tr>
|
| 320 |
<td valign="top" bgcolor="#FFFFFF">
|
320 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
|
| 321 |
<select name="rbs_s_excep_handing" class="form_item" id="rbs_s_excep_handing">
|
321 |
<td valign="top" bgcolor="#FFFFFF">
|
| 322 |
<%=DrawItemResult( rsQry("rbs_s_excep_handing") )%>
|
322 |
<select name="rbs_s_excep_handing" class="form_item" id="rbs_s_excep_handing">
|
| 323 |
</select>
|
323 |
<%=DrawItemResult( rsQry("rbs_s_excep_handing") )%>
|
| 324 |
</td>
|
324 |
</select>
|
| 325 |
<td bgcolor="#FFFFFF" class="form_item">
|
325 |
</td>
|
| 326 |
<textarea name="rbs_c_excep_handing" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_excep_handing")%></textarea></td>
|
326 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 327 |
</tr>
|
327 |
<textarea name="rbs_c_excep_handing" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_excep_handing")%></textarea></td>
|
| 328 |
<tr>
|
328 |
</tr>
|
| 329 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
|
329 |
<tr>
|
| 330 |
<td valign="top" bgcolor="#FFFFFF">
|
330 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
|
| 331 |
<select name="rbs_s_resource_mng" class="form_item" id="rbs_s_resource_mng">
|
331 |
<td valign="top" bgcolor="#FFFFFF">
|
| 332 |
<%=DrawItemResult( rsQry("rbs_s_resource_mng") )%>
|
332 |
<select name="rbs_s_resource_mng" class="form_item" id="rbs_s_resource_mng">
|
| 333 |
</select>
|
333 |
<%=DrawItemResult( rsQry("rbs_s_resource_mng") )%>
|
| 334 |
</td>
|
334 |
</select>
|
| 335 |
<td bgcolor="#FFFFFF" class="form_item">
|
335 |
</td>
|
| 336 |
<textarea name="rbs_c_resource_mng" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_resource_mng")%></textarea></td>
|
336 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 337 |
</tr>
|
337 |
<textarea name="rbs_c_resource_mng" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_resource_mng")%></textarea></td>
|
| 338 |
<tr>
|
338 |
</tr>
|
| 339 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
|
339 |
<tr>
|
| 340 |
<td valign="top" bgcolor="#FFFFFF">
|
340 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
|
| 341 |
<select name="rbs_s_trans_complet" class="form_item" id="rbs_s_trans_complet">
|
341 |
<td valign="top" bgcolor="#FFFFFF">
|
| 342 |
<%=DrawItemResult( rsQry("rbs_s_trans_complet") )%>
|
342 |
<select name="rbs_s_trans_complet" class="form_item" id="rbs_s_trans_complet">
|
| 343 |
</select>
|
343 |
<%=DrawItemResult( rsQry("rbs_s_trans_complet") )%>
|
| 344 |
</td>
|
344 |
</select>
|
| 345 |
<td bgcolor="#FFFFFF" class="form_item">
|
345 |
</td>
|
| 346 |
<textarea name="rbs_c_trans_complet" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_trans_complet")%></textarea></td>
|
346 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 347 |
</tr>
|
347 |
<textarea name="rbs_c_trans_complet" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_trans_complet")%></textarea></td>
|
| 348 |
<tr>
|
348 |
</tr>
|
| 349 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
|
349 |
<tr>
|
| 350 |
<td valign="top" bgcolor="#FFFFFF">
|
350 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
|
| 351 |
<select name="rbs_s_threadsafety" class="form_item" id="rbs_s_threadsafety">
|
351 |
<td valign="top" bgcolor="#FFFFFF">
|
| 352 |
<%=DrawItemResult( rsQry("rbs_s_threadsafety") )%>
|
352 |
<select name="rbs_s_threadsafety" class="form_item" id="rbs_s_threadsafety">
|
| 353 |
</select>
|
353 |
<%=DrawItemResult( rsQry("rbs_s_threadsafety") )%>
|
| 354 |
</td>
|
354 |
</select>
|
| 355 |
<td bgcolor="#FFFFFF" class="form_item">
|
355 |
</td>
|
| 356 |
<textarea name="rbs_c_threadsafety" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_threadsafety")%></textarea></td>
|
356 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 357 |
</tr>
|
357 |
<textarea name="rbs_c_threadsafety" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_threadsafety")%></textarea></td>
|
| 358 |
<tr>
|
358 |
</tr>
|
| 359 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
|
359 |
<tr>
|
| 360 |
<td valign="top" bgcolor="#FFFFFF">
|
360 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
|
| 361 |
<select name="rbs_s_ret_vals" class="form_item" id="rbs_s_ret_vals">
|
361 |
<td valign="top" bgcolor="#FFFFFF">
|
| 362 |
<%=DrawItemResult( rsQry("rbs_s_ret_vals") )%>
|
362 |
<select name="rbs_s_ret_vals" class="form_item" id="rbs_s_ret_vals">
|
| 363 |
</select>
|
363 |
<%=DrawItemResult( rsQry("rbs_s_ret_vals") )%>
|
| 364 |
</td>
|
364 |
</select>
|
| 365 |
<td bgcolor="#FFFFFF" class="form_item">
|
365 |
</td>
|
| 366 |
<textarea name="rbs_c_ret_vals" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_ret_vals")%></textarea></td>
|
366 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 367 |
</tr>
|
367 |
<textarea name="rbs_c_ret_vals" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_ret_vals")%></textarea></td>
|
| 368 |
<tr>
|
368 |
</tr>
|
| 369 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
|
369 |
<tr>
|
| 370 |
<td valign="top" bgcolor="#FFFFFF">
|
370 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
|
| 371 |
<select name="rbs_s_corr_err_handling" class="form_item" id="rbs_s_corr_err_handling">
|
371 |
<td valign="top" bgcolor="#FFFFFF">
|
| 372 |
<%=DrawItemResult( rsQry("rbs_s_corr_err_handling") )%>
|
372 |
<select name="rbs_s_corr_err_handling" class="form_item" id="rbs_s_corr_err_handling">
|
| 373 |
</select>
|
373 |
<%=DrawItemResult( rsQry("rbs_s_corr_err_handling") )%>
|
| 374 |
</td>
|
374 |
</select>
|
| 375 |
<td bgcolor="#FFFFFF" class="form_item">
|
375 |
</td>
|
| 376 |
<textarea name="rbs_c_corr_err_handling" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_corr_err_handling")%></textarea></td>
|
376 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 377 |
</tr>
|
377 |
<textarea name="rbs_c_corr_err_handling" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_corr_err_handling")%></textarea></td>
|
| 378 |
<tr>
|
378 |
</tr>
|
| 379 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
|
379 |
<tr>
|
| 380 |
<td valign="top" bgcolor="#FFFFFF">
|
380 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
|
| 381 |
<select name="rbs_s_sql_std" class="form_item" id="rbs_s_sql_std">
|
381 |
<td valign="top" bgcolor="#FFFFFF">
|
| 382 |
<%=DrawItemResult( rsQry("rbs_s_sql_std") )%>
|
382 |
<select name="rbs_s_sql_std" class="form_item" id="rbs_s_sql_std">
|
| 383 |
</select>
|
383 |
<%=DrawItemResult( rsQry("rbs_s_sql_std") )%>
|
| 384 |
</td>
|
384 |
</select>
|
| 385 |
<td bgcolor="#FFFFFF" class="form_item">
|
385 |
</td>
|
| 386 |
<textarea name="rbs_c_sql_std" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_sql_std")%></textarea></td>
|
386 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 387 |
</tr>
|
387 |
<textarea name="rbs_c_sql_std" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_sql_std")%></textarea></td>
|
| 388 |
</table>
|
388 |
</tr>
|
| 389 |
<br>
|
389 |
</table>
|
| 390 |
<br>
|
390 |
<br>
|
| 391 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
391 |
<br>
|
| 392 |
<tr align="center">
|
392 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
| 393 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td>
|
393 |
<tr align="center">
|
| 394 |
</tr>
|
394 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td>
|
| 395 |
<tr>
|
395 |
</tr>
|
| 396 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
396 |
<tr>
|
| 397 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
397 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
| 398 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
398 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
| 399 |
</tr>
|
399 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
| 400 |
<tr>
|
400 |
</tr>
|
| 401 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>
|
401 |
<tr>
|
| 402 |
<td valign="top" bgcolor="#FFFFFF">
|
402 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>
|
| 403 |
<select name="mnt_s_ext_ref" class="form_item" id="mnt_s_ext_ref">
|
403 |
<td valign="top" bgcolor="#FFFFFF">
|
| 404 |
<%=DrawItemResult( rsQry("mnt_s_ext_ref") )%>
|
404 |
<select name="mnt_s_ext_ref" class="form_item" id="mnt_s_ext_ref">
|
| 405 |
</select>
|
405 |
<%=DrawItemResult( rsQry("mnt_s_ext_ref") )%>
|
| 406 |
</td>
|
406 |
</select>
|
| 407 |
<td bgcolor="#FFFFFF" class="form_item">
|
407 |
</td>
|
| 408 |
<textarea name="mnt_c_ext_ref" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ext_ref")%></textarea></td>
|
408 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 409 |
</tr>
|
409 |
<textarea name="mnt_c_ext_ref" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ext_ref")%></textarea></td>
|
| 410 |
<tr>
|
410 |
</tr>
|
| 411 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>
|
411 |
<tr>
|
| 412 |
<td valign="top" bgcolor="#FFFFFF">
|
412 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>
|
| 413 |
<select name="mnt_s_class_size" class="form_item" id="mnt_s_class_size">
|
413 |
<td valign="top" bgcolor="#FFFFFF">
|
| 414 |
<%=DrawItemResult( rsQry("mnt_s_class_size") )%>
|
414 |
<select name="mnt_s_class_size" class="form_item" id="mnt_s_class_size">
|
| 415 |
</select>
|
415 |
<%=DrawItemResult( rsQry("mnt_s_class_size") )%>
|
| 416 |
</td>
|
416 |
</select>
|
| 417 |
<td bgcolor="#FFFFFF" class="form_item">
|
417 |
</td>
|
| 418 |
<textarea name="mnt_c_class_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_class_size")%></textarea></td>
|
418 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 419 |
</tr>
|
419 |
<textarea name="mnt_c_class_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_class_size")%></textarea></td>
|
| 420 |
<tr>
|
420 |
</tr>
|
| 421 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>
|
421 |
<tr>
|
| 422 |
<td valign="top" bgcolor="#FFFFFF">
|
422 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>
|
| 423 |
<select name="mnt_s_method_size" class="form_item" id="mnt_s_method_size">
|
423 |
<td valign="top" bgcolor="#FFFFFF">
|
| 424 |
<%=DrawItemResult( rsQry("mnt_s_method_size") )%>
|
424 |
<select name="mnt_s_method_size" class="form_item" id="mnt_s_method_size">
|
| 425 |
</select>
|
425 |
<%=DrawItemResult( rsQry("mnt_s_method_size") )%>
|
| 426 |
</td>
|
426 |
</select>
|
| 427 |
<td bgcolor="#FFFFFF" class="form_item">
|
427 |
</td>
|
| 428 |
<textarea name="mnt_c_method_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_method_size")%></textarea></td>
|
428 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 429 |
</tr>
|
429 |
<textarea name="mnt_c_method_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_method_size")%></textarea></td>
|
| 430 |
<tr>
|
430 |
</tr>
|
| 431 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>
|
431 |
<tr>
|
| 432 |
<td valign="top" bgcolor="#FFFFFF">
|
432 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>
|
| 433 |
<select name="mnt_s_approp_comm" class="form_item" id="mnt_s_approp_comm">
|
433 |
<td valign="top" bgcolor="#FFFFFF">
|
| 434 |
<%=DrawItemResult( rsQry("mnt_s_approp_comm") )%>
|
434 |
<select name="mnt_s_approp_comm" class="form_item" id="mnt_s_approp_comm">
|
| 435 |
</select>
|
435 |
<%=DrawItemResult( rsQry("mnt_s_approp_comm") )%>
|
| 436 |
</td>
|
436 |
</select>
|
| 437 |
<td bgcolor="#FFFFFF" class="form_item">
|
437 |
</td>
|
| 438 |
<textarea name="mnt_c_approp_comm" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_approp_comm")%></textarea></td>
|
438 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 439 |
</tr>
|
439 |
<textarea name="mnt_c_approp_comm" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_approp_comm")%></textarea></td>
|
| 440 |
<tr>
|
440 |
</tr>
|
| 441 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>
|
441 |
<tr>
|
| 442 |
<td valign="top" bgcolor="#FFFFFF">
|
442 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>
|
| 443 |
<select name="mnt_s_ident_name_std" class="form_item" id="mnt_s_ident_name_std">
|
443 |
<td valign="top" bgcolor="#FFFFFF">
|
| 444 |
<%=DrawItemResult( rsQry("mnt_s_ident_name_std") )%>
|
444 |
<select name="mnt_s_ident_name_std" class="form_item" id="mnt_s_ident_name_std">
|
| 445 |
</select>
|
445 |
<%=DrawItemResult( rsQry("mnt_s_ident_name_std") )%>
|
| 446 |
</td>
|
446 |
</select>
|
| 447 |
<td bgcolor="#FFFFFF" class="form_item">
|
447 |
</td>
|
| 448 |
<textarea name="mnt_c_ident_name_std" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ident_name_std")%></textarea></td>
|
448 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 449 |
</tr>
|
449 |
<textarea name="mnt_c_ident_name_std" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ident_name_std")%></textarea></td>
|
| 450 |
<tr>
|
450 |
</tr>
|
| 451 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>
|
451 |
<tr>
|
| 452 |
<td valign="top" bgcolor="#FFFFFF">
|
452 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>
|
| 453 |
<select name="mnt_s_switch_have_defaults" class="form_item" id="mnt_s_switch_have_defaults">
|
453 |
<td valign="top" bgcolor="#FFFFFF">
|
| 454 |
<%=DrawItemResult( rsQry("mnt_s_switch_have_defaults") )%>
|
454 |
<select name="mnt_s_switch_have_defaults" class="form_item" id="mnt_s_switch_have_defaults">
|
| 455 |
</select>
|
455 |
<%=DrawItemResult( rsQry("mnt_s_switch_have_defaults") )%>
|
| 456 |
</td>
|
456 |
</select>
|
| 457 |
<td bgcolor="#FFFFFF" class="form_item">
|
457 |
</td>
|
| 458 |
<textarea name="mnt_c_switch_have_defaults" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_switch_have_defaults")%></textarea></td>
|
458 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 459 |
</tr>
|
459 |
<textarea name="mnt_c_switch_have_defaults" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_switch_have_defaults")%></textarea></td>
|
| 460 |
<tr>
|
460 |
</tr>
|
| 461 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except 1, 0, 1</td>
|
461 |
<tr>
|
| 462 |
<td valign="top" bgcolor="#FFFFFF">
|
462 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except 1, 0, 1</td>
|
| 463 |
<select name="mnt_s_no_lit_num" class="form_item" id="mnt_s_no_lit_num">
|
463 |
<td valign="top" bgcolor="#FFFFFF">
|
| 464 |
<%=DrawItemResult( rsQry("mnt_s_no_lit_num") )%>
|
464 |
<select name="mnt_s_no_lit_num" class="form_item" id="mnt_s_no_lit_num">
|
| 465 |
</select>
|
465 |
<%=DrawItemResult( rsQry("mnt_s_no_lit_num") )%>
|
| 466 |
</td>
|
466 |
</select>
|
| 467 |
<td bgcolor="#FFFFFF" class="form_item">
|
467 |
</td>
|
| 468 |
<textarea name="mnt_c_no_lit_num" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_lit_num")%></textarea></td>
|
468 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 469 |
</tr>
|
469 |
<textarea name="mnt_c_no_lit_num" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_lit_num")%></textarea></td>
|
| 470 |
<tr>
|
470 |
</tr>
|
| 471 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>
|
471 |
<tr>
|
| 472 |
<td valign="top" bgcolor="#FFFFFF">
|
472 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>
|
| 473 |
<select name="mnt_s_no_dead_code" class="form_item" id="mnt_s_no_dead_code">
|
473 |
<td valign="top" bgcolor="#FFFFFF">
|
| 474 |
<%=DrawItemResult( rsQry("mnt_s_no_dead_code") )%>
|
474 |
<select name="mnt_s_no_dead_code" class="form_item" id="mnt_s_no_dead_code">
|
| 475 |
</select>
|
475 |
<%=DrawItemResult( rsQry("mnt_s_no_dead_code") )%>
|
| 476 |
</td>
|
476 |
</select>
|
| 477 |
<td bgcolor="#FFFFFF" class="form_item">
|
477 |
</td>
|
| 478 |
<textarea name="mnt_c_no_dead_code" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_dead_code")%></textarea></td>
|
478 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 479 |
</tr>
|
479 |
<textarea name="mnt_c_no_dead_code" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_dead_code")%></textarea></td>
|
| 480 |
</table>
|
480 |
</tr>
|
| 481 |
<br>
|
481 |
</table>
|
| 482 |
<br>
|
482 |
<br>
|
| 483 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
483 |
<br>
|
| 484 |
<tr align="center">
|
484 |
<table width="100%" border="0" cellspacing="1" cellpadding="4">
|
| 485 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td>
|
485 |
<tr align="center">
|
| 486 |
</tr>
|
486 |
<td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td>
|
| 487 |
<tr>
|
487 |
</tr>
|
| 488 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
488 |
<tr>
|
| 489 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
489 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
|
| 490 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
490 |
<td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
|
| 491 |
</tr>
|
491 |
<td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
|
| 492 |
<tr>
|
492 |
</tr>
|
| 493 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>
|
493 |
<tr>
|
| 494 |
<td valign="top" bgcolor="#FFFFFF">
|
494 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>
|
| 495 |
<select name="dei_s_std_des_patt" class="form_item" id="dei_s_std_des_patt">
|
495 |
<td valign="top" bgcolor="#FFFFFF">
|
| 496 |
<%=DrawItemResult( rsQry("dei_s_std_des_patt") )%>
|
496 |
<select name="dei_s_std_des_patt" class="form_item" id="dei_s_std_des_patt">
|
| 497 |
</select>
|
497 |
<%=DrawItemResult( rsQry("dei_s_std_des_patt") )%>
|
| 498 |
</td>
|
498 |
</select>
|
| 499 |
<td bgcolor="#FFFFFF" class="form_item">
|
499 |
</td>
|
| 500 |
<textarea name="dei_c_std_des_patt" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_des_patt")%></textarea></td>
|
500 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 501 |
</tr>
|
501 |
<textarea name="dei_c_std_des_patt" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_des_patt")%></textarea></td>
|
| 502 |
<tr>
|
502 |
</tr>
|
| 503 |
<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>
|
503 |
<tr>
|
| 504 |
<td valign="top" bgcolor="#FFFFFF">
|
504 |
<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>
|
| 505 |
<select name="dei_s_approp_algor" class="form_item" id="dei_s_approp_algor">
|
505 |
<td valign="top" bgcolor="#FFFFFF">
|
| 506 |
<%=DrawItemResult( rsQry("dei_s_approp_algor") )%>
|
506 |
<select name="dei_s_approp_algor" class="form_item" id="dei_s_approp_algor">
|
| 507 |
</select>
|
507 |
<%=DrawItemResult( rsQry("dei_s_approp_algor") )%>
|
| 508 |
</td>
|
508 |
</select>
|
| 509 |
<td bgcolor="#FFFFFF" class="form_item">
|
509 |
</td>
|
| 510 |
<textarea name="dei_c_approp_algor" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_algor")%></textarea></td>
|
510 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 511 |
</tr>
|
511 |
<textarea name="dei_c_approp_algor" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_algor")%></textarea></td>
|
| 512 |
<tr>
|
512 |
</tr>
|
| 513 |
<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>
|
513 |
<tr>
|
| 514 |
<td valign="top" bgcolor="#FFFFFF">
|
514 |
<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>
|
| 515 |
<select name="dei_s_approp_obj" class="form_item" id="dei_s_approp_obj">
|
515 |
<td valign="top" bgcolor="#FFFFFF">
|
| 516 |
<%=DrawItemResult( rsQry("dei_s_approp_obj") )%>
|
516 |
<select name="dei_s_approp_obj" class="form_item" id="dei_s_approp_obj">
|
| 517 |
</select>
|
517 |
<%=DrawItemResult( rsQry("dei_s_approp_obj") )%>
|
| 518 |
</td>
|
518 |
</select>
|
| 519 |
<td bgcolor="#FFFFFF" class="form_item">
|
519 |
</td>
|
| 520 |
<textarea name="dei_c_approp_obj" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_obj")%></textarea></td>
|
520 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 521 |
</tr>
|
521 |
<textarea name="dei_c_approp_obj" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_obj")%></textarea></td>
|
| 522 |
<tr>
|
522 |
</tr>
|
| 523 |
<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>
|
523 |
<tr>
|
| 524 |
<td valign="top" bgcolor="#FFFFFF">
|
524 |
<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>
|
| 525 |
<select name="dei_s_approp_err_msg" class="form_item" id="dei_s_approp_err_msg">
|
525 |
<td valign="top" bgcolor="#FFFFFF">
|
| 526 |
<%=DrawItemResult( rsQry("dei_s_approp_err_msg") )%>
|
526 |
<select name="dei_s_approp_err_msg" class="form_item" id="dei_s_approp_err_msg">
|
| 527 |
</select>
|
527 |
<%=DrawItemResult( rsQry("dei_s_approp_err_msg") )%>
|
| 528 |
</td>
|
528 |
</select>
|
| 529 |
<td bgcolor="#FFFFFF" class="form_item">
|
529 |
</td>
|
| 530 |
<textarea name="dei_c_approp_err_msg" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_err_msg")%></textarea></td>
|
530 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 531 |
</tr>
|
531 |
<textarea name="dei_c_approp_err_msg" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_err_msg")%></textarea></td>
|
| 532 |
<tr>
|
532 |
</tr>
|
| 533 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>
|
533 |
<tr>
|
| 534 |
<td valign="top" bgcolor="#FFFFFF">
|
534 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>
|
| 535 |
<select name="dei_s_std_framew_comp" class="form_item" id="dei_s_std_framew_comp">
|
535 |
<td valign="top" bgcolor="#FFFFFF">
|
| 536 |
<%=DrawItemResult( rsQry("dei_s_std_framew_comp") )%>
|
536 |
<select name="dei_s_std_framew_comp" class="form_item" id="dei_s_std_framew_comp">
|
| 537 |
</select>
|
537 |
<%=DrawItemResult( rsQry("dei_s_std_framew_comp") )%>
|
| 538 |
</td>
|
538 |
</select>
|
| 539 |
<td bgcolor="#FFFFFF" class="form_item">
|
539 |
</td>
|
| 540 |
<textarea name="dei_c_std_framew_comp" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_framew_comp")%></textarea></td>
|
540 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 541 |
</tr>
|
541 |
<textarea name="dei_c_std_framew_comp" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_framew_comp")%></textarea></td>
|
| 542 |
<tr>
|
542 |
</tr>
|
| 543 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>
|
543 |
<tr>
|
| 544 |
<td valign="top" bgcolor="#FFFFFF">
|
544 |
<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>
|
| 545 |
<select name="dei_s_approp_logging" class="form_item" id="dei_s_approp_logging">
|
545 |
<td valign="top" bgcolor="#FFFFFF">
|
| 546 |
<%=DrawItemResult( rsQry("dei_s_approp_logging") )%>
|
546 |
<select name="dei_s_approp_logging" class="form_item" id="dei_s_approp_logging">
|
| 547 |
</select>
|
547 |
<%=DrawItemResult( rsQry("dei_s_approp_logging") )%>
|
| 548 |
</td>
|
548 |
</select>
|
| 549 |
<td bgcolor="#FFFFFF" class="form_item">
|
549 |
</td>
|
| 550 |
<textarea name="dei_c_approp_logging" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_logging")%></textarea></td>
|
550 |
<td bgcolor="#FFFFFF" class="form_item">
|
| 551 |
</tr>
|
551 |
<textarea name="dei_c_approp_logging" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_logging")%></textarea></td>
|
| 552 |
</table>
|
552 |
</tr>
|
| 553 |
<br>
|
553 |
</table>
|
| 554 |
<br>
|
554 |
<br>
|
| 555 |
</td>
|
555 |
<br>
|
| 556 |
</tr>
|
556 |
</td>
|
| 557 |
</table>
|
557 |
</tr>
|
| 558 |
</td>
|
558 |
</table>
|
| 559 |
</tr>
|
559 |
</td>
|
| 560 |
<tr>
|
560 |
</tr>
|
| 561 |
<td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
|
561 |
<tr>
|
| 562 |
<td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right">
|
562 |
<td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
|
| 563 |
<input type="submit" name="btn" value="Save" class="form_btn">
|
563 |
<td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right">
|
| 564 |
<input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
|
564 |
<input type="submit" name="btn" value="Save" class="form_btn">
|
| 565 |
</td>
|
565 |
<input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
|
| 566 |
</tr>
|
566 |
</td>
|
| 567 |
</table>
|
567 |
</tr>
|
| 568 |
<input type="hidden" name="action" value="true">
|
568 |
</table>
|
| 569 |
<input type="hidden" name="pv_id" value="<%=parPv_id%>">
|
569 |
<input type="hidden" name="action" value="true">
|
| 570 |
<input type="hidden" name="rtag_id" value="<%=parRtag_id%>">
|
570 |
<input type="hidden" name="pv_id" value="<%=parPv_id%>">
|
| 571 |
</form>
|
571 |
<input type="hidden" name="rtag_id" value="<%=parRtag_id%>">
|
| 572 |
</body>
|
572 |
</form>
|
| 573 |
</html>
|
573 |
</body>
|
| 574 |
<%rsQry.Close
|
574 |
</html>
|
| 575 |
Set rsQry = Nothing%>
|
575 |
<%rsQry.Close
|
| 576 |
|
576 |
Set rsQry = Nothing%>
|
| 577 |
|
577 |
|
| 578 |
<!-- DESTRUCTOR ------->
|
578 |
|
| 579 |
<!--#include file="common/destructor.asp"-->
|
579 |
<!-- DESTRUCTOR ------->
|
| - |
|
580 |
<!--#include file="common/destructor.asp"-->
|