WebSVN – DevTools – Diff – /ManagerSuite/Release_Manager/trunk/_wform_update_code_review.asp

 %>
 <%
 '------------ Action Requirements -------------------
 'Process submition
 If CBool(Request("action")) AND objAccessControl.UserLogedIn Then
    Call UpdateCodeReview ( parPv_id )
    Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
    'Response.Redirect ( "_wform_code_review.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
    'Call CloseWindow
 End If
 Call Get_Pkg_Short_Info(  parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, NULL )
 Call GetCodeReview ( parPv_id, rsQry )
 %>
 <html>
 <body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
 <!-- TIPS LAYERS -------------------------------------->
 <div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10">&nbsp;</div>
 <!----------------------------------------------------->
 <form action="_wform_code_review.asp" method="post" name="codereview"
-   onSubmit="MM_validateForm(
+   onSubmit=" MM_validateForm(
    'date_of_review','Date of Review','RisDate',
    'time_spent','Time Spent','RisNumber',
    'review_reason','Reason for Review','RmaxLength:4000',
    'files_reviewed','Files Reviewed','RmaxLength:4000',
-   'review_results','Review Results','R'
+   'review_results','Review Results','R',
+   'issues_raised','Issues Raised','RmaxLength:4000'
+   );
+   if (review_comments.value!='') {MM_validateForm('review_comments','Comments','RmaxLength:4000');};
+   if (rteam_domain_expert.value!='') {MM_validateForm('rteam_domain_expert','Domain Expert','RmaxLength:4000');};
+   if (rteam_language_expert.value!='') {MM_validateForm('rteam_language_expert','Language Expert','RmaxLength:4000');};
+   if (rteam_peer_developer.value!='') {MM_validateForm('rteam_peer_developer','Peer Expert','RmaxLength:4000');};
+   if (rteam_author.value!='') {MM_validateForm('rteam_author','Author','RmaxLength:4000');};
+   if (fnc_c_meets_functionality.value!='') {MM_validateForm('fnc_c_meets_functionality','FUNCTIONALITY: Meets required functionality','RmaxLength:4000');};
+   if (rbs_c_bound_cond_handled.value!='') {MM_validateForm('rbs_c_bound_cond_handled','ROBUSTNESS: Boundary conditions handled','RmaxLength:4000');};
+   if (rbs_c_class_interf_precond.value!='') {MM_validateForm('rbs_c_class_interf_precond','ROBUSTNESS: Class interface preconditions tested','RmaxLength:4000');};
+   if (rbs_c_no_unitialised_date.value!='') {MM_validateForm('rbs_c_no_unitialised_date','ROBUSTNESS: No unititalised data','RmaxLength:4000');};
+   if (rbs_c_excep_handing.value!='') {MM_validateForm('rbs_c_excep_handing','ROBUSTNESS: Exception handling','RmaxLength:4000');};
+   if (rbs_c_resource_mng.value!='') {MM_validateForm('rbs_c_resource_mng','ROBUSTNESS: Resource mgt (db cxn, memory)','RmaxLength:4000');};
+   if (rbs_c_trans_complet.value!='') {MM_validateForm('rbs_c_trans_complet','ROBUSTNESS: Transaction completeness','RmaxLength:4000');};
+   if (rbs_c_threadsafety.value!='') {MM_validateForm('rbs_c_threadsafety','ROBUSTNESS: Threadsafety','RmaxLength:4000');};
+   if (rbs_c_ret_vals.value!='') {MM_validateForm('rbs_c_ret_vals','ROBUSTNESS: Return values (where appropriate)','RmaxLength:4000');};
+   if (rbs_c_corr_err_handling.value!='') {MM_validateForm('rbs_c_corr_err_handling','ROBUSTNESS: Correct err handling at Subsys bdys','RmaxLength:4000');};
+   if (rbs_c_sql_std.value!='') {MM_validateForm('rbs_c_sql_std','ROBUSTNESS: SQL correct and conforming to standards','RmaxLength:4000');};
+   if (mnt_c_ext_ref.value!='') {MM_validateForm('mnt_c_ext_ref','MAINTAINABILITY: External references explicit (eg: pkg imports)','RmaxLength:4000');};
+   if (mnt_c_class_size.value!='') {MM_validateForm('mnt_c_class_size','MAINTAINABILITY: Class size ok','RmaxLength:4000');};
+   if (mnt_c_method_size.value!='') {MM_validateForm('mnt_c_method_size','MAINTAINABILITY: Method size ok','RmaxLength:4000');};
+   if (mnt_c_approp_comm.value!='') {MM_validateForm('mnt_c_approp_comm','MAINTAINABILITY: Appropriate commenting','RmaxLength:4000');};
+   if (mnt_c_ident_name_std.value!='') {MM_validateForm('mnt_c_ident_name_std','MAINTAINABILITY: Indentifiers conform to naming standards','RmaxLength:4000');};
+   if (mnt_c_switch_have_defaults.value!='') {MM_validateForm('mnt_c_switch_have_defaults','MAINTAINABILITY: Switch statements have defaults','RmaxLength:4000');};
+   if (mnt_c_no_lit_num.value!='') {MM_validateForm('mnt_c_no_lit_num','MAINTAINABILITY: No literal numeric constants except 1, 0, 1','RmaxLength:4000');};
+   if (mnt_c_no_dead_code.value!='') {MM_validateForm('mnt_c_no_dead_code','MAINTAINABILITY: No dead or unused code','RmaxLength:4000');};
+   if (dei_c_std_des_patt.value!='') {MM_validateForm('dei_c_std_des_patt','DESIGN ISSUES: Use of standard design patterns','RmaxLength:4000');};
+   if (dei_c_approp_algor.value!='') {MM_validateForm('dei_c_approp_algor','DESIGN ISSUES: Use of appropriate algorithms (consider performance)','RmaxLength:4000');};
+   if (dei_c_approp_obj.value!='') {MM_validateForm('dei_c_approp_obj','DESIGN ISSUES: Use of appropriate objects (consider bloat, object focus, encapsulation)','RmaxLength:4000');};
+   if (dei_c_approp_err_msg.value!='') {MM_validateForm('dei_c_approp_err_msg','DESIGN ISSUES: Appropriate user error messages','RmaxLength:4000');};
+   if (dei_c_std_framew_comp.value!='') {MM_validateForm('dei_c_std_framew_comp','DESIGN ISSUES: Use of standard framework components','RmaxLength:4000');};
+   if (dei_c_approp_logging.value!='') {MM_validateForm('dei_c_approp_logging','DESIGN ISSUES: Appropriate logging','RmaxLength:4000');};
-   );return document.MM_returnValue;">
+   return document.MM_returnValue;">
    <table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
       <tr>
          <td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
          <td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl">&nbsp;Code Review for <%=pkgName%>&nbsp;<%=pkgVersion%> </td>
          <td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">

Subversion Repositories DevTools

(root)/ManagerSuite/Release_Manager/trunk/_wform_update_code_review.asp @ 185 – Rev 129 → 161