Subversion Repositories DevTools

Rev

Rev 119 | Show entire file | Ignore whitespace | Details | Blame | Last modification | View Log | RSS feed

Rev 119 Rev 129
Line 1... Line 1...
1 
<%@LANGUAGE="VBSCRIPT"%>
 1 
<%@LANGUAGE="VBSCRIPT"%>
2 
<%
 2 
<%
3 
Option explicit
 3 
Option explicit
4 
Response.Expires = 0	' always load the page, dont store
 4 
Response.Expires = 0   ' always load the page, dont store
5 
%>
 5 
%>
6 
<%
 6 
<%
7 
'=====================================================
 7 
'=====================================================
8 
'					Update Code Review
 8 
'               Update Code Review
9 
'=====================================================
 9 
'=====================================================
10 
%>
 10 
%>
11 
<!--#include file="common/conf.asp"-->
 11 
<!--#include file="common/conf.asp"-->
12 
<!--#include file="common/globals.asp"-->
 12 
<!--#include file="common/globals.asp"-->
13 
<!--#include file="common/formating.asp"-->
 13 
<!--#include file="common/formating.asp"-->
Line 34... Line 34...
34 
'------------ Constants Declaration -----------
 34 
'------------ Constants Declaration -----------
35 
'------------ Variable Init -------------------
 35 
'------------ Variable Init -------------------
36 
parPv_id = Request("pv_id")
 36 
parPv_id = Request("pv_id")
37 
parRtag_id = Request("rtag_id")
 37 
parRtag_id = Request("rtag_id")
38 
arrItemResults = Array ( "","","", _
 38 
arrItemResults = Array ( "","","", _
39 
					   "Pass",enumCODE_REVIEW_PASS,"class='pass_alert'", _
 39 
                  "Pass",enumCODE_REVIEW_PASS,"class='pass_alert'", _
40 
					   "Fail",enumCODE_REVIEW_FAIL,"class='err_alert'" )
 40 
                  "Fail",enumCODE_REVIEW_FAIL,"class='err_alert'" )
41 
arrOverallResults = Array ( "","", _
 41 
arrOverallResults = Array ( "","", _
42 
							"Accepted",enumCODE_REVIEW_ACCEPTED, _
 42 
                     "Accepted",enumCODE_REVIEW_ACCEPTED, _
43 
							"Minor updates required",enumCODE_REVIEW_MINOR_UPDATES, _
 43 
                     "Minor updates required",enumCODE_REVIEW_MINOR_UPDATES, _
44 
							"Major rework required",enumCODE_REVIEW_MAJOR_REWORK )
 44 
                     "Major rework required",enumCODE_REVIEW_MAJOR_REWORK )
45 
'----------------------------------------------
 45 
'----------------------------------------------
46 
%>
 46 
%>
47 
<%
 47 
<%
48 
'-----------------------------------------------------------------------------------------------------------------------------------
 48 
'-----------------------------------------------------------------------------------------------------------------------------------
49 
Sub GetCodeReview ( nPv_id, oRS )
 49 
Sub GetCodeReview ( nPv_id, oRS )
50 
	Dim Query_String
 50 
   Dim Query_String
51 
	Query_String = _
 51 
   Query_String = _
52 
	" SELECT *  FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
 52 
   " SELECT *  FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
53 
	Query_String = Replace( Query_String, ":PV_ID", nPv_id )
 53 
   Query_String = Replace( Query_String, ":PV_ID", nPv_id )
54
54 
 
55 
	Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
 55 
   Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
56
56 
 
57 
	' Make sure therer is always a record to read from
 57 
   ' Make sure therer is always a record to read from
58 
	If oRS.RecordCount < 1 Then
 58 
   If oRS.RecordCount < 1 Then
59 
		oRS.Close
 59 
      oRS.Close
60 
		Call InserDefaultRow ( parPv_id )
 60 
      Call InserDefaultRow ( parPv_id )
61 
		Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
 61 
      Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
62 
	End If
 62 
   End If
63
63 
 
64 
End Sub
 64 
End Sub
65 
'-----------------------------------------------------------------------------------------------------------------------------------
 65 
'-----------------------------------------------------------------------------------------------------------------------------------
66 
Function DrawItemResult ( cCheck )
 66 
Function DrawItemResult ( cCheck )
67 
	Dim item, val, maxOptions, selected, tempSTR
 67 
   Dim item, val, maxOptions, selected, tempSTR
68 
	maxOptions = UBound( arrItemResults )
 68 
   maxOptions = UBound( arrItemResults )
69
69 
 
70 
	tempSTR = ""
 70 
   tempSTR = ""
71 
	For val = 0 to maxOptions Step 3
 71 
   For val = 0 to maxOptions Step 3
72 
		selected = ""
 72 
      selected = ""
73 
		If CStr( arrItemResults(val + 1) ) = cCheck Then selected = "selected"
 73 
      If CStr( arrItemResults(val + 1) ) = cCheck Then selected = "selected"
74 
		tempSTR =  tempSTR & "<option value='"& arrItemResults( val + 1 ) &"' "& selected &" "& arrItemResults(val + 2) &">"& arrItemResults( val ) &"</option>"& VBNewLine
 74 
      tempSTR =  tempSTR & "<option value='"& arrItemResults( val + 1 ) &"' "& selected &" "& arrItemResults(val + 2) &">"& arrItemResults( val ) &"</option>"& VBNewLine
75 
	Next
 75 
   Next
76
76 
 
77 
	DrawItemResult = tempSTR
 77 
   DrawItemResult = tempSTR
78 
End Function
 78 
End Function
79 
'-----------------------------------------------------------------------------------------------------------------------------------
 79 
'-----------------------------------------------------------------------------------------------------------------------------------
80 
Function DrawOverallResult ( ByVal nResult )
 80 
Function DrawOverallResult ( ByVal nResult )
81 
	Dim val, maxOptions, tempSTR, selected
 81 
   Dim val, maxOptions, tempSTR, selected
82 
	maxOptions = Ubound( arrOverallResults )
 82 
   maxOptions = Ubound( arrOverallResults )
83 
	If nResult = "" OR IsNull(nResult) Then nResult = 0
 83 
   If nResult = "" OR IsNull(nResult) Then nResult = 0
84
84 
 
85 
	tempSTR = ""
 85 
   tempSTR = ""
86 
	For val = 0 To maxOptions Step 2
 86 
   For val = 0 To maxOptions Step 2
87 
		selected = ""
 87 
      selected = ""
88 
		If arrOverallResults(val + 1) = CInt( nResult ) Then selected = "selected"
 88 
      If arrOverallResults(val + 1) = CInt( nResult ) Then selected = "selected"
89 
		tempSTR =  tempSTR & "<option value='"& arrOverallResults( val + 1 ) &"' "& selected &">"& arrOverallResults( val ) &"</option>"& VBNewLine
 89 
      tempSTR =  tempSTR & "<option value='"& arrOverallResults( val + 1 ) &"' "& selected &">"& arrOverallResults( val ) &"</option>"& VBNewLine
90 
	Next
 90 
   Next
91
91 
 
92 
	DrawOverallResult = tempSTR
 92 
   DrawOverallResult = tempSTR
93 
End Function
 93 
End Function
94 
'-----------------------------------------------------------------------------------------------------------------------------------
 94 
'-----------------------------------------------------------------------------------------------------------------------------------
95 
Sub InserDefaultRow ( nPv_id )
 95 
Sub InserDefaultRow ( nPv_id )
- 
 
 96 
   objEH.TryORA ( OraSession )
96 
	OraSession.BeginTrans
 97 
   On Error Resume Next
97 
	OraDatabase.ExecuteSQL  _
 98 
   OraDatabase.ExecuteSQL  _
98 
	" INSERT INTO CODE_REVIEWS (pv_id) VALUES("& nPv_id &")"
 99 
   " INSERT INTO CODE_REVIEWS (pv_id) VALUES("& nPv_id &")"
99 
	OraSession.CommitTrans
 100 
   objEH.CatchORA ( OraSession )
100 
End Sub
 101 
End Sub
101 
'-----------------------------------------------------------------------------------------------------------------------------------
 102 
'-----------------------------------------------------------------------------------------------------------------------------------
102 
%>
 103 
%>
103 
<%
 104 
<%
104 
'------------ Action Requirements -------------------
 105 
'------------ Action Requirements -------------------
105 
'Process submition
 106 
'Process submition
106 
If CBool(Request("action")) AND objAccessControl.UserLogedIn Then
 107 
If CBool(Request("action")) AND objAccessControl.UserLogedIn Then
107 
	Call UpdateCodeReview ( parPv_id )
 108 
   Call UpdateCodeReview ( parPv_id )
108 
	Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
 109 
   Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
109 
	'Response.Redirect ( "_wform_code_review.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
 110 
   'Response.Redirect ( "_wform_code_review.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
110 
	'Call CloseWindow
 111 
   'Call CloseWindow
111
112 
 
112
113 
 
113 
End If
 114 
End If
114 
Call Get_Pkg_Short_Info(  parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, NULL )
 115 
Call Get_Pkg_Short_Info(  parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, NULL )
115 
Call GetCodeReview ( parPv_id, rsQry )
 116 
Call GetCodeReview ( parPv_id, rsQry )
116 
%>
 117 
%>
117 
<html>
 118 
<html>
Line 128... Line 129...
128 
</head>
 129 
</head>
129 
<body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
 130 
<body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
130 
<!-- TIPS LAYERS -------------------------------------->
 131 
<!-- TIPS LAYERS -------------------------------------->
131 
<div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10">&nbsp;</div>
 132 
<div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10">&nbsp;</div>
132 
<!----------------------------------------------------->
 133 
<!----------------------------------------------------->
133 
<form action="_wform_code_review.asp" method="post" name="codereview"
134 
<form action="_wform_code_review.asp" method="post" name="codereview"
134 
onSubmit="MM_validateForm(
 135 
   onSubmit="MM_validateForm(
135 
'date_of_review','Date of Review','RisDate',
 136 
   'date_of_review','Date of Review','RisDate',
136 
'time_spent','Time Spent','RisNumber',
 137 
   'time_spent','Time Spent','RisNumber',
137 
'review_reason','Reason for Review','RmaxLength:4000',
 138 
   'review_reason','Reason for Review','RmaxLength:4000',
138 
'files_reviewed','Files Reviewed','RmaxLength:4000',
 139 
   'files_reviewed','Files Reviewed','RmaxLength:4000',
139 
'review_results','Review Results','R'
 140 
   'review_results','Review Results','R'
140 
);return document.MM_returnValue;">
141 
   );return document.MM_returnValue;">
141 
  <table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
 142 
   <table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
142 
    <tr>
143 
      <tr>
143 
      <td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
 144 
         <td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
144 
      <td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl">&nbsp;Code Review for <%=pkgName%>&nbsp;<%=pkgVersion%> </td>
 145 
         <td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl">&nbsp;Code Review for <%=pkgName%>&nbsp;<%=pkgVersion%> </td>
145 
	  <td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
 146 
         <td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
146 
		<input type="submit" name="btn" value="Save" class="form_btn">
 147 
            <input type="submit" name="btn" value="Save" class="form_btn">
147 
		<input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
 148 
            <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
148 
      </td>
 149 
         </td>
149 
      <td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td>
 150 
         <td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td>
150 
    </tr>
 151 
      </tr>
151 
    <tr>
152 
      <tr>
152 
      <td height="100%" width="1%">&nbsp;</td>
 153 
         <td height="100%" width="1%">&nbsp;</td>
153 
      <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
154 
         <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
154 
        <br>
 155 
            <br>
155 
        <br>
 156 
            <br>
156 
        <table width="100%"  border="0" cellspacing="0" cellpadding="0">
 157 
            <table width="100%"  border="0" cellspacing="0" cellpadding="0">
157 
          <tr>
 158 
               <tr>
158 
            <td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
 159 
                  <td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
159 
            <td width="100%">
 160 
                  <td width="100%">
160 
			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
 161 
                     <table width="100%"  border="0" cellspacing="1" cellpadding="4">
161 
			  <tr align="center">
 162 
                        <tr align="center">
162 
                <td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td>
 163 
                           <td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td>
163 
                </tr>
 164 
                        </tr>
164 
			  <tr>
 165 
                        <tr>
165 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
 166 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
166 
				<td nowrap bgcolor="#FFFFFF" class="form_item">
 167 
                           <td nowrap bgcolor="#FFFFFF" class="form_item">
167 
				  <input name="date_of_review" type="text" size="20" maxlength="20" class="form_item" value='<%If IsNull(rsQry("date_of_review")) Then%><%=EuroDate ( Date )%><%Else%><%=EuroDate ( rsQry("date_of_review") )%><%End If%>'>&nbsp;&nbsp;&nbsp;</td>
 168 
                           <input name="date_of_review" type="text" size="20" maxlength="20" class="form_item" value='<%If IsNull(rsQry("date_of_review")) Then%><%=EuroDate ( Date )%><%Else%><%=EuroDate ( rsQry("date_of_review") )%><%End If%>'>&nbsp;&nbsp;&nbsp;</td>
168 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">&nbsp;&nbsp;&nbsp;Time Spent (hrs)</td>
 169 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">&nbsp;&nbsp;&nbsp;Time Spent (hrs)</td>
169 
				<td bgcolor="#FFFFFF" class="form_item">
 170 
                           <td bgcolor="#FFFFFF" class="form_item">
170 
				  <input name="time_spent" type="text" size="20" maxlength="20" class="form_item" value="<%=rsQry("time_spent")%>"></td>
 171 
                           <input name="time_spent" type="text" size="20" maxlength="20" class="form_item" value="<%=rsQry("time_spent")%>"></td>
171 
			  </tr>
 172 
                        </tr>
172 
			  <tr>
 173 
                        <tr>
173 
				<td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
 174 
                           <td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
174 
				<td colspan="3" bgcolor="#FFFFFF" class="form_item">
 175 
                           <td colspan="3" bgcolor="#FFFFFF" class="form_item">
175 
				  <textarea name="review_reason" cols="80" rows="5" class="form_item"><%=rsQry("review_reason")%></textarea></td>
 176 
                           <textarea name="review_reason" cols="80" rows="5" class="form_item"><%=rsQry("review_reason")%></textarea></td>
176 
			  </tr>
 177 
                        </tr>
177 
			  <tr>
 178 
                        <tr>
178 
				<td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
 179 
                           <td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
179 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
 180 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
180 
				<td colspan="2" bgcolor="#FFFFFF" class="form_item">
 181 
                           <td colspan="2" bgcolor="#FFFFFF" class="form_item">
181 
				  <textarea name="rteam_domain_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_domain_expert")%></textarea></td>
 182 
                           <textarea name="rteam_domain_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_domain_expert")%></textarea></td>
182 
			  </tr>
 183 
                        </tr>
183 
			  <tr>
 184 
                        <tr>
184 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
 185 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
185 
				<td colspan="2" bgcolor="#FFFFFF" class="form_item">
 186 
                           <td colspan="2" bgcolor="#FFFFFF" class="form_item">
186 
				  <textarea name="rteam_language_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_language_expert")%></textarea></td>
 187 
                           <textarea name="rteam_language_expert" cols="60" rows="2" class="form_item"><%=rsQry("rteam_language_expert")%></textarea></td>
187 
			  </tr>
 188 
                        </tr>
188 
			  <tr>
 189 
                        <tr>
189 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
 190 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
190 
				<td colspan="2" bgcolor="#FFFFFF" class="form_item">
 191 
                           <td colspan="2" bgcolor="#FFFFFF" class="form_item">
191 
				  <textarea name="rteam_peer_developer" cols="60" rows="2" class="form_item"><%=rsQry("rteam_peer_developer")%></textarea></td>
 192 
                           <textarea name="rteam_peer_developer" cols="60" rows="2" class="form_item"><%=rsQry("rteam_peer_developer")%></textarea></td>
192 
			  </tr>
 193 
                        </tr>
193 
			  <tr>
 194 
                        <tr>
194 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
 195 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
195 
				<td colspan="2" bgcolor="#FFFFFF" class="form_item">
 196 
                           <td colspan="2" bgcolor="#FFFFFF" class="form_item">
196 
				  <textarea name="rteam_author" cols="60" rows="2" class="form_item"><%=rsQry("rteam_author")%></textarea></td>
 197 
                           <textarea name="rteam_author" cols="60" rows="2" class="form_item"><%=rsQry("rteam_author")%></textarea></td>
197 
			  </tr>
 198 
                        </tr>
198 
			  <tr>
 199 
                        <tr>
199 
                <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
 200 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
200 
                <td colspan="3" bgcolor="#FFFFFF" class="form_item">
 201 
                           <td colspan="3" bgcolor="#FFFFFF" class="form_item">
201 
                  <textarea name="files_reviewed" cols="80" rows="5" class="form_item"><%=rsQry("files_reviewed")%></textarea></td>
 202 
                           <textarea name="files_reviewed" cols="80" rows="5" class="form_item"><%=rsQry("files_reviewed")%></textarea></td>
202 
			    </tr>
 203 
                        </tr>
203 
			  <tr>
 204 
                        <tr>
204 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
 205 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
205 
				<td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" class="form_item" id="review_results">
 206 
                           <td colspan="3" bgcolor="#FFFFFF" class="form_item">
206 
                  <%=DrawOverallResult ( rsQry("review_results") )%>
 207 
                              <select name="review_results" class="form_item" id="review_results">
207 
                </select></td>
 208 
                                 <%=DrawOverallResult ( rsQry("review_results") )%>
208 
			  </tr>
 209 
                              </select>
209 
			  <tr>
 210 
                           </td>
210 
				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
 211 
                        </tr>
211 
				<td colspan="3" bgcolor="#FFFFFF" class="form_item">
 212 
                        <tr>
212 
				  <textarea name="issues_raised" cols="80" rows="5" class="form_item"><%=rsQry("issues_raised")%></textarea></td>
 213 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
213 
			  </tr>
 214 
                           <td colspan="3" bgcolor="#FFFFFF" class="form_item">
214 
			  <tr>
 215 
                           <textarea name="issues_raised" cols="80" rows="5" class="form_item"><%=rsQry("issues_raised")%></textarea></td>
215 
			    <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
 216 
                        </tr>
216 
			    <td colspan="3" bgcolor="#FFFFFF" class="form_item">
 217 
                        <tr>
217 
			      <textarea name="review_comments" cols="80" rows="5" class="form_item"><%=rsQry("review_comments")%></textarea></td>
 218 
                           <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
218 
			    </tr>
 219 
                           <td colspan="3" bgcolor="#FFFFFF" class="form_item">
219 
			</table>
220 
                           <textarea name="review_comments" cols="80" rows="5" class="form_item"><%=rsQry("review_comments")%></textarea></td>
220 
			<br>
 221 
                        </tr>
221 
			<br>
 222 
                     </table>
222 
			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
 223 
                     <br>
223 
              <tr align="center">
 224 
                     <br>
224 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td>
 225 
                     <table width="100%"  border="0" cellspacing="1" cellpadding="4">
225 
                </tr>
 226 
                        <tr align="center">
226 
              <tr>
 227 
                           <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td>
227 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
 228 
                        </tr>
228 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
 229 
                        <tr>
229 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
 230 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
230 
              </tr>
 231 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
231 
              <tr>
 232 
                           <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
232 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>
 233 
                        </tr>
233 
                <td valign="top" bgcolor="#FFFFFF"><select name="fnc_s_meets_functionality" class="form_item" id="fnc_s_meets_functionality">
 234 
                        <tr>
234 
                  <%=DrawItemResult( rsQry("fnc_s_meets_functionality") )%>
 235 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>
235 
                </select></td>
 236 
                           <td valign="top" bgcolor="#FFFFFF">
236 
                <td bgcolor="#FFFFFF" class="form_item">
 237 
                              <select name="fnc_s_meets_functionality" class="form_item" id="fnc_s_meets_functionality">
237 
                  <textarea name="fnc_c_meets_functionality" cols="60" rows="3" class="form_item"><%=rsQry("fnc_c_meets_functionality")%></textarea></td>
 238 
                                 <%=DrawItemResult( rsQry("fnc_s_meets_functionality") )%>
238 
              </tr>
 239 
                              </select>
239 
            </table>
 240 
                           </td>
240 
			<br>
 241 
                           <td bgcolor="#FFFFFF" class="form_item">
241 
			<br>
 242 
                           <textarea name="fnc_c_meets_functionality" cols="60" rows="3" class="form_item"><%=rsQry("fnc_c_meets_functionality")%></textarea></td>
242 
			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
 243 
                        </tr>
243 
              <tr align="center">
 244 
                     </table>
244 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td>
 245 
                     <br>
245 
              </tr>
 246 
                     <br>
246 
              <tr>
 247 
                     <table width="100%"  border="0" cellspacing="1" cellpadding="4">
247 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
 248 
                        <tr align="center">
248 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
 249 
                           <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td>
249 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
 250 
                        </tr>
250 
              </tr>
 251 
                        <tr>
251 
              <tr>
 252 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
252 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>
 253 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
253 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_bound_cond_handled" class="form_item" id="rbs_s_bound_cond_handled">
 254 
                           <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
254 
                    <%=DrawItemResult( rsQry("rbs_s_bound_cond_handled") )%>
 255 
                        </tr>
255 
                </select></td>
 256 
                        <tr>
256 
                <td bgcolor="#FFFFFF" class="form_item">
 257 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>
257 
                  <textarea name="rbs_c_bound_cond_handled" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_bound_cond_handled")%></textarea></td>
 258 
                           <td valign="top" bgcolor="#FFFFFF">
258 
              </tr>
 259 
                              <select name="rbs_s_bound_cond_handled" class="form_item" id="rbs_s_bound_cond_handled">
259 
              <tr>
 260 
                                 <%=DrawItemResult( rsQry("rbs_s_bound_cond_handled") )%>
260 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>
 261 
                              </select>
261 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" class="form_item" id="rbs_s_class_interf_precond">
 262 
                           </td>
262 
                  <%=DrawItemResult( rsQry("rbs_s_class_interf_precond") )%>
 263 
                           <td bgcolor="#FFFFFF" class="form_item">
263 
                </select></td>
 264 
                           <textarea name="rbs_c_bound_cond_handled" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_bound_cond_handled")%></textarea></td>
264 
                <td bgcolor="#FFFFFF" class="form_item">
 265 
                        </tr>
265 
                  <textarea name="rbs_c_class_interf_precond" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_class_interf_precond")%></textarea></td>
 266 
                        <tr>
266 
              </tr>
 267 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>
267 
			  <tr>
 268 
                           <td valign="top" bgcolor="#FFFFFF">
268 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
 269 
                              <select name="rbs_s_class_interf_precond" class="form_item" id="rbs_s_class_interf_precond">
269 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" class="form_item" id="rbs_s_no_unitialised_date">
 270 
                                 <%=DrawItemResult( rsQry("rbs_s_class_interf_precond") )%>
270 
                  <%=DrawItemResult( rsQry("rbs_s_no_unitialised_date") )%>
 271 
                              </select>
271 
                </select></td>
 272 
                           </td>
272 
                <td bgcolor="#FFFFFF" class="form_item">
 273 
                           <td bgcolor="#FFFFFF" class="form_item">
273 
                  <textarea name="rbs_c_no_unitialised_date" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_no_unitialised_date")%></textarea></td>
 274 
                           <textarea name="rbs_c_class_interf_precond" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_class_interf_precond")%></textarea></td>
274 
              </tr>
 275 
                        </tr>
275 
			  <tr>
 276 
                        <tr>
276 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
 277 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
277 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" class="form_item" id="rbs_s_excep_handing">
 278 
                           <td valign="top" bgcolor="#FFFFFF">
278 
                  <%=DrawItemResult( rsQry("rbs_s_excep_handing") )%>
 279 
                              <select name="rbs_s_no_unitialised_date" class="form_item" id="rbs_s_no_unitialised_date">
279 
                </select></td>
 280 
                                 <%=DrawItemResult( rsQry("rbs_s_no_unitialised_date") )%>
280 
                <td bgcolor="#FFFFFF" class="form_item">
 281 
                              </select>
281 
                  <textarea name="rbs_c_excep_handing" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_excep_handing")%></textarea></td>
 282 
                           </td>
282 
              </tr>
 283 
                           <td bgcolor="#FFFFFF" class="form_item">
283 
			  <tr>
 284 
                           <textarea name="rbs_c_no_unitialised_date" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_no_unitialised_date")%></textarea></td>
284 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
 285 
                        </tr>
285 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" class="form_item" id="rbs_s_resource_mng">
 286 
                        <tr>
286 
                  <%=DrawItemResult( rsQry("rbs_s_resource_mng") )%>
 287 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
287 
                </select></td>
 288 
                           <td valign="top" bgcolor="#FFFFFF">
288 
                <td bgcolor="#FFFFFF" class="form_item">
 289 
                              <select name="rbs_s_excep_handing" class="form_item" id="rbs_s_excep_handing">
289 
                  <textarea name="rbs_c_resource_mng" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_resource_mng")%></textarea></td>
 290 
                                 <%=DrawItemResult( rsQry("rbs_s_excep_handing") )%>
290 
              </tr>
 291 
                              </select>
291 
			  <tr>
 292 
                           </td>
292 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
 293 
                           <td bgcolor="#FFFFFF" class="form_item">
293 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" class="form_item" id="rbs_s_trans_complet">
 294 
                           <textarea name="rbs_c_excep_handing" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_excep_handing")%></textarea></td>
294 
                  <%=DrawItemResult( rsQry("rbs_s_trans_complet") )%>
 295 
                        </tr>
295 
                </select></td>
 296 
                        <tr>
296 
                <td bgcolor="#FFFFFF" class="form_item">
 297 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
297 
                  <textarea name="rbs_c_trans_complet" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_trans_complet")%></textarea></td>
 298 
                           <td valign="top" bgcolor="#FFFFFF">
298 
              </tr>
 299 
                              <select name="rbs_s_resource_mng" class="form_item" id="rbs_s_resource_mng">
299 
			  <tr>
 300 
                                 <%=DrawItemResult( rsQry("rbs_s_resource_mng") )%>
300 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
 301 
                              </select>
301 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" class="form_item" id="rbs_s_threadsafety">
 302 
                           </td>
302 
                  <%=DrawItemResult( rsQry("rbs_s_threadsafety") )%>
 303 
                           <td bgcolor="#FFFFFF" class="form_item">
303 
                </select></td>
 304 
                           <textarea name="rbs_c_resource_mng" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_resource_mng")%></textarea></td>
304 
                <td bgcolor="#FFFFFF" class="form_item">
 305 
                        </tr>
305 
                  <textarea name="rbs_c_threadsafety" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_threadsafety")%></textarea></td>
 306 
                        <tr>
306 
              </tr>
 307 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
307 
			  <tr>
 308 
                           <td valign="top" bgcolor="#FFFFFF">
308 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
 309 
                              <select name="rbs_s_trans_complet" class="form_item" id="rbs_s_trans_complet">
309 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" class="form_item" id="rbs_s_ret_vals">
 310 
                                 <%=DrawItemResult( rsQry("rbs_s_trans_complet") )%>
310 
                  <%=DrawItemResult( rsQry("rbs_s_ret_vals") )%>
 311 
                              </select>
311 
                </select></td>
 312 
                           </td>
312 
                <td bgcolor="#FFFFFF" class="form_item">
 313 
                           <td bgcolor="#FFFFFF" class="form_item">
313 
                  <textarea name="rbs_c_ret_vals" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_ret_vals")%></textarea></td>
 314 
                           <textarea name="rbs_c_trans_complet" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_trans_complet")%></textarea></td>
314 
              </tr>
 315 
                        </tr>
315 
			  <tr>
 316 
                        <tr>
316 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
 317 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
317 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" class="form_item" id="rbs_s_corr_err_handling">
 318 
                           <td valign="top" bgcolor="#FFFFFF">
318 
                  <%=DrawItemResult( rsQry("rbs_s_corr_err_handling") )%>
 319 
                              <select name="rbs_s_threadsafety" class="form_item" id="rbs_s_threadsafety">
319 
                </select></td>
 320 
                                 <%=DrawItemResult( rsQry("rbs_s_threadsafety") )%>
320 
                <td bgcolor="#FFFFFF" class="form_item">
 321 
                              </select>
321 
                  <textarea name="rbs_c_corr_err_handling" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_corr_err_handling")%></textarea></td>
 322 
                           </td>
322 
              </tr>
 323 
                           <td bgcolor="#FFFFFF" class="form_item">
323 
			  <tr>
 324 
                           <textarea name="rbs_c_threadsafety" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_threadsafety")%></textarea></td>
324 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
 325 
                        </tr>
325 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" class="form_item" id="rbs_s_sql_std">
 326 
                        <tr>
326 
                  <%=DrawItemResult( rsQry("rbs_s_sql_std") )%>
 327 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
327 
                </select></td>
 328 
                           <td valign="top" bgcolor="#FFFFFF">
328 
                <td bgcolor="#FFFFFF" class="form_item">
 329 
                              <select name="rbs_s_ret_vals" class="form_item" id="rbs_s_ret_vals">
329 
                  <textarea name="rbs_c_sql_std" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_sql_std")%></textarea></td>
 330 
                                 <%=DrawItemResult( rsQry("rbs_s_ret_vals") )%>
330 
              </tr>
 331 
                              </select>
331 
            </table>
 332 
                           </td>
332 
			<br>
 333 
                           <td bgcolor="#FFFFFF" class="form_item">
333 
			<br>
 334 
                           <textarea name="rbs_c_ret_vals" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_ret_vals")%></textarea></td>
334 
			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
 335 
                        </tr>
335 
              <tr align="center">
 336 
                        <tr>
336 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td>
 337 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
337 
              </tr>
 338 
                           <td valign="top" bgcolor="#FFFFFF">
338 
              <tr>
 339 
                              <select name="rbs_s_corr_err_handling" class="form_item" id="rbs_s_corr_err_handling">
339 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
 340 
                                 <%=DrawItemResult( rsQry("rbs_s_corr_err_handling") )%>
340 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
 341 
                              </select>
341 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
 342 
                           </td>
342 
              </tr>
 343 
                           <td bgcolor="#FFFFFF" class="form_item">
343 
              <tr>
 344 
                           <textarea name="rbs_c_corr_err_handling" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_corr_err_handling")%></textarea></td>
344 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>
 345 
                        </tr>
345 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ext_ref" class="form_item" id="mnt_s_ext_ref">
 346 
                        <tr>
346 
                    <%=DrawItemResult( rsQry("mnt_s_ext_ref") )%>
 347 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
347 
                </select></td>
 348 
                           <td valign="top" bgcolor="#FFFFFF">
348 
                <td bgcolor="#FFFFFF" class="form_item">
 349 
                              <select name="rbs_s_sql_std" class="form_item" id="rbs_s_sql_std">
349 
                  <textarea name="mnt_c_ext_ref" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ext_ref")%></textarea></td>
 350 
                                 <%=DrawItemResult( rsQry("rbs_s_sql_std") )%>
350 
              </tr>
 351 
                              </select>
351 
              <tr>
 352 
                           </td>
352 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>
 353 
                           <td bgcolor="#FFFFFF" class="form_item">
353 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_class_size" class="form_item" id="mnt_s_class_size">
 354 
                           <textarea name="rbs_c_sql_std" cols="60" rows="3" class="form_item"><%=rsQry("rbs_c_sql_std")%></textarea></td>
354 
                    <%=DrawItemResult( rsQry("mnt_s_class_size") )%>
 355 
                        </tr>
355 
                </select></td>
 356 
                     </table>
356 
                <td bgcolor="#FFFFFF" class="form_item">
 357 
                     <br>
357 
                  <textarea name="mnt_c_class_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_class_size")%></textarea></td>
 358 
                     <br>
358 
              </tr>
 359 
                     <table width="100%"  border="0" cellspacing="1" cellpadding="4">
359 
              <tr>
 360 
                        <tr align="center">
360 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>
 361 
                           <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td>
361 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_method_size" class="form_item" id="mnt_s_method_size">
 362 
                        </tr>
362 
                    <%=DrawItemResult( rsQry("mnt_s_method_size") )%>
 363 
                        <tr>
363 
                </select></td>
 364 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
364 
                <td bgcolor="#FFFFFF" class="form_item">
 365 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
365 
                  <textarea name="mnt_c_method_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_method_size")%></textarea></td>
 366 
                           <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
366 
              </tr>
 367 
                        </tr>
367 
              <tr>
 368 
                        <tr>
368 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>
 369 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>
369 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_approp_comm" class="form_item" id="mnt_s_approp_comm">
 370 
                           <td valign="top" bgcolor="#FFFFFF">
370 
                    <%=DrawItemResult( rsQry("mnt_s_approp_comm") )%>
 371 
                              <select name="mnt_s_ext_ref" class="form_item" id="mnt_s_ext_ref">
371 
                </select></td>
 372 
                                 <%=DrawItemResult( rsQry("mnt_s_ext_ref") )%>
372 
                <td bgcolor="#FFFFFF" class="form_item">
 373 
                              </select>
373 
                  <textarea name="mnt_c_approp_comm" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_approp_comm")%></textarea></td>
 374 
                           </td>
374 
              </tr>
 375 
                           <td bgcolor="#FFFFFF" class="form_item">
375 
              <tr>
 376 
                           <textarea name="mnt_c_ext_ref" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ext_ref")%></textarea></td>
376 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>
 377 
                        </tr>
377 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ident_name_std" class="form_item" id="mnt_s_ident_name_std">
 378 
                        <tr>
378 
                    <%=DrawItemResult( rsQry("mnt_s_ident_name_std") )%>
 379 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>
379 
                </select></td>
 380 
                           <td valign="top" bgcolor="#FFFFFF">
380 
                <td bgcolor="#FFFFFF" class="form_item">
 381 
                              <select name="mnt_s_class_size" class="form_item" id="mnt_s_class_size">
381 
                  <textarea name="mnt_c_ident_name_std" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ident_name_std")%></textarea></td>
 382 
                                 <%=DrawItemResult( rsQry("mnt_s_class_size") )%>
382 
              </tr>
 383 
                              </select>
383 
              <tr>
 384 
                           </td>
384 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>
 385 
                           <td bgcolor="#FFFFFF" class="form_item">
385 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_switch_have_defaults" class="form_item" id="mnt_s_switch_have_defaults">
 386 
                           <textarea name="mnt_c_class_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_class_size")%></textarea></td>
386 
                    <%=DrawItemResult( rsQry("mnt_s_switch_have_defaults") )%>
 387 
                        </tr>
387 
                </select></td>
 388 
                        <tr>
388 
                <td bgcolor="#FFFFFF" class="form_item">
 389 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>
389 
                  <textarea name="mnt_c_switch_have_defaults" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_switch_have_defaults")%></textarea></td>
 390 
                           <td valign="top" bgcolor="#FFFFFF">
390 
              </tr>
 391 
                              <select name="mnt_s_method_size" class="form_item" id="mnt_s_method_size">
391 
              <tr>
 392 
                                 <%=DrawItemResult( rsQry("mnt_s_method_size") )%>
392 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except –1, 0, 1</td>
 393 
                              </select>
393 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_lit_num" class="form_item" id="mnt_s_no_lit_num">
 394 
                           </td>
394 
                    <%=DrawItemResult( rsQry("mnt_s_no_lit_num") )%>
 395 
                           <td bgcolor="#FFFFFF" class="form_item">
395 
                </select></td>
 396 
                           <textarea name="mnt_c_method_size" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_method_size")%></textarea></td>
396 
                <td bgcolor="#FFFFFF" class="form_item">
 397 
                        </tr>
397 
                  <textarea name="mnt_c_no_lit_num" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_lit_num")%></textarea></td>
 398 
                        <tr>
398 
              </tr>
 399 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>
399 
              <tr>
 400 
                           <td valign="top" bgcolor="#FFFFFF">
400 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>
 401 
                              <select name="mnt_s_approp_comm" class="form_item" id="mnt_s_approp_comm">
401 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_dead_code" class="form_item" id="mnt_s_no_dead_code">
 402 
                                 <%=DrawItemResult( rsQry("mnt_s_approp_comm") )%>
402 
                    <%=DrawItemResult( rsQry("mnt_s_no_dead_code") )%>
 403 
                              </select>
403 
                </select></td>
 404 
                           </td>
404 
                <td bgcolor="#FFFFFF" class="form_item">
 405 
                           <td bgcolor="#FFFFFF" class="form_item">
405 
                  <textarea name="mnt_c_no_dead_code" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_dead_code")%></textarea></td>
 406 
                           <textarea name="mnt_c_approp_comm" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_approp_comm")%></textarea></td>
406 
              </tr>
 407 
                        </tr>
407 
            </table>
 408 
                        <tr>
408 
			<br>
 409 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>
409 
			<br>
 410 
                           <td valign="top" bgcolor="#FFFFFF">
410 
			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
 411 
                              <select name="mnt_s_ident_name_std" class="form_item" id="mnt_s_ident_name_std">
411 
              <tr align="center">
 412 
                                 <%=DrawItemResult( rsQry("mnt_s_ident_name_std") )%>
412 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td>
 413 
                              </select>
413 
              </tr>
 414 
                           </td>
414 
              <tr>
 415 
                           <td bgcolor="#FFFFFF" class="form_item">
415 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
 416 
                           <textarea name="mnt_c_ident_name_std" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_ident_name_std")%></textarea></td>
416 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
 417 
                        </tr>
417 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
 418 
                        <tr>
418 
              </tr>
 419 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>
419 
              <tr>
 420 
                           <td valign="top" bgcolor="#FFFFFF">
420 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>
 421 
                              <select name="mnt_s_switch_have_defaults" class="form_item" id="mnt_s_switch_have_defaults">
421 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_des_patt" class="form_item" id="dei_s_std_des_patt">
 422 
                                 <%=DrawItemResult( rsQry("mnt_s_switch_have_defaults") )%>
422 
                    <%=DrawItemResult( rsQry("dei_s_std_des_patt") )%>
 423 
                              </select>
423 
                </select></td>
 424 
                           </td>
424 
                <td bgcolor="#FFFFFF" class="form_item">
 425 
                           <td bgcolor="#FFFFFF" class="form_item">
425 
                  <textarea name="dei_c_std_des_patt" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_des_patt")%></textarea></td>
 426 
                           <textarea name="mnt_c_switch_have_defaults" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_switch_have_defaults")%></textarea></td>
426 
              </tr>
 427 
                        </tr>
427 
              <tr>
 428 
                        <tr>
428 
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>
 429 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except –1, 0, 1</td>
429 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_algor" class="form_item" id="dei_s_approp_algor">
 430 
                           <td valign="top" bgcolor="#FFFFFF">
430 
                    <%=DrawItemResult( rsQry("dei_s_approp_algor") )%>
 431 
                              <select name="mnt_s_no_lit_num" class="form_item" id="mnt_s_no_lit_num">
431 
                </select></td>
 432 
                                 <%=DrawItemResult( rsQry("mnt_s_no_lit_num") )%>
432 
                <td bgcolor="#FFFFFF" class="form_item">
 433 
                              </select>
433 
                  <textarea name="dei_c_approp_algor" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_algor")%></textarea></td>
 434 
                           </td>
434 
              </tr>
 435 
                           <td bgcolor="#FFFFFF" class="form_item">
435 
              <tr>
 436 
                           <textarea name="mnt_c_no_lit_num" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_lit_num")%></textarea></td>
436 
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>
 437 
                        </tr>
437 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_obj" class="form_item" id="dei_s_approp_obj">
 438 
                        <tr>
438 
                    <%=DrawItemResult( rsQry("dei_s_approp_obj") )%>
 439 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>
439 
                </select></td>
 440 
                           <td valign="top" bgcolor="#FFFFFF">
440 
                <td bgcolor="#FFFFFF" class="form_item">
 441 
                              <select name="mnt_s_no_dead_code" class="form_item" id="mnt_s_no_dead_code">
441 
                  <textarea name="dei_c_approp_obj" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_obj")%></textarea></td>
 442 
                                 <%=DrawItemResult( rsQry("mnt_s_no_dead_code") )%>
442 
              </tr>
 443 
                              </select>
443 
              <tr>
 444 
                           </td>
444 
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>
 445 
                           <td bgcolor="#FFFFFF" class="form_item">
445 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_err_msg" class="form_item" id="dei_s_approp_err_msg">
 446 
                           <textarea name="mnt_c_no_dead_code" cols="60" rows="3" class="form_item"><%=rsQry("mnt_c_no_dead_code")%></textarea></td>
446 
                    <%=DrawItemResult( rsQry("dei_s_approp_err_msg") )%>
 447 
                        </tr>
447 
                </select></td>
 448 
                     </table>
448 
                <td bgcolor="#FFFFFF" class="form_item">
 449 
                     <br>
449 
                  <textarea name="dei_c_approp_err_msg" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_err_msg")%></textarea></td>
 450 
                     <br>
450 
              </tr>
 451 
                     <table width="100%"  border="0" cellspacing="1" cellpadding="4">
451 
              <tr>
 452 
                        <tr align="center">
452 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>
 453 
                           <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td>
453 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_framew_comp" class="form_item" id="dei_s_std_framew_comp">
 454 
                        </tr>
454 
                    <%=DrawItemResult( rsQry("dei_s_std_framew_comp") )%>
 455 
                        <tr>
455 
                </select></td>
 456 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
456 
                <td bgcolor="#FFFFFF" class="form_item">
 457 
                           <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
457 
                  <textarea name="dei_c_std_framew_comp" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_framew_comp")%></textarea></td>
 458 
                           <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
458 
              </tr>
 459 
                        </tr>
459 
              <tr>
 460 
                        <tr>
460 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>
 461 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>
461 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_logging" class="form_item" id="dei_s_approp_logging">
 462 
                           <td valign="top" bgcolor="#FFFFFF">
462 
                    <%=DrawItemResult( rsQry("dei_s_approp_logging") )%>
 463 
                              <select name="dei_s_std_des_patt" class="form_item" id="dei_s_std_des_patt">
463 
                </select></td>
 464 
                                 <%=DrawItemResult( rsQry("dei_s_std_des_patt") )%>
464 
                <td bgcolor="#FFFFFF" class="form_item">
 465 
                              </select>
465 
                  <textarea name="dei_c_approp_logging" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_logging")%></textarea></td>
 466 
                           </td>
466 
              </tr>
 467 
                           <td bgcolor="#FFFFFF" class="form_item">
- 
 
 468 
                           <textarea name="dei_c_std_des_patt" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_des_patt")%></textarea></td>
- 
 
 469 
                        </tr>
- 
 
 470 
                        <tr>
- 
 
 471 
                           <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>
- 
 
 472 
                           <td valign="top" bgcolor="#FFFFFF">
- 
 
 473 
                              <select name="dei_s_approp_algor" class="form_item" id="dei_s_approp_algor">
- 
 
 474 
                                 <%=DrawItemResult( rsQry("dei_s_approp_algor") )%>
- 
 
 475 
                              </select>
- 
 
 476 
                           </td>
- 
 
 477 
                           <td bgcolor="#FFFFFF" class="form_item">
- 
 
 478 
                           <textarea name="dei_c_approp_algor" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_algor")%></textarea></td>
- 
 
 479 
                        </tr>
- 
 
 480 
                        <tr>
- 
 
 481 
                           <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>
- 
 
 482 
                           <td valign="top" bgcolor="#FFFFFF">
- 
 
 483 
                              <select name="dei_s_approp_obj" class="form_item" id="dei_s_approp_obj">
- 
 
 484 
                                 <%=DrawItemResult( rsQry("dei_s_approp_obj") )%>
- 
 
 485 
                              </select>
- 
 
 486 
                           </td>
- 
 
 487 
                           <td bgcolor="#FFFFFF" class="form_item">
- 
 
 488 
                           <textarea name="dei_c_approp_obj" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_obj")%></textarea></td>
- 
 
 489 
                        </tr>
- 
 
 490 
                        <tr>
- 
 
 491 
                           <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>
- 
 
 492 
                           <td valign="top" bgcolor="#FFFFFF">
- 
 
 493 
                              <select name="dei_s_approp_err_msg" class="form_item" id="dei_s_approp_err_msg">
- 
 
 494 
                                 <%=DrawItemResult( rsQry("dei_s_approp_err_msg") )%>
- 
 
 495 
                              </select>
- 
 
 496 
                           </td>
- 
 
 497 
                           <td bgcolor="#FFFFFF" class="form_item">
- 
 
 498 
                           <textarea name="dei_c_approp_err_msg" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_err_msg")%></textarea></td>
- 
 
 499 
                        </tr>
- 
 
 500 
                        <tr>
- 
 
 501 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>
- 
 
 502 
                           <td valign="top" bgcolor="#FFFFFF">
- 
 
 503 
                              <select name="dei_s_std_framew_comp" class="form_item" id="dei_s_std_framew_comp">
- 
 
 504 
                                 <%=DrawItemResult( rsQry("dei_s_std_framew_comp") )%>
- 
 
 505 
                              </select>
- 
 
 506 
                           </td>
- 
 
 507 
                           <td bgcolor="#FFFFFF" class="form_item">
- 
 
 508 
                           <textarea name="dei_c_std_framew_comp" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_std_framew_comp")%></textarea></td>
- 
 
 509 
                        </tr>
- 
 
 510 
                        <tr>
- 
 
 511 
                           <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>
- 
 
 512 
                           <td valign="top" bgcolor="#FFFFFF">
- 
 
 513 
                              <select name="dei_s_approp_logging" class="form_item" id="dei_s_approp_logging">
- 
 
 514 
                                 <%=DrawItemResult( rsQry("dei_s_approp_logging") )%>
- 
 
 515 
                              </select>
- 
 
 516 
                           </td>
- 
 
 517 
                           <td bgcolor="#FFFFFF" class="form_item">
- 
 
 518 
                           <textarea name="dei_c_approp_logging" cols="60" rows="3" class="form_item"><%=rsQry("dei_c_approp_logging")%></textarea></td>
- 
 
 519 
                        </tr>
- 
 
 520 
                     </table>
- 
 
 521 
                     <br>
- 
 
 522 
                     <br>
- 
 
 523 
                  </td>
- 
 
 524 
               </tr>
467 
            </table>
 525 
            </table>
468 
			<br>
 - 
 
469 
			<br></td>
 - 
 
470 
          </tr>
 526 
         </td>
471 
        </table></td>
 - 
 
472 
    </tr>
 527 
      </tr>
473 
    <tr>
 528 
      <tr>
474 
      <td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
 529 
         <td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
475 
      <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right">
 530 
         <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right">
476 
	  <input type="submit" name="btn" value="Save" class="form_btn">
 531 
            <input type="submit" name="btn" value="Save" class="form_btn">
477 
	  <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
 532 
            <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
478 
	  </td>
 533 
         </td>
479 
    </tr>
 534 
      </tr>
480 
  </table>
 535 
   </table>
481 
  <input type="hidden" name="action" value="true">
 536 
   <input type="hidden" name="action" value="true">
482 
  <input type="hidden" name="pv_id" value="<%=parPv_id%>">
 537 
   <input type="hidden" name="pv_id" value="<%=parPv_id%>">
483 
  <input type="hidden" name="rtag_id" value="<%=parRtag_id%>">
 538 
   <input type="hidden" name="rtag_id" value="<%=parRtag_id%>">
484 
</form>
539 
</form>
485 
</body>
 540 
</body>
486 
</html>
 541 
</html>
487 
<%rsQry.Close
 542 
<%rsQry.Close
488 
Set rsQry = Nothing%>
 543 
Set rsQry = Nothing%>
489 
 
 544 
 
490 
 
 545 
 
491 
<!-- DESTRUCTOR ------->
 546 
<!-- DESTRUCTOR ------->
492 
<!--#include file="common/destructor.asp"-->
 - 
 
493 

            547
            
<!--#include file="common/destructor.asp"-->

          

          

            -
            
 

            548