WebSVN – DevTools – Diff – /ManagerSuite/Release_Manager/trunk/_wform_code_review.asp



%>
<%
'------------ Action Requirements -------------------
'Process submition
If CBool(Request("action")) AND  objAccessControl.UserLogedIn  Then
 
   Call UpdateCodeReview ( parPv_id )
   Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
   'Call CloseWindow
 
End If

            <td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">&nbsp;&nbsp;&nbsp;Time Spent</td>
            <td width="100%" bgcolor="#FFFFFF" class="form_item"><%=rsQry("time_spent")%> hrs </td>
           </tr>
           <tr>
            <td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_reason") )))%></td>
           </tr>
           <tr>
            <td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_domain_expert") )))%></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_language_expert") )))%></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_peer_developer") )))%></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_author") )))%></td>
           </tr>
           <tr>
                <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
                <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("files_reviewed") )))%></td>
             </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" disabled class="form_item" id="review_results">
                  <%=DecodeOverallResult( rsQry("review_results") )%>
                </select></td>
           </tr>
           <tr>
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("issues_raised") )))%></td>
           </tr>
           <tr>
             <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
             <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_comments") )))%></td>
             </tr>
         </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">

              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>
                <td valign="top" bgcolor="#FFFFFF"><select name="fnc_s_meets_functionality" disabled class="form_item" id="fnc_s_meets_functionality">
                  <%=DecodeItemResult( rsQry("fnc_s_meets_functionality") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("fnc_c_meets_functionality") )))%></td>
              </tr>
            </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">

              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_bound_cond_handled" disabled class="form_item" id="rbs_s_bound_cond_handled">
                    <%=DecodeItemResult( rsQry("rbs_s_bound_cond_handled") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_bound_cond_handled") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" disabled class="form_item" id="rbs_s_class_interf_precond">
                  <%=DecodeItemResult( rsQry("rbs_s_class_interf_precond") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_class_interf_precond") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" disabled class="form_item" id="rbs_s_no_unitialised_date">
                  <%=DecodeItemResult( rsQry("rbs_s_no_unitialised_date") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_no_unitialised_date") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" disabled class="form_item" id="rbs_s_excep_handing">
                  <%=DecodeItemResult( rsQry("rbs_s_excep_handing") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_excep_handing") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" disabled class="form_item" id="rbs_s_resource_mng">
                  <%=DecodeItemResult( rsQry("rbs_s_resource_mng") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_resource_mng") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" disabled class="form_item" id="rbs_s_trans_complet">
                  <%=DecodeItemResult( rsQry("rbs_s_trans_complet") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_trans_complet") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" disabled class="form_item" id="rbs_s_threadsafety">
                  <%=DecodeItemResult( rsQry("rbs_s_threadsafety") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_threadsafety") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" disabled class="form_item" id="rbs_s_ret_vals">
                  <%=DecodeItemResult( rsQry("rbs_s_ret_vals") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_ret_vals") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" disabled class="form_item" id="rbs_s_corr_err_handling">
                  <%=DecodeItemResult( rsQry("rbs_s_corr_err_handling") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_corr_err_handling") )))%></td>
              </tr>
           <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" disabled class="form_item" id="rbs_s_sql_std">
                  <%=DecodeItemResult( rsQry("rbs_s_sql_std") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_sql_std") )))%></td>
              </tr>
            </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">

              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ext_ref" disabled class="form_item" id="mnt_s_ext_ref">
                    <%=DecodeItemResult( rsQry("mnt_s_ext_ref") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ext_ref") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_class_size" disabled class="form_item" id="mnt_s_class_size">
                    <%=DecodeItemResult( rsQry("mnt_s_class_size") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_class_size") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_method_size" disabled class="form_item" id="mnt_s_method_size">
                    <%=DecodeItemResult( rsQry("mnt_s_method_size") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_method_size") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_approp_comm" disabled class="form_item" id="mnt_s_approp_comm">
                    <%=DecodeItemResult( rsQry("mnt_s_approp_comm") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_approp_comm") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ident_name_std" disabled class="form_item" id="mnt_s_ident_name_std">
                    <%=DecodeItemResult( rsQry("mnt_s_ident_name_std") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ident_name_std") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_switch_have_defaults" disabled class="form_item" id="mnt_s_switch_have_defaults">
                    <%=DecodeItemResult( rsQry("mnt_s_switch_have_defaults") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_switch_have_defaults") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except 1, 0, 1</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_lit_num" disabled class="form_item" id="mnt_s_no_lit_num">
                    <%=DecodeItemResult( rsQry("mnt_s_no_lit_num") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_lit_num") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_dead_code" disabled class="form_item" id="mnt_s_no_dead_code">
                    <%=DecodeItemResult( rsQry("mnt_s_no_dead_code") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_dead_code") )))%></td>
              </tr>
            </table>
         <br>
         <br>
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">

              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_des_patt" disabled class="form_item" id="dei_s_std_des_patt">
                    <%=DecodeItemResult( rsQry("dei_s_std_des_patt") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_des_patt") )))%></td>
              </tr>
              <tr>
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_algor" disabled class="form_item" id="dei_s_approp_algor">
                    <%=DecodeItemResult( rsQry("dei_s_approp_algor") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_algor") )))%></td>
              </tr>
              <tr>
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_obj" disabled class="form_item" id="dei_s_approp_obj">
                    <%=DecodeItemResult( rsQry("dei_s_approp_obj") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_obj") )))%></td>
              </tr>
              <tr>
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_err_msg" disabled class="form_item" id="dei_s_approp_err_msg">
                    <%=DecodeItemResult( rsQry("dei_s_approp_err_msg") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_err_msg") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_framew_comp" disabled class="form_item" id="dei_s_std_framew_comp">
                    <%=DecodeItemResult( rsQry("dei_s_std_framew_comp") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_framew_comp") )))%></td>
              </tr>
              <tr>
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_logging" disabled class="form_item" id="dei_s_approp_logging">
                    <%=DecodeItemResult( rsQry("dei_s_approp_logging") )%>
                </select></td>
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_logging") )))%></td>
              </tr>
            </table>
         <br>
         <br></td>
          </tr>

Rev 129	Rev 161
Line 111...	Line 111...
111	`%>`	111	`%>`
112	`<%`	112	`<%`
113	`'------------ Action Requirements -------------------`	113	`'------------ Action Requirements -------------------`
114	`'Process submition`	114	`'Process submition`
115	`If CBool(Request("action")) AND objAccessControl.UserLogedIn Then`	115	`If CBool(Request("action")) AND objAccessControl.UserLogedIn Then`
-		116
116	`Call UpdateCodeReview ( parPv_id )`	117	`Call UpdateCodeReview ( parPv_id )`
117	`Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )`	118	`Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )`
118	`'Call CloseWindow`	119	`'Call CloseWindow`
119		120
120	`End If`	121	`End If`
Line 169...	Line 170...
169	`<td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">   Time Spent</td>`	170	`<td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">   Time Spent</td>`
170	`<td width="100%" bgcolor="#FFFFFF" class="form_item"><%=rsQry("time_spent")%> hrs </td>`	171	`<td width="100%" bgcolor="#FFFFFF" class="form_item"><%=rsQry("time_spent")%> hrs </td>`
171	`</tr>`	172	`</tr>`
172	`<tr>`	173	`<tr>`
173	`<td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>`	174	`<td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>`
174	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("review_reason") ))%></td>`	175	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_reason") )))%></td>`
175	`</tr>`	176	`</tr>`
176	`<tr>`	177	`<tr>`
177	`<td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>`	178	`<td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>`
178	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>`	179	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>`
179	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_domain_expert") ))%></td>`	180	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_domain_expert") )))%></td>`
180	`</tr>`	181	`</tr>`
181	`<tr>`	182	`<tr>`
182	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>`	183	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>`
183	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_language_expert") ))%></td>`	184	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_language_expert") )))%></td>`
184	`</tr>`	185	`</tr>`
185	`<tr>`	186	`<tr>`
186	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>`	187	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>`
187	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_peer_developer") ))%></td>`	188	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_peer_developer") )))%></td>`
188	`</tr>`	189	`</tr>`
189	`<tr>`	190	`<tr>`
190	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>`	191	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>`
191	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_author") ))%></td>`	192	`<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_author") )))%></td>`
192	`</tr>`	193	`</tr>`
193	`<tr>`	194	`<tr>`
194	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>`	195	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>`
195	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("files_reviewed") ))%></td>`	196	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("files_reviewed") )))%></td>`
196	`</tr>`	197	`</tr>`
197	`<tr>`	198	`<tr>`
198	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>`	199	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>`
199	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" disabled class="form_item" id="review_results">`	200	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" disabled class="form_item" id="review_results">`
200	`<%=DecodeOverallResult( rsQry("review_results") )%>`	201	`<%=DecodeOverallResult( rsQry("review_results") )%>`
201	`</select></td>`	202	`</select></td>`
202	`</tr>`	203	`</tr>`
203	`<tr>`	204	`<tr>`
204	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>`	205	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>`
205	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("issues_raised") ))%></td>`	206	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("issues_raised") )))%></td>`
206	`</tr>`	207	`</tr>`
207	`<tr>`	208	`<tr>`
208	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>`	209	`<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>`
209	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("review_comments") ))%></td>`	210	`<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_comments") )))%></td>`
210	`</tr>`	211	`</tr>`
211	`</table>`	212	`</table>`
212	`<br>`	213	`<br>`
213	`<br>`	214	`<br>`
214	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`	215	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`
Line 223...	Line 224...
223	`<tr>`	224	`<tr>`
224	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>`	225	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>`
225	`<td valign="top" bgcolor="#FFFFFF"><select name="fnc_s_meets_functionality" disabled class="form_item" id="fnc_s_meets_functionality">`	226	`<td valign="top" bgcolor="#FFFFFF"><select name="fnc_s_meets_functionality" disabled class="form_item" id="fnc_s_meets_functionality">`
226	`<%=DecodeItemResult( rsQry("fnc_s_meets_functionality") )%>`	227	`<%=DecodeItemResult( rsQry("fnc_s_meets_functionality") )%>`
227	`</select></td>`	228	`</select></td>`
228	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("fnc_c_meets_functionality") ))%></td>`	229	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("fnc_c_meets_functionality") )))%></td>`
229	`</tr>`	230	`</tr>`
230	`</table>`	231	`</table>`
231	`<br>`	232	`<br>`
232	`<br>`	233	`<br>`
233	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`	234	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`
Line 242...	Line 243...
242	`<tr>`	243	`<tr>`
243	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>`	244	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>`
244	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_bound_cond_handled" disabled class="form_item" id="rbs_s_bound_cond_handled">`	245	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_bound_cond_handled" disabled class="form_item" id="rbs_s_bound_cond_handled">`
245	`<%=DecodeItemResult( rsQry("rbs_s_bound_cond_handled") )%>`	246	`<%=DecodeItemResult( rsQry("rbs_s_bound_cond_handled") )%>`
246	`</select></td>`	247	`</select></td>`
247	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_bound_cond_handled") ))%></td>`	248	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_bound_cond_handled") )))%></td>`
248	`</tr>`	249	`</tr>`
249	`<tr>`	250	`<tr>`
250	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>`	251	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>`
251	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" disabled class="form_item" id="rbs_s_class_interf_precond">`	252	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" disabled class="form_item" id="rbs_s_class_interf_precond">`
252	`<%=DecodeItemResult( rsQry("rbs_s_class_interf_precond") )%>`	253	`<%=DecodeItemResult( rsQry("rbs_s_class_interf_precond") )%>`
253	`</select></td>`	254	`</select></td>`
254	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_class_interf_precond") ))%></td>`	255	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_class_interf_precond") )))%></td>`
255	`</tr>`	256	`</tr>`
256	`<tr>`	257	`<tr>`
257	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>`	258	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>`
258	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" disabled class="form_item" id="rbs_s_no_unitialised_date">`	259	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" disabled class="form_item" id="rbs_s_no_unitialised_date">`
259	`<%=DecodeItemResult( rsQry("rbs_s_no_unitialised_date") )%>`	260	`<%=DecodeItemResult( rsQry("rbs_s_no_unitialised_date") )%>`
260	`</select></td>`	261	`</select></td>`
261	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_no_unitialised_date") ))%></td>`	262	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_no_unitialised_date") )))%></td>`
262	`</tr>`	263	`</tr>`
263	`<tr>`	264	`<tr>`
264	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>`	265	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>`
265	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" disabled class="form_item" id="rbs_s_excep_handing">`	266	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" disabled class="form_item" id="rbs_s_excep_handing">`
266	`<%=DecodeItemResult( rsQry("rbs_s_excep_handing") )%>`	267	`<%=DecodeItemResult( rsQry("rbs_s_excep_handing") )%>`
267	`</select></td>`	268	`</select></td>`
268	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_excep_handing") ))%></td>`	269	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_excep_handing") )))%></td>`
269	`</tr>`	270	`</tr>`
270	`<tr>`	271	`<tr>`
271	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>`	272	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>`
272	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" disabled class="form_item" id="rbs_s_resource_mng">`	273	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" disabled class="form_item" id="rbs_s_resource_mng">`
273	`<%=DecodeItemResult( rsQry("rbs_s_resource_mng") )%>`	274	`<%=DecodeItemResult( rsQry("rbs_s_resource_mng") )%>`
274	`</select></td>`	275	`</select></td>`
275	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_resource_mng") ))%></td>`	276	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_resource_mng") )))%></td>`
276	`</tr>`	277	`</tr>`
277	`<tr>`	278	`<tr>`
278	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>`	279	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>`
279	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" disabled class="form_item" id="rbs_s_trans_complet">`	280	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" disabled class="form_item" id="rbs_s_trans_complet">`
280	`<%=DecodeItemResult( rsQry("rbs_s_trans_complet") )%>`	281	`<%=DecodeItemResult( rsQry("rbs_s_trans_complet") )%>`
281	`</select></td>`	282	`</select></td>`
282	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_trans_complet") ))%></td>`	283	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_trans_complet") )))%></td>`
283	`</tr>`	284	`</tr>`
284	`<tr>`	285	`<tr>`
285	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>`	286	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>`
286	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" disabled class="form_item" id="rbs_s_threadsafety">`	287	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" disabled class="form_item" id="rbs_s_threadsafety">`
287	`<%=DecodeItemResult( rsQry("rbs_s_threadsafety") )%>`	288	`<%=DecodeItemResult( rsQry("rbs_s_threadsafety") )%>`
288	`</select></td>`	289	`</select></td>`
289	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_threadsafety") ))%></td>`	290	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_threadsafety") )))%></td>`
290	`</tr>`	291	`</tr>`
291	`<tr>`	292	`<tr>`
292	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>`	293	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>`
293	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" disabled class="form_item" id="rbs_s_ret_vals">`	294	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" disabled class="form_item" id="rbs_s_ret_vals">`
294	`<%=DecodeItemResult( rsQry("rbs_s_ret_vals") )%>`	295	`<%=DecodeItemResult( rsQry("rbs_s_ret_vals") )%>`
295	`</select></td>`	296	`</select></td>`
296	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_ret_vals") ))%></td>`	297	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_ret_vals") )))%></td>`
297	`</tr>`	298	`</tr>`
298	`<tr>`	299	`<tr>`
299	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>`	300	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>`
300	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" disabled class="form_item" id="rbs_s_corr_err_handling">`	301	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" disabled class="form_item" id="rbs_s_corr_err_handling">`
301	`<%=DecodeItemResult( rsQry("rbs_s_corr_err_handling") )%>`	302	`<%=DecodeItemResult( rsQry("rbs_s_corr_err_handling") )%>`
302	`</select></td>`	303	`</select></td>`
303	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_corr_err_handling") ))%></td>`	304	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_corr_err_handling") )))%></td>`
304	`</tr>`	305	`</tr>`
305	`<tr>`	306	`<tr>`
306	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>`	307	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>`
307	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" disabled class="form_item" id="rbs_s_sql_std">`	308	`<td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" disabled class="form_item" id="rbs_s_sql_std">`
308	`<%=DecodeItemResult( rsQry("rbs_s_sql_std") )%>`	309	`<%=DecodeItemResult( rsQry("rbs_s_sql_std") )%>`
309	`</select></td>`	310	`</select></td>`
310	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_sql_std") ))%></td>`	311	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_sql_std") )))%></td>`
311	`</tr>`	312	`</tr>`
312	`</table>`	313	`</table>`
313	`<br>`	314	`<br>`
314	`<br>`	315	`<br>`
315	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`	316	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`
Line 324...	Line 325...
324	`<tr>`	325	`<tr>`
325	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>`	326	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>`
326	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ext_ref" disabled class="form_item" id="mnt_s_ext_ref">`	327	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ext_ref" disabled class="form_item" id="mnt_s_ext_ref">`
327	`<%=DecodeItemResult( rsQry("mnt_s_ext_ref") )%>`	328	`<%=DecodeItemResult( rsQry("mnt_s_ext_ref") )%>`
328	`</select></td>`	329	`</select></td>`
329	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_ext_ref") ))%></td>`	330	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ext_ref") )))%></td>`
330	`</tr>`	331	`</tr>`
331	`<tr>`	332	`<tr>`
332	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>`	333	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>`
333	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_class_size" disabled class="form_item" id="mnt_s_class_size">`	334	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_class_size" disabled class="form_item" id="mnt_s_class_size">`
334	`<%=DecodeItemResult( rsQry("mnt_s_class_size") )%>`	335	`<%=DecodeItemResult( rsQry("mnt_s_class_size") )%>`
335	`</select></td>`	336	`</select></td>`
336	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_class_size") ))%></td>`	337	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_class_size") )))%></td>`
337	`</tr>`	338	`</tr>`
338	`<tr>`	339	`<tr>`
339	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>`	340	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>`
340	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_method_size" disabled class="form_item" id="mnt_s_method_size">`	341	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_method_size" disabled class="form_item" id="mnt_s_method_size">`
341	`<%=DecodeItemResult( rsQry("mnt_s_method_size") )%>`	342	`<%=DecodeItemResult( rsQry("mnt_s_method_size") )%>`
342	`</select></td>`	343	`</select></td>`
343	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_method_size") ))%></td>`	344	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_method_size") )))%></td>`
344	`</tr>`	345	`</tr>`
345	`<tr>`	346	`<tr>`
346	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>`	347	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>`
347	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_approp_comm" disabled class="form_item" id="mnt_s_approp_comm">`	348	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_approp_comm" disabled class="form_item" id="mnt_s_approp_comm">`
348	`<%=DecodeItemResult( rsQry("mnt_s_approp_comm") )%>`	349	`<%=DecodeItemResult( rsQry("mnt_s_approp_comm") )%>`
349	`</select></td>`	350	`</select></td>`
350	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_approp_comm") ))%></td>`	351	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_approp_comm") )))%></td>`
351	`</tr>`	352	`</tr>`
352	`<tr>`	353	`<tr>`
353	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>`	354	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>`
354	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ident_name_std" disabled class="form_item" id="mnt_s_ident_name_std">`	355	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ident_name_std" disabled class="form_item" id="mnt_s_ident_name_std">`
355	`<%=DecodeItemResult( rsQry("mnt_s_ident_name_std") )%>`	356	`<%=DecodeItemResult( rsQry("mnt_s_ident_name_std") )%>`
356	`</select></td>`	357	`</select></td>`
357	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_ident_name_std") ))%></td>`	358	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ident_name_std") )))%></td>`
358	`</tr>`	359	`</tr>`
359	`<tr>`	360	`<tr>`
360	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>`	361	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>`
361	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_switch_have_defaults" disabled class="form_item" id="mnt_s_switch_have_defaults">`	362	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_switch_have_defaults" disabled class="form_item" id="mnt_s_switch_have_defaults">`
362	`<%=DecodeItemResult( rsQry("mnt_s_switch_have_defaults") )%>`	363	`<%=DecodeItemResult( rsQry("mnt_s_switch_have_defaults") )%>`
363	`</select></td>`	364	`</select></td>`
364	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_switch_have_defaults") ))%></td>`	365	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_switch_have_defaults") )))%></td>`
365	`</tr>`	366	`</tr>`
366	`<tr>`	367	`<tr>`
367	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except 1, 0, 1</td>`	368	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except 1, 0, 1</td>`
368	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_lit_num" disabled class="form_item" id="mnt_s_no_lit_num">`	369	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_lit_num" disabled class="form_item" id="mnt_s_no_lit_num">`
369	`<%=DecodeItemResult( rsQry("mnt_s_no_lit_num") )%>`	370	`<%=DecodeItemResult( rsQry("mnt_s_no_lit_num") )%>`
370	`</select></td>`	371	`</select></td>`
371	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_no_lit_num") ))%></td>`	372	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_lit_num") )))%></td>`
372	`</tr>`	373	`</tr>`
373	`<tr>`	374	`<tr>`
374	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>`	375	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>`
375	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_dead_code" disabled class="form_item" id="mnt_s_no_dead_code">`	376	`<td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_dead_code" disabled class="form_item" id="mnt_s_no_dead_code">`
376	`<%=DecodeItemResult( rsQry("mnt_s_no_dead_code") )%>`	377	`<%=DecodeItemResult( rsQry("mnt_s_no_dead_code") )%>`
377	`</select></td>`	378	`</select></td>`
378	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_no_dead_code") ))%></td>`	379	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_dead_code") )))%></td>`
379	`</tr>`	380	`</tr>`
380	`</table>`	381	`</table>`
381	`<br>`	382	`<br>`
382	`<br>`	383	`<br>`
383	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`	384	`<table width="100%" border="0" cellspacing="1" cellpadding="4">`
Line 392...	Line 393...
392	`<tr>`	393	`<tr>`
393	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>`	394	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>`
394	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_des_patt" disabled class="form_item" id="dei_s_std_des_patt">`	395	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_des_patt" disabled class="form_item" id="dei_s_std_des_patt">`
395	`<%=DecodeItemResult( rsQry("dei_s_std_des_patt") )%>`	396	`<%=DecodeItemResult( rsQry("dei_s_std_des_patt") )%>`
396	`</select></td>`	397	`</select></td>`
397	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("dei_c_std_des_patt") ))%></td>`	398	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_des_patt") )))%></td>`
398	`</tr>`	399	`</tr>`
399	`<tr>`	400	`<tr>`
400	`<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>`	401	`<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>`
401	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_algor" disabled class="form_item" id="dei_s_approp_algor">`	402	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_algor" disabled class="form_item" id="dei_s_approp_algor">`
402	`<%=DecodeItemResult( rsQry("dei_s_approp_algor") )%>`	403	`<%=DecodeItemResult( rsQry("dei_s_approp_algor") )%>`
403	`</select></td>`	404	`</select></td>`
404	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("dei_c_approp_algor") ))%></td>`	405	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_algor") )))%></td>`
405	`</tr>`	406	`</tr>`
406	`<tr>`	407	`<tr>`
407	`<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>`	408	`<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>`
408	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_obj" disabled class="form_item" id="dei_s_approp_obj">`	409	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_obj" disabled class="form_item" id="dei_s_approp_obj">`
409	`<%=DecodeItemResult( rsQry("dei_s_approp_obj") )%>`	410	`<%=DecodeItemResult( rsQry("dei_s_approp_obj") )%>`
410	`</select></td>`	411	`</select></td>`
411	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("dei_c_approp_obj") ))%></td>`	412	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_obj") )))%></td>`
412	`</tr>`	413	`</tr>`
413	`<tr>`	414	`<tr>`
414	`<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>`	415	`<td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>`
415	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_err_msg" disabled class="form_item" id="dei_s_approp_err_msg">`	416	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_err_msg" disabled class="form_item" id="dei_s_approp_err_msg">`
416	`<%=DecodeItemResult( rsQry("dei_s_approp_err_msg") )%>`	417	`<%=DecodeItemResult( rsQry("dei_s_approp_err_msg") )%>`
417	`</select></td>`	418	`</select></td>`
418	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("dei_c_approp_err_msg") ))%></td>`	419	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_err_msg") )))%></td>`
419	`</tr>`	420	`</tr>`
420	`<tr>`	421	`<tr>`
421	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>`	422	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>`
422	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_framew_comp" disabled class="form_item" id="dei_s_std_framew_comp">`	423	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_framew_comp" disabled class="form_item" id="dei_s_std_framew_comp">`
423	`<%=DecodeItemResult( rsQry("dei_s_std_framew_comp") )%>`	424	`<%=DecodeItemResult( rsQry("dei_s_std_framew_comp") )%>`
424	`</select></td>`	425	`</select></td>`
425	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("dei_c_std_framew_comp") ))%></td>`	426	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_framew_comp") )))%></td>`
426	`</tr>`	427	`</tr>`
427	`<tr>`	428	`<tr>`
428	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>`	429	`<td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>`
429	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_logging" disabled class="form_item" id="dei_s_approp_logging">`	430	`<td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_logging" disabled class="form_item" id="dei_s_approp_logging">`
430	`<%=DecodeItemResult( rsQry("dei_s_approp_logging") )%>`	431	`<%=DecodeItemResult( rsQry("dei_s_approp_logging") )%>`
431	`</select></td>`	432	`</select></td>`
432	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("dei_c_approp_logging") ))%></td>`	433	`<td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_logging") )))%></td>`
433	`</tr>`	434	`</tr>`
434	`</table>`	435	`</table>`
435	`<br>`	436	`<br>`
436	`<br></td>`	437	`<br></td>`
437	`</tr>`	438	`</tr>`

Subversion Repositories DevTools

(root)/ManagerSuite/Release_Manager/trunk/_wform_code_review.asp @ 187 – Rev 129 → 161