WebSVN – DevTools – Diff – /ManagerSuite/Release_Manager/trunk/_wform_code_review.asp

 <%@LANGUAGE="VBSCRIPT"%>
 <%
 Option explicit
-Response.Expires = 0	' always load the page, dont store
+Response.Expires = 0   ' always load the page, dont store
 %>
 <%
 '=====================================================
-'					Code Review
+'               Code Review
 '=====================================================
 %>
 <!--#include file="common/conf.asp"-->
 <!--#include file="common/globals.asp"-->
 <!--#include file="common/formating.asp"-->
 '----------------------------------------------
 %>
 <%
 '-----------------------------------------------------------------------------------------------------------------------------------
 Sub GetCodeReview ( nPv_id, oRS )
-	Dim Query_String
+   Dim Query_String
-	Query_String = _
+   Query_String = _
-	" SELECT *  FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
+   " SELECT *  FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
-	Query_String = Replace( Query_String, ":PV_ID", nPv_id )
+   Query_String = Replace( Query_String, ":PV_ID", nPv_id )
-	Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
+   Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
 End Sub
 '-----------------------------------------------------------------------------------------------------------------------------------
 Function DecodeItemResult ( cCheck )
-	Select Case cCheck
+   Select Case cCheck
-		Case enumCODE_REVIEW_PASS
+      Case enumCODE_REVIEW_PASS
-			DecodeItemResult = "<option>Pass</option>"
+         DecodeItemResult = "<option>Pass</option>"
-		Case enumCODE_REVIEW_FAIL
+      Case enumCODE_REVIEW_FAIL
-			DecodeItemResult = "<option>Fail</option>"
+         DecodeItemResult = "<option>Fail</option>"
-		Case Else
+      Case Else
-			DecodeItemResult = "<option></option>"
+         DecodeItemResult = "<option></option>"
-	End Select
+   End Select
 End Function
 '-----------------------------------------------------------------------------------------------------------------------------------
 Function DecodeOverallResult ( ByVal cCheck )
-	If cCheck = "" OR IsNull(cCheck) Then cCheck = 0
+   If cCheck = "" OR IsNull(cCheck) Then cCheck = 0
-	Select Case CInt( cCheck )
+   Select Case CInt( cCheck )
-		Case enumCODE_REVIEW_ACCEPTED
+      Case enumCODE_REVIEW_ACCEPTED
-			DecodeOverallResult = "<option>Accepted</option>"
+         DecodeOverallResult = "<option>Accepted</option>"
-		Case enumCODE_REVIEW_MINOR_UPDATES
+      Case enumCODE_REVIEW_MINOR_UPDATES
-			DecodeOverallResult = "<option>Minor updates required</option>"
+         DecodeOverallResult = "<option>Minor updates required</option>"
-		Case enumCODE_REVIEW_MAJOR_REWORK
+      Case enumCODE_REVIEW_MAJOR_REWORK
-			DecodeOverallResult = "<option>Major rework required</option>"
+         DecodeOverallResult = "<option>Major rework required</option>"
-		Case Else
+      Case Else
-			DecodeOverallResult = "<option></option>"
+         DecodeOverallResult = "<option></option>"
-	End Select
+   End Select
 End Function
 '-----------------------------------------------------------------------------------------------------------------------------------
 Function ConstructSQL ( nPv_id, sQuery )
-	Dim SQLqry, arrLineSplit, arrParamSplit, line
+   Dim SQLqry, arrLineSplit, arrParamSplit, line
-	Const localPARAM_SPLIT = ":"
+   Const localPARAM_SPLIT = ":"
-	SQLqry = ReadFile( sQuery )
+   SQLqry = ReadFile( sQuery )
-	arrLineSplit = Split ( SQLqry, VBNewLine )
+   arrLineSplit = Split ( SQLqry, VBNewLine )
-	For Each line in arrLineSplit
+   For Each line in arrLineSplit
-		arrParamSplit = Split ( line, localPARAM_SPLIT )		' Split the line with ":" e.g. some_column = ':param_name:',
+      arrParamSplit = Split ( line, localPARAM_SPLIT )      ' Split the line with ":" e.g. some_column = ':param_name:',
-		If Ubound( arrParamSplit ) > 0 Then
+      If Ubound( arrParamSplit ) > 0 Then
-			SQLqry = Replace( SQLqry, localPARAM_SPLIT  & arrParamSplit( 1 ) & localPARAM_SPLIT, Replace( Request( arrParamSplit( 1 ) ), "'", "''") )
+         SQLqry = Replace( SQLqry, localPARAM_SPLIT  & arrParamSplit( 1 ) & localPARAM_SPLIT, Replace( Request( arrParamSplit( 1 ) ), "'", "''") )
-		End If
+      End If
-	Next
+   Next
-	ConstructSQL = SQLqry
+   ConstructSQL = SQLqry
 End Function
 '-----------------------------------------------------------------------------------------------------------------------------------
 Sub UpdateCodeReview ( nPv_id )
-	Dim SQLstr
+   Dim SQLstr
-	SQLstr  = ConstructSQL ( nPv_id, rootPath & "queries\update_code_review.sql" )
+   SQLstr  = ConstructSQL ( nPv_id, rootPath & "queries\update_code_review.sql" )
-	OraSession.BeginTrans
-	OraDatabase.ExecuteSQL  SQLstr
+   objEH.TryORA ( OraSession )
-	OraSession.CommitTrans
+   On Error Resume Next
+   OraDatabase.ExecuteSQL  SQLstr
+   objEH.CatchORA ( OraSession )
 End Sub
 '-----------------------------------------------------------------------------------------------------------------------------------
 %>
 <%
 '------------ Action Requirements -------------------
 'Process submition
 If CBool(Request("action")) AND  objAccessControl.UserLogedIn  Then
-	Call UpdateCodeReview ( parPv_id )
+   Call UpdateCodeReview ( parPv_id )
-	Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
+   Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
-	'Call CloseWindow
+   'Call CloseWindow
 End If
 Call Get_Pkg_Short_Info( parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, isDLocked )
 Call GetCodeReview ( parPv_id, rsQry )
 <form action="_wform_update_code_review.asp" method="post" name="codereview">
   <table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
     <tr>
       <td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
       <td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl">&nbsp;Code Review for <%=pkgName%>&nbsp;<%=pkgVersion%> </td>
-	  <td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
+     <td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
-		<input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
+      <input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
-		<input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
+      <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
       </td>
       <td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td>
     </tr>
     <tr>
       <td height="100%" width="1%">&nbsp;</td>
         <br>
         <table width="100%"  border="0" cellspacing="0" cellpadding="0">
           <tr>
             <td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
             <td width="100%">
-			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
+         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
-			  <tr align="center">
+           <tr align="center">
                 <td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td>
                 </tr>
-			  <tr>
+           <tr>
-				<td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
+            <td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
-				<td width="1%" nowrap bgcolor="#FFFFFF" class="form_item"><%=EuroDate ( rsQry("date_of_review") )%>&nbsp;&nbsp;&nbsp;</td>
+            <td width="1%" nowrap bgcolor="#FFFFFF" class="form_item"><%=EuroDate ( rsQry("date_of_review") )%>&nbsp;&nbsp;&nbsp;</td>
-				<td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">&nbsp;&nbsp;&nbsp;Time Spent</td>
+            <td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">&nbsp;&nbsp;&nbsp;Time Spent</td>
-				<td width="100%" bgcolor="#FFFFFF" class="form_item"><%=rsQry("time_spent")%> hrs </td>
+            <td width="100%" bgcolor="#FFFFFF" class="form_item"><%=rsQry("time_spent")%> hrs </td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
-				<td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
+            <td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
-				<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("review_reason") ))%></td>
+            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("review_reason") ))%></td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
-				<td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
+            <td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
-				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
+            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
-				<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_domain_expert") ))%></td>
+            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_domain_expert") ))%></td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
-				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
+            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
-				<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_language_expert") ))%></td>
+            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_language_expert") ))%></td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
-				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
+            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
-				<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_peer_developer") ))%></td>
+            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_peer_developer") ))%></td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
-				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
+            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
-				<td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_author") ))%></td>
+            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rteam_author") ))%></td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
                 <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
                 <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("files_reviewed") ))%></td>
-			    </tr>
+             </tr>
-			  <tr>
+           <tr>
-				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
+            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
-				<td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" disabled class="form_item" id="review_results">
+            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" disabled class="form_item" id="review_results">
                   <%=DecodeOverallResult( rsQry("review_results") )%>
                 </select></td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
-				<td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
+            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
-				<td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("issues_raised") ))%></td>
+            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("issues_raised") ))%></td>
-			  </tr>
+           </tr>
-			  <tr>
+           <tr>
-			    <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
+             <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
-			    <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("review_comments") ))%></td>
+             <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("review_comments") ))%></td>
-			    </tr>
+             </tr>
-			</table>
+         </table>
-			<br>
+         <br>
-			<br>
+         <br>
-			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
+         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
               <tr align="center">
                 <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td>
                 </tr>
               <tr>
                 <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                   <%=DecodeItemResult( rsQry("fnc_s_meets_functionality") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("fnc_c_meets_functionality") ))%></td>
               </tr>
             </table>
-			<br>
+         <br>
-			<br>
+         <br>
-			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
+         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
               <tr align="center">
                 <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td>
               </tr>
               <tr>
                 <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" disabled class="form_item" id="rbs_s_class_interf_precond">
                   <%=DecodeItemResult( rsQry("rbs_s_class_interf_precond") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_class_interf_precond") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" disabled class="form_item" id="rbs_s_no_unitialised_date">
                   <%=DecodeItemResult( rsQry("rbs_s_no_unitialised_date") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_no_unitialised_date") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" disabled class="form_item" id="rbs_s_excep_handing">
                   <%=DecodeItemResult( rsQry("rbs_s_excep_handing") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_excep_handing") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" disabled class="form_item" id="rbs_s_resource_mng">
                   <%=DecodeItemResult( rsQry("rbs_s_resource_mng") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_resource_mng") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" disabled class="form_item" id="rbs_s_trans_complet">
                   <%=DecodeItemResult( rsQry("rbs_s_trans_complet") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_trans_complet") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" disabled class="form_item" id="rbs_s_threadsafety">
                   <%=DecodeItemResult( rsQry("rbs_s_threadsafety") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_threadsafety") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" disabled class="form_item" id="rbs_s_ret_vals">
                   <%=DecodeItemResult( rsQry("rbs_s_ret_vals") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_ret_vals") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" disabled class="form_item" id="rbs_s_corr_err_handling">
                   <%=DecodeItemResult( rsQry("rbs_s_corr_err_handling") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_corr_err_handling") ))%></td>
               </tr>
-			  <tr>
+           <tr>
                 <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
                 <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" disabled class="form_item" id="rbs_s_sql_std">
                   <%=DecodeItemResult( rsQry("rbs_s_sql_std") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("rbs_c_sql_std") ))%></td>
               </tr>
             </table>
-			<br>
+         <br>
-			<br>
+         <br>
-			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
+         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
               <tr align="center">
                 <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td>
               </tr>
               <tr>
                 <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                     <%=DecodeItemResult( rsQry("mnt_s_no_dead_code") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("mnt_c_no_dead_code") ))%></td>
               </tr>
             </table>
-			<br>
+         <br>
-			<br>
+         <br>
-			<table width="100%"  border="0" cellspacing="1" cellpadding="4">
+         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
               <tr align="center">
                 <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td>
               </tr>
               <tr>
                 <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
                     <%=DecodeItemResult( rsQry("dei_s_approp_logging") )%>
                 </select></td>
                 <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( rsQry("dei_c_approp_logging") ))%></td>
               </tr>
             </table>
-			<br>
+         <br>
-			<br></td>
+         <br></td>
           </tr>
         </table></td>
     </tr>
     <tr>
       <td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
       <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right">
-	  <input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
+     <input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
-	  <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
+     <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
-	  </td>
+     </td>
     </tr>
   </table>
   <input type="hidden" name="pv_id" value="<%=parPv_id%>">
   <input type="hidden" name="rtag_id" value="<%=parRtag_id%>">
 </form>

Subversion Repositories DevTools

(root)/ManagerSuite/Release_Manager/trunk/_wform_code_review.asp @ 157 – Rev 119 → 129