Subversion Repositories DevTools

Rev

Details | Last modification | View Log | RSS feed

Rev Author Line No. Line
119 ghuddy 1 
<%@LANGUAGE="VBSCRIPT"%>
2 
<%
3 
Option explicit
129 ghuddy 4 
Response.Expires = 0   ' always load the page, dont store
119 ghuddy 5 
%>
6 
<%
7 
'=====================================================
129 ghuddy 8 
'               Code Review
119 ghuddy 9 
'=====================================================
10 
%>
11 
<!--#include file="common/conf.asp"-->
12 
<!--#include file="common/globals.asp"-->
13 
<!--#include file="common/formating.asp"-->
14 
<!--#include file="common/qstr.asp"-->
15 
<!--#include file="common/common_subs.asp"-->
16 
<!--#include file="common/common_dbedit.asp"-->
17 
<!--#include file="common/_popup_window_common.asp"-->
18 
<%
19 
' Set rfile parameter. This is a return page after Login
20 
Call objPMod.StoreParameter ( "rfile", "fixed_issues.asp" )
21 
'------------ ACCESS CONTROL ------------------
22 
%>
23 
<!--#include file="_access_control_login.asp"-->
24 
<!--#include file="_access_control_general.asp"-->
25 
<!--#include file="_access_control_project.asp"-->
26 
<%
27 
'------------ Variable Definition -------------
28 
Dim parPv_id
29 
Dim rsQry
30 
Dim pkgName
31 
Dim pkgVersion
32 
Dim isDLocked
33 
Dim pageIsEditable
34 
'------------ Constants Declaration -----------
35 
'------------ Variable Init -------------------
36 
parPv_id = Request("pv_id")
37 
parRtag_id = Request("rtag_id")
38 
'----------------------------------------------
39 
%>
40 
<%
41 
'-----------------------------------------------------------------------------------------------------------------------------------
42 
Sub GetCodeReview ( nPv_id, oRS )
129 ghuddy 43 
   Dim Query_String
44 
   Query_String = _
45 
   " SELECT *  FROM CODE_REVIEWS WHERE pv_id = :PV_ID"
46 
   Query_String = Replace( Query_String, ":PV_ID", nPv_id )
119 ghuddy 47 
 
129 ghuddy 48 
   Set oRS = OraDatabase.CreateDynaset( Query_String, cint(0))
119 ghuddy 49 
End Sub
50 
'-----------------------------------------------------------------------------------------------------------------------------------
51 
Function DecodeItemResult ( cCheck )
52 
 
129 ghuddy 53 
   Select Case cCheck
54 
      Case enumCODE_REVIEW_PASS
55 
         DecodeItemResult = "<option>Pass</option>"
56 
      Case enumCODE_REVIEW_FAIL
57 
         DecodeItemResult = "<option>Fail</option>"
58 
      Case Else
59 
         DecodeItemResult = "<option></option>"
60 
   End Select
119 ghuddy 61 
 
62 
End Function
63 
'-----------------------------------------------------------------------------------------------------------------------------------
64 
Function DecodeOverallResult ( ByVal cCheck )
129 ghuddy 65 
   If cCheck = "" OR IsNull(cCheck) Then cCheck = 0
119 ghuddy 66 
 
129 ghuddy 67 
   Select Case CInt( cCheck )
68 
      Case enumCODE_REVIEW_ACCEPTED
69 
         DecodeOverallResult = "<option>Accepted</option>"
70 
      Case enumCODE_REVIEW_MINOR_UPDATES
71 
         DecodeOverallResult = "<option>Minor updates required</option>"
72 
      Case enumCODE_REVIEW_MAJOR_REWORK
73 
         DecodeOverallResult = "<option>Major rework required</option>"
74 
      Case Else
75 
         DecodeOverallResult = "<option></option>"
76 
   End Select
119 ghuddy 77 
 
78 
End Function
79 
'-----------------------------------------------------------------------------------------------------------------------------------
80 
Function ConstructSQL ( nPv_id, sQuery )
129 ghuddy 81 
   Dim SQLqry, arrLineSplit, arrParamSplit, line
82 
   Const localPARAM_SPLIT = ":"
119 ghuddy 83 
 
129 ghuddy 84 
   SQLqry = ReadFile( sQuery )
119 ghuddy 85 
 
129 ghuddy 86 
   arrLineSplit = Split ( SQLqry, VBNewLine )
119 ghuddy 87 
 
129 ghuddy 88 
   For Each line in arrLineSplit
89 
      arrParamSplit = Split ( line, localPARAM_SPLIT )      ' Split the line with ":" e.g. some_column = ':param_name:',
90 
      If Ubound( arrParamSplit ) > 0 Then
91 
         SQLqry = Replace( SQLqry, localPARAM_SPLIT  & arrParamSplit( 1 ) & localPARAM_SPLIT, Replace( Request( arrParamSplit( 1 ) ), "'", "''") )
92 
      End If
93 
   Next
119 ghuddy 94 
 
129 ghuddy 95 
   ConstructSQL = SQLqry
119 ghuddy 96 
 
97 
End Function
98 
'-----------------------------------------------------------------------------------------------------------------------------------
99 
Sub UpdateCodeReview ( nPv_id )
129 ghuddy 100 
   Dim SQLstr
101 
   SQLstr  = ConstructSQL ( nPv_id, rootPath & "queries\update_code_review.sql" )
119 ghuddy 102 
 
129 ghuddy 103 
   objEH.TryORA ( OraSession )
104 
   On Error Resume Next
119 ghuddy 105 
 
129 ghuddy 106 
   OraDatabase.ExecuteSQL  SQLstr
107 
 
108 
   objEH.CatchORA ( OraSession )
119 ghuddy 109 
End Sub
110 
'-----------------------------------------------------------------------------------------------------------------------------------
111 
%>
112 
<%
113 
'------------ Action Requirements -------------------
114 
'Process submition
115 
If CBool(Request("action")) AND  objAccessControl.UserLogedIn  Then
161 iaugusti 116 
 
129 ghuddy 117 
   Call UpdateCodeReview ( parPv_id )
118 
   Call OpenInParentWindow ("fixed_issues.asp?pv_id="& parPv_id &"&rtag_id="& parRtag_id )
119 
   'Call CloseWindow
119 ghuddy 120 
 
121 
End If
122 
 
123 
Call Get_Pkg_Short_Info( parPv_id, NULL, pkgName, pkgVersion, NULL, NULL, isDLocked )
124 
Call GetCodeReview ( parPv_id, rsQry )
125 
pageIsEditable = Is_Page_Editable ( isDLocked )
126 
%>
127 
<html>
128 
<head>
129 
<title>Release Manager</title>
130 
<meta HTTP-EQUIV="Pragma" CONTENT="no-cache">
131 
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
132 
<link rel="stylesheet" href="images/release_manager_style.css" type="text/css">
133 
<link rel="stylesheet" href="images/navigation.css" type="text/css">
134 
<script language="JavaScript" src="images/common.js"></script>
135 
<!-- TIPS -->
136 
<script language="JavaScript" src="images/tipster.js"></script>
137 
<script language="JavaScript" src="images/_help_tips.js"></script>
138 
</head>
139 
<body bgcolor="#FFFFFF" text="#000000" leftmargin="0" topmargin="0" onload="self.focus();">
140 
<!-- TIPS LAYERS -------------------------------------->
141 
<div id="formTipsLayer" style="position: absolute; z-index: 1000; visibility: hidden; left:0; top: 0; width: 10">&nbsp;</div>
142 
<!----------------------------------------------------->
143 
<form action="_wform_update_code_review.asp" method="post" name="codereview">
144 
  <table width="100%" border="0" cellspacing="0" cellpadding="2" height="100%">
145 
    <tr>
146 
      <td width="1%" background="images/lbox_bg_orange.gif"><img src="images/s_code_review_off.gif" width="21" height="23" hspace="5" border="0"></td>
147 
      <td width="1%" background="images/lbox_bg_blue.gif" nowrap class="wform_ttl">&nbsp;Code Review for <%=pkgName%>&nbsp;<%=pkgVersion%> </td>
129 ghuddy 148 
     <td width="100%" background="images/lbox_bg_blue.gif" align="right" nowrap class="wform_ttl">
149 
      <input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
150 
      <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
119 ghuddy 151 
      </td>
152 
      <td background="images/lbox_bg_blue.gif" align="right" width="1%" nowrap><img src="images/h_trsp_dot.gif" width="5" height="22"></td>
153 
    </tr>
154 
    <tr>
155 
      <td height="100%" width="1%">&nbsp;</td>
156 
      <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/bg_form_lightgray.gif">
157 
        <br>
158 
        <br>
159 
        <table width="100%"  border="0" cellspacing="0" cellpadding="0">
160 
          <tr>
161 
            <td width="1%"><img src="images/h_trsp_dot.gif" width="10" height="30"></td>
162 
            <td width="100%">
129 ghuddy 163 
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
164 
           <tr align="center">
119 ghuddy 165 
                <td colspan="4" class="form_ttl" background="images/bg_form_lightbluedark.gif">Summary</td>
166 
                </tr>
129 ghuddy 167 
           <tr>
168 
            <td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Date of Review</td>
169 
            <td width="1%" nowrap bgcolor="#FFFFFF" class="form_item"><%=EuroDate ( rsQry("date_of_review") )%>&nbsp;&nbsp;&nbsp;</td>
170 
            <td width="1%" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">&nbsp;&nbsp;&nbsp;Time Spent</td>
171 
            <td width="100%" bgcolor="#FFFFFF" class="form_item"><%=rsQry("time_spent")%> hrs </td>
172 
           </tr>
173 
           <tr>
174 
            <td align="right" valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Reason for Review</td>
161 iaugusti 175 
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_reason") )))%></td>
129 ghuddy 176 
           </tr>
177 
           <tr>
178 
            <td rowspan="4" align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Team </td>
179 
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Domain Expert </td>
161 iaugusti 180 
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_domain_expert") )))%></td>
129 ghuddy 181 
           </tr>
182 
           <tr>
183 
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Language Expert </td>
161 iaugusti 184 
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_language_expert") )))%></td>
129 ghuddy 185 
           </tr>
186 
           <tr>
187 
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Peer Developer </td>
161 iaugusti 188 
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_peer_developer") )))%></td>
129 ghuddy 189 
           </tr>
190 
           <tr>
191 
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Author</td>
161 iaugusti 192 
            <td colspan="2" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rteam_author") )))%></td>
129 ghuddy 193 
           </tr>
194 
           <tr>
119 ghuddy 195 
                <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Files Reviewed</td>
161 iaugusti 196 
                <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("files_reviewed") )))%></td>
129 ghuddy 197 
             </tr>
198 
           <tr>
199 
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Review Results </td>
200 
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><select name="review_results" disabled class="form_item" id="review_results">
119 ghuddy 201 
                  <%=DecodeOverallResult( rsQry("review_results") )%>
202 
                </select></td>
129 ghuddy 203 
           </tr>
204 
           <tr>
205 
            <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Issues Raised </td>
161 iaugusti 206 
            <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("issues_raised") )))%></td>
129 ghuddy 207 
           </tr>
208 
           <tr>
209 
             <td align="right" nowrap background="images/bg_form_lightbluedark.gif" class="form_field">Comments</td>
161 iaugusti 210 
             <td colspan="3" bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("review_comments") )))%></td>
129 ghuddy 211 
             </tr>
212 
         </table>
213 
         <br>
214 
         <br>
215 
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
119 ghuddy 216 
              <tr align="center">
217 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Functionality</td>
218 
                </tr>
219 
              <tr>
220 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
221 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
222 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
223 
              </tr>
224 
              <tr>
225 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Meets required functionality </td>
226 
                <td valign="top" bgcolor="#FFFFFF"><select name="fnc_s_meets_functionality" disabled class="form_item" id="fnc_s_meets_functionality">
227 
                  <%=DecodeItemResult( rsQry("fnc_s_meets_functionality") )%>
228 
                </select></td>
161 iaugusti 229 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("fnc_c_meets_functionality") )))%></td>
119 ghuddy 230 
              </tr>
231 
            </table>
129 ghuddy 232 
         <br>
233 
         <br>
234 
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
119 ghuddy 235 
              <tr align="center">
236 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Robustness</td>
237 
              </tr>
238 
              <tr>
239 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
240 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
241 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
242 
              </tr>
243 
              <tr>
244 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Boundary conditions handled </td>
245 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_bound_cond_handled" disabled class="form_item" id="rbs_s_bound_cond_handled">
246 
                    <%=DecodeItemResult( rsQry("rbs_s_bound_cond_handled") )%>
247 
                </select></td>
161 iaugusti 248 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_bound_cond_handled") )))%></td>
119 ghuddy 249 
              </tr>
250 
              <tr>
251 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class interface preconditions tested</td>
252 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_class_interf_precond" disabled class="form_item" id="rbs_s_class_interf_precond">
253 
                  <%=DecodeItemResult( rsQry("rbs_s_class_interf_precond") )%>
254 
                </select></td>
161 iaugusti 255 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_class_interf_precond") )))%></td>
119 ghuddy 256 
              </tr>
129 ghuddy 257 
           <tr>
119 ghuddy 258 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No unititalised data</td>
259 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_no_unitialised_date" disabled class="form_item" id="rbs_s_no_unitialised_date">
260 
                  <%=DecodeItemResult( rsQry("rbs_s_no_unitialised_date") )%>
261 
                </select></td>
161 iaugusti 262 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_no_unitialised_date") )))%></td>
119 ghuddy 263 
              </tr>
129 ghuddy 264 
           <tr>
119 ghuddy 265 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Exception handling</td>
266 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_excep_handing" disabled class="form_item" id="rbs_s_excep_handing">
267 
                  <%=DecodeItemResult( rsQry("rbs_s_excep_handing") )%>
268 
                </select></td>
161 iaugusti 269 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_excep_handing") )))%></td>
119 ghuddy 270 
              </tr>
129 ghuddy 271 
           <tr>
119 ghuddy 272 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Resource mgt (db cxn, memory)</td>
273 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_resource_mng" disabled class="form_item" id="rbs_s_resource_mng">
274 
                  <%=DecodeItemResult( rsQry("rbs_s_resource_mng") )%>
275 
                </select></td>
161 iaugusti 276 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_resource_mng") )))%></td>
119 ghuddy 277 
              </tr>
129 ghuddy 278 
           <tr>
119 ghuddy 279 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Transaction completeness</td>
280 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_trans_complet" disabled class="form_item" id="rbs_s_trans_complet">
281 
                  <%=DecodeItemResult( rsQry("rbs_s_trans_complet") )%>
282 
                </select></td>
161 iaugusti 283 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_trans_complet") )))%></td>
119 ghuddy 284 
              </tr>
129 ghuddy 285 
           <tr>
119 ghuddy 286 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Threadsafety</td>
287 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_threadsafety" disabled class="form_item" id="rbs_s_threadsafety">
288 
                  <%=DecodeItemResult( rsQry("rbs_s_threadsafety") )%>
289 
                </select></td>
161 iaugusti 290 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_threadsafety") )))%></td>
119 ghuddy 291 
              </tr>
129 ghuddy 292 
           <tr>
119 ghuddy 293 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Return values (where appropriate)</td>
294 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_ret_vals" disabled class="form_item" id="rbs_s_ret_vals">
295 
                  <%=DecodeItemResult( rsQry("rbs_s_ret_vals") )%>
296 
                </select></td>
161 iaugusti 297 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_ret_vals") )))%></td>
119 ghuddy 298 
              </tr>
129 ghuddy 299 
           <tr>
119 ghuddy 300 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Correct err handling at Subsys bdys</td>
301 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_corr_err_handling" disabled class="form_item" id="rbs_s_corr_err_handling">
302 
                  <%=DecodeItemResult( rsQry("rbs_s_corr_err_handling") )%>
303 
                </select></td>
161 iaugusti 304 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_corr_err_handling") )))%></td>
119 ghuddy 305 
              </tr>
129 ghuddy 306 
           <tr>
119 ghuddy 307 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">SQL correct and conforming to standards</td>
308 
                <td valign="top" bgcolor="#FFFFFF"><select name="rbs_s_sql_std" disabled class="form_item" id="rbs_s_sql_std">
309 
                  <%=DecodeItemResult( rsQry("rbs_s_sql_std") )%>
310 
                </select></td>
161 iaugusti 311 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("rbs_c_sql_std") )))%></td>
119 ghuddy 312 
              </tr>
313 
            </table>
129 ghuddy 314 
         <br>
315 
         <br>
316 
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
119 ghuddy 317 
              <tr align="center">
318 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Maintainability</td>
319 
              </tr>
320 
              <tr>
321 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
322 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
323 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
324 
              </tr>
325 
              <tr>
326 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">External references explicit (eg: pkg imports)</td>
327 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ext_ref" disabled class="form_item" id="mnt_s_ext_ref">
328 
                    <%=DecodeItemResult( rsQry("mnt_s_ext_ref") )%>
329 
                </select></td>
161 iaugusti 330 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ext_ref") )))%></td>
119 ghuddy 331 
              </tr>
332 
              <tr>
333 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Class size ok</td>
334 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_class_size" disabled class="form_item" id="mnt_s_class_size">
335 
                    <%=DecodeItemResult( rsQry("mnt_s_class_size") )%>
336 
                </select></td>
161 iaugusti 337 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_class_size") )))%></td>
119 ghuddy 338 
              </tr>
339 
              <tr>
340 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Method size ok</td>
341 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_method_size" disabled class="form_item" id="mnt_s_method_size">
342 
                    <%=DecodeItemResult( rsQry("mnt_s_method_size") )%>
343 
                </select></td>
161 iaugusti 344 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_method_size") )))%></td>
119 ghuddy 345 
              </tr>
346 
              <tr>
347 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate commenting</td>
348 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_approp_comm" disabled class="form_item" id="mnt_s_approp_comm">
349 
                    <%=DecodeItemResult( rsQry("mnt_s_approp_comm") )%>
350 
                </select></td>
161 iaugusti 351 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_approp_comm") )))%></td>
119 ghuddy 352 
              </tr>
353 
              <tr>
354 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Indentifiers conform to naming standards</td>
355 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_ident_name_std" disabled class="form_item" id="mnt_s_ident_name_std">
356 
                    <%=DecodeItemResult( rsQry("mnt_s_ident_name_std") )%>
357 
                </select></td>
161 iaugusti 358 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_ident_name_std") )))%></td>
119 ghuddy 359 
              </tr>
360 
              <tr>
361 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Switch statements have defaults</td>
362 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_switch_have_defaults" disabled class="form_item" id="mnt_s_switch_have_defaults">
363 
                    <%=DecodeItemResult( rsQry("mnt_s_switch_have_defaults") )%>
364 
                </select></td>
161 iaugusti 365 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_switch_have_defaults") )))%></td>
119 ghuddy 366 
              </tr>
367 
              <tr>
368 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No literal numeric constants except –1, 0, 1</td>
369 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_lit_num" disabled class="form_item" id="mnt_s_no_lit_num">
370 
                    <%=DecodeItemResult( rsQry("mnt_s_no_lit_num") )%>
371 
                </select></td>
161 iaugusti 372 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_lit_num") )))%></td>
119 ghuddy 373 
              </tr>
374 
              <tr>
375 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">No dead or unused code</td>
376 
                <td valign="top" bgcolor="#FFFFFF"><select name="mnt_s_no_dead_code" disabled class="form_item" id="mnt_s_no_dead_code">
377 
                    <%=DecodeItemResult( rsQry("mnt_s_no_dead_code") )%>
378 
                </select></td>
161 iaugusti 379 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("mnt_c_no_dead_code") )))%></td>
119 ghuddy 380 
              </tr>
381 
            </table>
129 ghuddy 382 
         <br>
383 
         <br>
384 
         <table width="100%"  border="0" cellspacing="1" cellpadding="4">
119 ghuddy 385 
              <tr align="center">
386 
                <td colspan="3" class="form_ttl" background="images/bg_form_lightbluedark.gif">Design Issues </td>
387 
              </tr>
388 
              <tr>
389 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Item</td>
390 
                <td width="1%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Check</td>
391 
                <td width="100%" align="center" background="images/bg_form_lightbluedark.gif" class="form_field">Comment</td>
392 
              </tr>
393 
              <tr>
394 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard design patterns</td>
395 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_des_patt" disabled class="form_item" id="dei_s_std_des_patt">
396 
                    <%=DecodeItemResult( rsQry("dei_s_std_des_patt") )%>
397 
                </select></td>
161 iaugusti 398 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_des_patt") )))%></td>
119 ghuddy 399 
              </tr>
400 
              <tr>
401 
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate algorithms (consider performance)</td>
402 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_algor" disabled class="form_item" id="dei_s_approp_algor">
403 
                    <%=DecodeItemResult( rsQry("dei_s_approp_algor") )%>
404 
                </select></td>
161 iaugusti 405 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_algor") )))%></td>
119 ghuddy 406 
              </tr>
407 
              <tr>
408 
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Use of appropriate objects (consider bloat, object focus, encapsulation)</td>
409 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_obj" disabled class="form_item" id="dei_s_approp_obj">
410 
                    <%=DecodeItemResult( rsQry("dei_s_approp_obj") )%>
411 
                </select></td>
161 iaugusti 412 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_obj") )))%></td>
119 ghuddy 413 
              </tr>
414 
              <tr>
415 
                <td valign="top" background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate user error messages</td>
416 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_err_msg" disabled class="form_item" id="dei_s_approp_err_msg">
417 
                    <%=DecodeItemResult( rsQry("dei_s_approp_err_msg") )%>
418 
                </select></td>
161 iaugusti 419 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_err_msg") )))%></td>
119 ghuddy 420 
              </tr>
421 
              <tr>
422 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Use of standard framework components</td>
423 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_std_framew_comp" disabled class="form_item" id="dei_s_std_framew_comp">
424 
                    <%=DecodeItemResult( rsQry("dei_s_std_framew_comp") )%>
425 
                </select></td>
161 iaugusti 426 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_std_framew_comp") )))%></td>
119 ghuddy 427 
              </tr>
428 
              <tr>
429 
                <td valign="top" nowrap background="images/bg_form_lightbluedark.gif" class="form_item">Appropriate logging</td>
430 
                <td valign="top" bgcolor="#FFFFFF"><select name="dei_s_approp_logging" disabled class="form_item" id="dei_s_approp_logging">
431 
                    <%=DecodeItemResult( rsQry("dei_s_approp_logging") )%>
432 
                </select></td>
161 iaugusti 433 
                <td bgcolor="#FFFFFF" class="form_item"><%=NewLine_To_BR( To_HTML( SQLstring (rsQry("dei_c_approp_logging") )))%></td>
119 ghuddy 434 
              </tr>
435 
            </table>
129 ghuddy 436 
         <br>
437 
         <br></td>
119 ghuddy 438 
          </tr>
439 
        </table></td>
440 
    </tr>
441 
    <tr>
442 
      <td height="1%" width="1%"><img src="images/h_trsp_dot.gif" width="5" height="5"></td>
443 
      <td valign="top" nowrap colspan="3" class="wform_ttl" background="images/lbox_bg_blue.gif" align="right">
129 ghuddy 444 
     <input type="submit" name="btn" value="Edit" <%If pageIsEditable Then%>class="form_btn"<%Else%>disabled class="form_btn_disabled"<%End If%>>
445 
     <input type="reset" name="btn" value="Close" class="form_btn" onclick="self.close()">
446 
     </td>
119 ghuddy 447 
    </tr>
448 
  </table>
449 
  <input type="hidden" name="pv_id" value="<%=parPv_id%>">
450 
  <input type="hidden" name="rtag_id" value="<%=parRtag_id%>">
451 
</form>
452 
</body>
453 
</html>
454 
 
455 
 
456 
<!-- DESTRUCTOR ------->
457 
<!--#include file="common/destructor.asp"-->