| 1293 |
dpurdie |
1 |
[%# Screen for the create topic form. #%]
|
|
|
2 |
|
|
|
3 |
[% PROCESS header.html.tmpl version = version displaymenu = 1
|
|
|
4 |
closehead = 1 help = "x394.html" %]
|
|
|
5 |
|
|
|
6 |
[%# Display any "feedback" to the user if necessary. #%]
|
|
|
7 |
[% IF feedback != '' %]
|
|
|
8 |
<span class="feedback">[% feedback %]</span>
|
|
|
9 |
[% END %]
|
|
|
10 |
|
|
|
11 |
<P>
|
|
|
12 |
|
|
|
13 |
<H1>Create new topic</H1>
|
|
|
14 |
|
|
|
15 |
<P>
|
|
|
16 |
|
|
|
17 |
[%# Show any topics that this topic will obsolete #%]
|
|
|
18 |
[% IF obsoleted_topics.size > 0 %]
|
|
|
19 |
<span style="obsolete-header">Topics to obsolete:</span>
|
|
|
20 |
[% FOREACH topic = obsoleted_topics %]
|
|
|
21 |
<a href="[% topic.view_url %]">[% topic.title | html_entity %]</a>[% IF ! loop.last() %],[% END %]
|
|
|
22 |
|
|
|
23 |
[% END %]
|
|
|
24 |
<p>
|
|
|
25 |
[% END %]
|
|
|
26 |
|
|
|
27 |
<FORM METHOD="post" ENCTYPE="multipart/form-data" ACCEPT-CHARSET="UTF-8">
|
|
|
28 |
<INPUT TYPE="hidden" NAME="action" VALUE="submit_new_topic" />
|
|
|
29 |
<INPUT TYPE="hidden" NAME="obsoletes" VALUE="[% obsoletes %]" />
|
|
|
30 |
|
|
|
31 |
[%# The topic title input field #%]
|
|
|
32 |
Topic title:
|
|
|
33 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
34 |
onmouseover="return create_window('The topic title should be a concise but \
|
|
|
35 |
informative summary of the code to be reviewed. The title is used in the \
|
|
|
36 |
subject of sent emails, and in the topic list screen.');">(?)</a></FONT>
|
|
|
37 |
<BR/>
|
|
|
38 |
<INPUT TYPE="text" NAME="topic_title" VALUE="[% topic_title | html_entity %]" SIZE=70 MAXLENGTH=70 />
|
|
|
39 |
<P>
|
|
|
40 |
|
|
|
41 |
[%# The topic description input field #%]
|
|
|
42 |
Topic description:
|
|
|
43 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
44 |
onmouseover="return create_window('\
|
|
|
45 |
The topic description should contain enough information \
|
|
|
46 |
for a reviewer to understand broadly what the code change \
|
|
|
47 |
achieves. This information is sent with the new topic \
|
|
|
48 |
notification email to all reviewers.')">(?)</a></FONT>
|
|
|
49 |
<BR/>
|
|
|
50 |
<TEXTAREA NAME="topic_description" ROWS=12 COLS=70 WRAP="soft">[% topic_description | html_entity %]</TEXTAREA>
|
|
|
51 |
<P>
|
|
|
52 |
|
|
|
53 |
<TABLE>
|
|
|
54 |
[% IF maximum_topic_size_lines != 0 || suggested_topic_size_lines != 0 %]
|
|
|
55 |
<TR><TD COLSPAN="3">
|
|
|
56 |
[% IF maximum_topic_size_lines != 0 %]
|
|
|
57 |
<EM>Topics cannot be larger than [% maximum_topic_size_lines %] lines.</EM>
|
|
|
58 |
[% END %]
|
|
|
59 |
[% IF suggested_topic_size_lines != 0 %]
|
|
|
60 |
<EM>The suggested topic size limit is [% suggested_topic_size_lines %] lines.</EM>
|
|
|
61 |
[% END %]
|
|
|
62 |
</TD></TR>
|
|
|
63 |
[% END %]
|
|
|
64 |
[%# The topic text upload button #%]
|
|
|
65 |
<TR>
|
| 1301 |
dpurdie |
66 |
<TD>Topic text upload:
|
| 1293 |
dpurdie |
67 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
68 |
onmouseover="return create_window('\
|
|
|
69 |
The uploaded file contains the actual text of the review. \
|
|
|
70 |
Typically, the text is the output of a command such as: \
|
|
|
71 |
<p> \
|
|
|
72 |
cvs diff -uN > output.txt \
|
|
|
73 |
<p> or <p> \
|
|
|
74 |
svn diff -uN > output.txt \
|
|
|
75 |
<p> or <p> \
|
|
|
76 |
diff -urN ../old-version/ . > output.txt \
|
|
|
77 |
<p> \
|
|
|
78 |
Non-unidiff files, or ordinary text files can be uploaded, \
|
|
|
79 |
but will be treated simply as \'new files\'. \
|
|
|
80 |
<p> \
|
|
|
81 |
This should be left blank if you are reviewing files \
|
|
|
82 |
directly from a repository.')">(?)</a></FONT>
|
|
|
83 |
</TD>
|
|
|
84 |
<TD COLSPAN="3"><INPUT TYPE="file" NAME="topic_file" VALUE="[% topic_file | html_entity %]" SIZE=40 MAXLENGTH=200 /></TD>
|
|
|
85 |
</TR>
|
|
|
86 |
|
|
|
87 |
[% IF allow_repositories != 0 %]
|
|
|
88 |
[%# The diff fetcher #%]
|
|
|
89 |
<TR>
|
|
|
90 |
<TD>
|
|
|
91 |
Start tag:
|
|
|
92 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
93 |
onmouseover="return create_window('\
|
|
|
94 |
Rather than uploading the topic text, if the repository \
|
|
|
95 |
supports it, the text can be fetched by querying the \
|
|
|
96 |
repository, given start and/or end tags, and a module name. \
|
|
|
97 |
The start tag, end tag, and module fields are ignored if text \
|
|
|
98 |
is uploaded.<p> \
|
|
|
99 |
If only one tag value is specified, the full contents of all \
|
|
|
100 |
files in the specified module corresponding to the entered tag \
|
|
|
101 |
will be downloaded.')">(?)</a></FONT>
|
| 1300 |
dpurdie |
102 |
<FONT SIZE="-2"><A HREF="javascript:void(0);"onmouseover="return create_window('\
|
|
|
103 |
Subversion Only\: The start tag may be a repository revision number or the name of a label \
|
| 1306 |
dpurdie |
104 |
within the \'Modules\' \'tags\' directory. <p>If no start tag is provided then the entire package \
|
|
|
105 |
will be treated as \'new\'. This may take some time to process. \
|
| 1300 |
dpurdie |
106 |
')">(hint)</a></FONT>
|
| 1293 |
dpurdie |
107 |
</TD>
|
|
|
108 |
<TD>
|
| 1301 |
dpurdie |
109 |
<INPUT TYPE="text" NAME="start_tag" VALUE="[% start_tag | html_entity %]" SIZE=30 MAXLENGTH=150 />
|
| 1293 |
dpurdie |
110 |
</TD>
|
| 1301 |
dpurdie |
111 |
<TR>
|
| 1293 |
dpurdie |
112 |
<TD>End tag: <FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
113 |
onmouseover="return create_window('\
|
|
|
114 |
Rather than uploading the topic text, if the repository \
|
|
|
115 |
supports it, the text can be fetched by querying the \
|
|
|
116 |
repository, given start and/or end tags, and a module name. \
|
|
|
117 |
The start tag, end tag, and module fields are ignored if text \
|
|
|
118 |
is uploaded. <p> \
|
|
|
119 |
If only one tag value is specified, the full contents of all \
|
|
|
120 |
files in the specified module corresponding to the entered tag \
|
| 1300 |
dpurdie |
121 |
will be downloaded.')">(?)</A></FONT>
|
|
|
122 |
<FONT SIZE="-2"><A HREF="javascript:void(0);"onmouseover="return create_window('\
|
|
|
123 |
Subversion Only\: The end tag may be a repository revision number or the name of a label \
|
| 1306 |
dpurdie |
124 |
within the \'Modules\' \'tags\' directory. <p>If no end tag is provided then the \'HEAD\' of the Module will be used. \
|
| 1300 |
dpurdie |
125 |
')">(hint)</a></FONT>
|
|
|
126 |
</TD>
|
| 1293 |
dpurdie |
127 |
<TD>
|
| 1301 |
dpurdie |
128 |
<INPUT TYPE="text" NAME="end_tag" VALUE="[% end_tag | html_entity %]" SIZE=30 MAXLENGTH=150 />
|
| 1293 |
dpurdie |
129 |
</TD>
|
|
|
130 |
</TR>
|
|
|
131 |
<TR>
|
|
|
132 |
<TD>
|
|
|
133 |
Module:
|
|
|
134 |
<FONT SIZE="-2"><A HREF="javascript:void(0);"
|
|
|
135 |
onmouseover="return create_window('\
|
|
|
136 |
This is the path to the file or module relative to the repository \
|
|
|
137 |
root that should be inspected. It is ignored if text is uploaded.')">(?)</a></FONT>
|
| 1300 |
dpurdie |
138 |
<FONT SIZE="-2"><A HREF="javascript:void(0);"onmouseover="return create_window('\
|
|
|
139 |
When a Subversion Repository is selected the \'Module\' field specifies the path from \
|
| 1306 |
dpurdie |
140 |
the repository base to the packages development branch. ie:\'AUPERASVN01/DevTools/core_devl/trunk\'. \
|
| 1300 |
dpurdie |
141 |
')">(hint)</a></FONT>
|
| 1293 |
dpurdie |
142 |
</TD>
|
| 1301 |
dpurdie |
143 |
<TD COLSPAN="3">
|
|
|
144 |
<INPUT TYPE="text" NAME="module" VALUE="[% module | html_entity %]" SIZE=62 MAXLENGTH=150 />
|
| 1293 |
dpurdie |
145 |
</TD>
|
|
|
146 |
</TR>
|
|
|
147 |
|
|
|
148 |
[%# The default_to_head input field #%]
|
| 1300 |
dpurdie |
149 |
[% IF supporting_CVS %]
|
| 1301 |
dpurdie |
150 |
<TR>
|
|
|
151 |
<TD> </TD><TD> </TD>
|
| 1300 |
dpurdie |
152 |
<TD>Default to HEAD:
|
| 1293 |
dpurdie |
153 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
154 |
onmouseover="return create_window('\
|
|
|
155 |
Fall back to HEAD revision if a file does not exist on either tag. \
|
|
|
156 |
This will allow diffs between a branch and the HEAD revision, without \
|
|
|
157 |
showing files not on the branch as deleted. \
|
|
|
158 |
This option affects only CVS topics currently.')">(?)</A></FONT>
|
|
|
159 |
</TD>
|
|
|
160 |
<TD COLSPAN="3"><INPUT TYPE="checkbox" NAME="default_to_head" [% IF default_to_head %]CHECKED[% END %] /></TD>
|
|
|
161 |
</TR>
|
|
|
162 |
[% END %]
|
| 1300 |
dpurdie |
163 |
[% END %]
|
| 1293 |
dpurdie |
164 |
|
|
|
165 |
[%# The repository the review is made against #%]
|
|
|
166 |
[%# Only display the repository select if there is more than one #%]
|
|
|
167 |
[% IF repositories.size > 1 %]
|
|
|
168 |
<TR>
|
|
|
169 |
<TD>Repository:
|
|
|
170 |
<FONT SIZE="-2"><A HREF="javascript:void(0);"
|
|
|
171 |
onmouseover="return create_window('\
|
|
|
172 |
The SCM system (eg CVS, Subversion, ClearCase) \
|
|
|
173 |
which the topic text was prepared against. If \
|
|
|
174 |
this is correctly set, this provides the \
|
|
|
175 |
ability to view the entire contents of a file \
|
|
|
176 |
with and/or without a proposed change, which \
|
|
|
177 |
an aid in the reviewing process.')">(?)</a></FONT>
|
| 1300 |
dpurdie |
178 |
<FONT SIZE="-2"><A HREF="javascript:void(0);"onmouseover="return create_window('\
|
|
|
179 |
Subversion Only\: Selects the Repository Server. The \Module\' name provides the Repository path. \
|
|
|
180 |
')">(hint)</a></FONT>
|
|
|
181 |
|
| 1293 |
dpurdie |
182 |
</TD>
|
| 1300 |
dpurdie |
183 |
<TD COLSPAN="3">
|
|
|
184 |
<SELECT NAME="repository">
|
| 1293 |
dpurdie |
185 |
[% FOREACH entry = repositories %]
|
|
|
186 |
[% IF entry == default_repository %]
|
|
|
187 |
<OPTION SELECTED VALUE="[% entry %]">[% entry %]</OPTION>
|
|
|
188 |
[% ELSE %]
|
|
|
189 |
<OPTION VALUE="[% entry %]">[% entry %]</OPTION>
|
|
|
190 |
[% END %]
|
|
|
191 |
[% END %]
|
|
|
192 |
</SELECT>
|
|
|
193 |
</TD>
|
|
|
194 |
</TR>
|
|
|
195 |
[% END %]
|
|
|
196 |
|
|
|
197 |
[% IF projects_enabled != 0 %]
|
|
|
198 |
|
|
|
199 |
[%# The project the review belongs to #%]
|
|
|
200 |
<TR>
|
| 1300 |
dpurdie |
201 |
|
| 1293 |
dpurdie |
202 |
<TD>Project:
|
|
|
203 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
204 |
onmouseover="return create_window('\
|
|
|
205 |
Topics are associated with a specific project, which can be \
|
|
|
206 |
used as filtering criteria in the search screen.')">(?)</a></FONT>
|
|
|
207 |
</TD>
|
|
|
208 |
<TD COLSPAN="3"><SELECT NAME="projectid">
|
|
|
209 |
[% FOREACH project = projects %]
|
|
|
210 |
[% IF project.id == default_projectid %]
|
|
|
211 |
<OPTION SELECTED VALUE="[% project.id %]">[% project.name | html_entity %]</OPTION>
|
|
|
212 |
[% ELSE %]
|
|
|
213 |
<OPTION VALUE="[% project.id %]">[% project.name | html_entity %]</OPTION>
|
|
|
214 |
[% END %]
|
|
|
215 |
[% END %]
|
|
|
216 |
</SELECT>
|
|
|
217 |
</TD>
|
|
|
218 |
</TR>
|
|
|
219 |
|
|
|
220 |
[% END %]
|
|
|
221 |
|
|
|
222 |
[%# The bug ids input field #%]
|
|
|
223 |
[% IF bugdb_enabled != 0 %]
|
|
|
224 |
<TR>
|
|
|
225 |
<TD>Bug IDs:
|
|
|
226 |
<FONT SIZE="-2"><a href="javascript:void(0)"
|
|
|
227 |
onmouseover="return create_window('\
|
|
|
228 |
Indicates what bug identifiers are addressed by this code change. \
|
|
|
229 |
These are space or comma separated identifiers, such as: \
|
|
|
230 |
<p> \
|
|
|
231 |
1634 \
|
|
|
232 |
<p> \
|
|
|
233 |
or \
|
|
|
234 |
<p> \
|
|
|
235 |
1534, 4625, 1243 \
|
|
|
236 |
<p> \
|
|
|
237 |
The appropriate links to the bug-tracking system will be made \
|
|
|
238 |
when the topic is viewed, for the reviewer\'s reference. \
|
|
|
239 |
<p> \
|
|
|
240 |
In addition, if integrating with Bugzilla, when the topic state \
|
|
|
241 |
is changed, a comment will be inserted automatically to the \
|
|
|
242 |
associated bugs for cross referencing. When a bug is viewed, \
|
|
|
243 |
it can be easily determined what code fixes have been applied \
|
|
|
244 |
to it.')">(?)</a></FONT>
|
|
|
245 |
</TD>
|
|
|
246 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="bug_ids" VALUE="[% bug_ids | html_entity %]" SIZE=30 MAXLENGTH=50 /></TD>
|
|
|
247 |
</TR>
|
|
|
248 |
[% END %]
|
|
|
249 |
|
| 1301 |
dpurdie |
250 |
<tr><td> </td></tr>
|
|
|
251 |
<tr><td><B>Email Addresses</B></td></tr>
|
| 1293 |
dpurdie |
252 |
[%# The email input field #%]
|
|
|
253 |
<TR>
|
| 1301 |
dpurdie |
254 |
<TD>You (Author's):
|
| 1293 |
dpurdie |
255 |
<FONT SIZE="-2"><A HREF="javascript:void(0);"
|
|
|
256 |
onmouseover="return create_window('\
|
|
|
257 |
This is the Author\'s email address. All comments made against a topic \
|
|
|
258 |
will be sent to this address. The new topic notification email \
|
|
|
259 |
will also be sent to this address.')">(?)</a></FONT>
|
|
|
260 |
</TD>
|
|
|
261 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="email" VALUE="[% email | html_entity %]" SIZE=50 MAXLENGTH=80 /></TD>
|
|
|
262 |
</TR>
|
|
|
263 |
|
|
|
264 |
[%# The reviewers input field #%]
|
|
|
265 |
<TR>
|
|
|
266 |
<TD>Reviewers:
|
|
|
267 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
268 |
onmouseover="return create_window('\
|
|
|
269 |
This is a comma separated list of email addresses, which are the \
|
|
|
270 |
people who need to review this code. When the topic is created, \
|
|
|
271 |
the new topic notification email will be sent to these addresses.')">(?)</a></FONT>
|
|
|
272 |
</TD>
|
|
|
273 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="reviewers" VALUE="[% reviewers | html_entity %]" SIZE=50 MAXLENGTH=1024 /></TD>
|
|
|
274 |
</TR>
|
|
|
275 |
|
|
|
276 |
[%# The Cc input field #%]
|
|
|
277 |
<TR>
|
|
|
278 |
<TD>Cc:
|
|
|
279 |
<FONT SIZE="-2"><a href="javascript:void(0);"
|
|
|
280 |
onmouseover="return create_window('\
|
|
|
281 |
This is a comma separated list of email addresses, which are \
|
|
|
282 |
not intended to be reviewers, but typically a mailing list \
|
|
|
283 |
to notify a number of people about the creation of a new topic.')">(?)</a></FONT>
|
|
|
284 |
</TD>
|
|
|
285 |
<TD COLSPAN="3"><INPUT TYPE="text" NAME="cc" VALUE="[% cc | html_entity %]" SIZE=50 MAXLENGTH=1024 /></TD>
|
|
|
286 |
</TR>
|
|
|
287 |
</TABLE>
|
|
|
288 |
|
|
|
289 |
<P>
|
|
|
290 |
<INPUT TYPE="submit" NAME=".submit" VALUE="Create Topic" />
|
|
|
291 |
|
|
|
292 |
</FORM>
|
|
|
293 |
|
|
|
294 |
[% PROCESS trailer.html.tmpl %]
|
|
|
295 |
|
|
|
296 |
</BODY>
|
|
|
297 |
</HTML>
|